diff mbox series

pinctrl: ralink: pinctrl-rt2880: avoid to error in calls is pin is already enabled

Message ID 20210604055337.20407-1-sergio.paracuellos@gmail.com
State New
Headers show
Series pinctrl: ralink: pinctrl-rt2880: avoid to error in calls is pin is already enabled | expand

Commit Message

Sergio Paracuellos June 4, 2021, 5:53 a.m. UTC
In 'rt2880_pmx_group_enable' driver is printing an error and returning
-EBUSY if a pin has been already enabled. This becomes in anoying messages
in the caller when this happens like the following:

rt2880-pinmux pinctrl: pcie is already enabled
mt7621-pci 1e140000.pcie: Error applying setting, reverse things back

To avoid this just print the already enabled message in the pinctrl
driver and return 0 instead to don't confuse the user with a real
bad problem.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
 drivers/pinctrl/ralink/pinctrl-rt2880.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij June 7, 2021, 7:08 a.m. UTC | #1
On Fri, Jun 4, 2021 at 7:53 AM Sergio Paracuellos
<sergio.paracuellos@gmail.com> wrote:

> In 'rt2880_pmx_group_enable' driver is printing an error and returning

> -EBUSY if a pin has been already enabled. This becomes in anoying messages

> in the caller when this happens like the following:

>

> rt2880-pinmux pinctrl: pcie is already enabled

> mt7621-pci 1e140000.pcie: Error applying setting, reverse things back

>

> To avoid this just print the already enabled message in the pinctrl

> driver and return 0 instead to don't confuse the user with a real

> bad problem.

>

> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>


Patch applied for fixes.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/ralink/pinctrl-rt2880.c b/drivers/pinctrl/ralink/pinctrl-rt2880.c
index 1f4bca854add..a9b511c7e850 100644
--- a/drivers/pinctrl/ralink/pinctrl-rt2880.c
+++ b/drivers/pinctrl/ralink/pinctrl-rt2880.c
@@ -127,7 +127,7 @@  static int rt2880_pmx_group_enable(struct pinctrl_dev *pctrldev,
 	if (p->groups[group].enabled) {
 		dev_err(p->dev, "%s is already enabled\n",
 			p->groups[group].name);
-		return -EBUSY;
+		return 0;
 	}
 
 	p->groups[group].enabled = 1;