| Message ID | 20210717174836.14776-3-paul@crapouillou.net |
|---|---|
| State | Accepted |
| Commit | 6626a76ef857c937ba7b96f0ea8bb5451c1419eb |
| Headers | show |
| Series | [1/3] pinctrl: ingenic: Fix incorrect pull up/down info | expand |
Hi Paul, On 2021/7/18 上午1:48, Paul Cercueil wrote: > Compute the max register from the GPIO chip offset and number of GPIO > chips. > > This permits to read all registers from debugfs. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > --- > drivers/pinctrl/pinctrl-ingenic.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Tested-by: 周琰杰 (Zhou Yanjie)<zhouyanjie@wanyeetech.com> > diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c > index 263498be8e31..2bbcb8063a16 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -3759,6 +3759,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) > void __iomem *base; > const struct ingenic_chip_info *chip_info; > struct device_node *node; > + struct regmap_config regmap_config; > unsigned int i; > int err; > > @@ -3776,8 +3777,10 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) > if (IS_ERR(base)) > return PTR_ERR(base); > > - jzpc->map = devm_regmap_init_mmio(dev, base, > - &ingenic_pinctrl_regmap_config); > + regmap_config = ingenic_pinctrl_regmap_config; > + regmap_config.max_register = chip_info->num_chips * chip_info->reg_offset; > + > + jzpc->map = devm_regmap_init_mmio(dev, base, ®map_config); > if (IS_ERR(jzpc->map)) { > dev_err(dev, "Failed to create regmap\n"); > return PTR_ERR(jzpc->map);
On Sat, Jul 17, 2021 at 7:48 PM Paul Cercueil <paul@crapouillou.net> wrote: > Compute the max register from the GPIO chip offset and number of GPIO > chips. > > This permits to read all registers from debugfs. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> Patch applied! Yours, Linus Walleij
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index 263498be8e31..2bbcb8063a16 100644 --- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c @@ -3759,6 +3759,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) void __iomem *base; const struct ingenic_chip_info *chip_info; struct device_node *node; + struct regmap_config regmap_config; unsigned int i; int err; @@ -3776,8 +3777,10 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) if (IS_ERR(base)) return PTR_ERR(base); - jzpc->map = devm_regmap_init_mmio(dev, base, - &ingenic_pinctrl_regmap_config); + regmap_config = ingenic_pinctrl_regmap_config; + regmap_config.max_register = chip_info->num_chips * chip_info->reg_offset; + + jzpc->map = devm_regmap_init_mmio(dev, base, ®map_config); if (IS_ERR(jzpc->map)) { dev_err(dev, "Failed to create regmap\n"); return PTR_ERR(jzpc->map);
Compute the max register from the GPIO chip offset and number of GPIO chips. This permits to read all registers from debugfs. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- drivers/pinctrl/pinctrl-ingenic.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)