diff mbox series

[02/16] dt-bindings: arm: renesas: Document SMARC EVK

Message ID 20211221094717.16187-3-prabhakar.mahadev-lad.rj@bp.renesas.com
State Accepted
Commit 4affc072e4fef6d1778f957037f255a6acdd44e2
Headers show
Series Add new Renesas RZ/V2L SoC and Renesas RZ/V2L SMARC EVK support | expand

Commit Message

Lad Prabhakar Dec. 21, 2021, 9:47 a.m. UTC
From: Biju Das <biju.das.jz@bp.renesas.com>

Document Renesas SMARC EVK board which is based on RZ/V2L (R9A07G054)
SoC. The SMARC EVK consists of RZ/V2L SoM module and SMARC carrier board,
the SoM module sits on top of the carrier board.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 Documentation/devicetree/bindings/arm/renesas.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring Dec. 22, 2021, 6:23 p.m. UTC | #1
On Tue, Dec 21, 2021 at 09:47:03AM +0000, Lad Prabhakar wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Document Renesas SMARC EVK board which is based on RZ/V2L (R9A07G054)
> SoC. The SMARC EVK consists of RZ/V2L SoM module and SMARC carrier board,
> the SoM module sits on top of the carrier board.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/arm/renesas.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> index 55a5aec418ab..fa435d6fda77 100644
> --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> @@ -423,6 +423,8 @@ properties:
>  
>        - description: RZ/V2L (R9A07G054)
>          items:
> +          - enum:
> +              - renesas,smarc-evk # SMARC EVK

This and patch 1 should be combined. Changing the number of compatible 
entries doesn't make sense.

>            - enum:
>                - renesas,r9a07g054l1 # Single Cortex-A55 RZ/V2L
>                - renesas,r9a07g054l2 # Dual Cortex-A55 RZ/V2L
> -- 
> 2.17.1
> 
>
Prabhakar Dec. 22, 2021, 7:37 p.m. UTC | #2
Hi Rob,

Thank you for the review.

On Wed, Dec 22, 2021 at 6:23 PM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Dec 21, 2021 at 09:47:03AM +0000, Lad Prabhakar wrote:
> > From: Biju Das <biju.das.jz@bp.renesas.com>
> >
> > Document Renesas SMARC EVK board which is based on RZ/V2L (R9A07G054)
> > SoC. The SMARC EVK consists of RZ/V2L SoM module and SMARC carrier board,
> > the SoM module sits on top of the carrier board.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > ---
> >  Documentation/devicetree/bindings/arm/renesas.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
> > index 55a5aec418ab..fa435d6fda77 100644
> > --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> > @@ -423,6 +423,8 @@ properties:
> >
> >        - description: RZ/V2L (R9A07G054)
> >          items:
> > +          - enum:
> > +              - renesas,smarc-evk # SMARC EVK
>
> This and patch 1 should be combined. Changing the number of compatible
> entries doesn't make sense.
>
Will merge this with patch 1. Is it OK if I include your Ack when merged?

Cheers,
Prabhakar

> >            - enum:
> >                - renesas,r9a07g054l1 # Single Cortex-A55 RZ/V2L
> >                - renesas,r9a07g054l2 # Dual Cortex-A55 RZ/V2L
> > --
> > 2.17.1
> >
> >
Geert Uytterhoeven Jan. 21, 2022, 2:44 p.m. UTC | #3
On Tue, Dec 21, 2021 at 10:47 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
>
> Document Renesas SMARC EVK board which is based on RZ/V2L (R9A07G054)
> SoC. The SMARC EVK consists of RZ/V2L SoM module and SMARC carrier board,
> the SoM module sits on top of the carrier board.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.18, merged with the previous
patch.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/renesas.yaml b/Documentation/devicetree/bindings/arm/renesas.yaml
index 55a5aec418ab..fa435d6fda77 100644
--- a/Documentation/devicetree/bindings/arm/renesas.yaml
+++ b/Documentation/devicetree/bindings/arm/renesas.yaml
@@ -423,6 +423,8 @@  properties:
 
       - description: RZ/V2L (R9A07G054)
         items:
+          - enum:
+              - renesas,smarc-evk # SMARC EVK
           - enum:
               - renesas,r9a07g054l1 # Single Cortex-A55 RZ/V2L
               - renesas,r9a07g054l2 # Dual Cortex-A55 RZ/V2L