diff mbox series

pinctrl: starfive: fix semicolon.cocci warnings

Message ID 20220206003735.GA94316@d6598ff186c2
State Accepted
Commit 9c03e49e0cc626d8c6e167607833e3ced5a16c00
Headers show
Series pinctrl: starfive: fix semicolon.cocci warnings | expand

Commit Message

kernel test robot Feb. 6, 2022, 12:37 a.m. UTC 
From: kernel test robot <lkp@intel.com>

drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: ec648f6b7686b716424e8e73eebb4c11ae199187 pinctrl: starfive: Add pinctrl driver for StarFive SoCs
:::::: branch date: 6 hours ago
:::::: commit date: 7 weeks ago

 pinctrl-starfive.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Emil Renner Berthing Feb. 6, 2022, 11:58 p.m. UTC | #1 
On Sun, 6 Feb 2022 at 01:38, kernel test robot <lkp@intel.com> wrote:
>
> From: kernel test robot <lkp@intel.com>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Thanks. There is already a previous patch for this although it was
sent before this code was in Linus' tree:
https://lore.kernel.org/all/20211222073522.123656-1-yang.lee@linux.alibaba.com/

/Emil
Linus Walleij Feb. 11, 2022, 12:48 a.m. UTC | #2 
On Sun, Feb 6, 2022 at 1:37 AM kernel test robot <lkp@intel.com> wrote:

> From: kernel test robot <lkp@intel.com>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
>  Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>

Applied this patch and added the alibaba reporters as
Reported-by.

Yours,
Linus Walleij
diff mbox series

Patch

--- a/drivers/pinctrl/pinctrl-starfive.c
+++ b/drivers/pinctrl/pinctrl-starfive.c
@@ -1026,7 +1026,7 @@  static int starfive_gpio_set_config(stru
 		break;
 	default:
 		return -ENOTSUPP;
-	};
+	}
 
 	starfive_padctl_rmw(sfp, starfive_gpio_to_pin(sfp, gpio), mask, value);
 	return 0;