From patchwork Tue Aug 16 09:09:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Shiu X-Patchwork-Id: 597705 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DCDEC2BB41 for ; Tue, 16 Aug 2022 09:39:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233714AbiHPJjw (ORCPT ); Tue, 16 Aug 2022 05:39:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233738AbiHPJj1 (ORCPT ); Tue, 16 Aug 2022 05:39:27 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B437A6AA23; Tue, 16 Aug 2022 02:09:32 -0700 (PDT) X-UUID: 6fb4a6f92b5e4a0fbc338d31687428da-20220816 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=nTDkzXP779v1onwYVpNERKCNAZl7uIj+G6XLFlu+OrI=; b=oSWAgMmkVKiZo8o5UR6n0l424do7eFvU9EuczQRw3XA3tB/A5QPReVHH/xQ4LKtw8wajDzpaIHnk9QOLbY6q68m2C2U5cNG3oUgD5p0vdJL3CRixqhgPbeT6WmTg1snvUUNmkQCThpyXRLFyKGQgQ7mFGQxuAu9BdheNY2heBww=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.9, REQID:728d4889-b26d-42fa-ad8c-369e73d472fd, OB:0, LO B:0,IP:0,URL:0,TC:0,Content:-5,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_ Ham,ACTION:release,TS:-5 X-CID-META: VersionHash:3d8acc9, CLOUDID:badd73fd-9e71-4a0f-ba6b-417998daea35, C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil ,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 6fb4a6f92b5e4a0fbc338d31687428da-20220816 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 388599243; Tue, 16 Aug 2022 17:09:25 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.186) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 16 Aug 2022 17:09:24 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Tue, 16 Aug 2022 17:09:24 +0800 From: Will Shiu To: , , , , , CC: Subject: [PATCH 1/1] Pinctrl: Add in zero check Date: Tue, 16 Aug 2022 17:09:03 +0800 Message-ID: <20220816090903.19558-1-Will.Shiu@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org add in check of buffer offset to avoid the exception when input 0 size. Signed-off-by: Will Shiu --- drivers/pinctrl/pinmux.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index f94d43b082d9..646dff591b21 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -689,6 +689,9 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf, if (len > PINMUX_SELECT_MAX) return -ENOMEM; + if (len <= 0) + return -EINVAL; + buf = kzalloc(PINMUX_SELECT_MAX, GFP_KERNEL); if (!buf) return -ENOMEM;