| Message ID | 20230222111213.2241633-2-keguang.zhang@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Devicetree support for Loongson-1 GPIO | expand |
On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote: > > Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti: > > This patch updates copyright and author information. > > ... > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > Have you talked to your lawers? This is an inequivalent to what was written > below. > Yes. > > /* > > * GPIO Driver for Loongson 1 SoC > > * > > - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com> > > - * > > - * This file is licensed under the terms of the GNU General Public > > - * License version 2. This program is licensed "as is" without any > > - * warranty of any kind, whether express or implied. > > + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com> > > */ > > ... > > > -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>"); > > +MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>"); > > So, which name here is in your official documents? > Keguang Zhang is my official. > -- > With Best Regards, > Andy Shevchenko > > -- Best regards, Kelvin Cheung
On 02/03/2023 12:09, Kelvin Cheung wrote: > On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote: >> >> Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti: >>> This patch updates copyright and author information. >> >> ... >> >>> +// SPDX-License-Identifier: GPL-2.0-or-later >> >> Have you talked to your lawers? This is an inequivalent to what was written >> below. >> > Yes. Yes to what? You now change the license... and commit msg does not explain it and does not justifies it. What is even weirder that your lawyers agreed on GPLv3! With GPLv3 you need to open a lot from your products... Not mentioning that they agreed on future GPLv4 and GPLv5, that's even weirder because GPLv4 might be saying you need to buy me flowers... Best regards, Krzysztof
On Thu, Mar 2, 2023 at 7:40 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 02/03/2023 12:09, Kelvin Cheung wrote: > > On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote: > >> > >> Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti: > >>> This patch updates copyright and author information. > >> > >> ... > >> > >>> +// SPDX-License-Identifier: GPL-2.0-or-later > >> > >> Have you talked to your lawers? This is an inequivalent to what was written > >> below. > >> > > Yes. > > Yes to what? You now change the license... and commit msg does not > explain it and does not justifies it. What is even weirder that your > lawyers agreed on GPLv3! With GPLv3 you need to open a lot from your > products... Not mentioning that they agreed on future GPLv4 and GPLv5, > that's even weirder because GPLv4 might be saying you need to buy me > flowers... > If so, I choose to leave the license as is. Is "GPL-2.0-only" right? > Best regards, > Krzysztof >
On Thu, Mar 2, 2023 at 2:16 PM Kelvin Cheung <keguang.zhang@gmail.com> wrote: > On Thu, Mar 2, 2023 at 7:40 PM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: > > On 02/03/2023 12:09, Kelvin Cheung wrote: > > > On Wed, Feb 22, 2023 at 8:18 PM <andy.shevchenko@gmail.com> wrote: > > >> Wed, Feb 22, 2023 at 07:12:10PM +0800, Keguang Zhang kirjoitti: > > >>> This patch updates copyright and author information. > > >> > > >> ... > > >> > > >>> +// SPDX-License-Identifier: GPL-2.0-or-later > > >> > > >> Have you talked to your lawyers? This is an inequivalent to what was written > > >> below. > > >> > > > Yes. > > > > Yes to what? You now change the license... and commit msg does not > > explain it and does not justify it. What is even weirder that your > > lawyers agreed on GPLv3! With GPLv3 you need to open a lot from your > > products... Not mentioning that they agreed on future GPLv4 and GPLv5, > > that's even weirder because GPLv4 might be saying you need to buy me > > flowers... > > > If so, I choose to leave the license as is. > Is "GPL-2.0-only" right? We do not know. It depends on what your company lawyers told you.
diff --git a/drivers/gpio/gpio-loongson1.c b/drivers/gpio/gpio-loongson1.c index 5d90b3bc5a25..7ecbc43f8b38 100644 --- a/drivers/gpio/gpio-loongson1.c +++ b/drivers/gpio/gpio-loongson1.c @@ -1,11 +1,8 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * GPIO Driver for Loongson 1 SoC * - * Copyright (C) 2015-2016 Zhang, Keguang <keguang.zhang@gmail.com> - * - * This file is licensed under the terms of the GNU General Public - * License version 2. This program is licensed "as is" without any - * warranty of any kind, whether express or implied. + * Copyright (C) 2015-2023 Keguang Zhang <keguang.zhang@gmail.com> */ #include <linux/module.h> @@ -90,6 +87,6 @@ static struct platform_driver ls1x_gpio_driver = { module_platform_driver(ls1x_gpio_driver); -MODULE_AUTHOR("Kelvin Cheung <keguang.zhang@gmail.com>"); +MODULE_AUTHOR("Keguang Zhang <keguang.zhang@gmail.com>"); MODULE_DESCRIPTION("Loongson1 GPIO driver"); MODULE_LICENSE("GPL");
This patch updates copyright and author information. Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> --- drivers/gpio/gpio-loongson1.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)