From patchwork Tue Oct 17 03:30:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bough Chen X-Patchwork-Id: 734797 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0763CC41513 for ; Tue, 17 Oct 2023 03:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234036AbjJQDZ6 (ORCPT ); Mon, 16 Oct 2023 23:25:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233654AbjJQDZ5 (ORCPT ); Mon, 16 Oct 2023 23:25:57 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2041.outbound.protection.outlook.com [40.107.6.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62AB295 for ; Mon, 16 Oct 2023 20:25:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EF6eZzr1r8TexDkaYtTGY/ic2uMQ95w2HSP41uzYPsi2xzsfKoBRQqohgoyaunRyJ9N6YmaHZFanzjSIrf4+tNbQkbFWd+sjoklp2qi2u5RcY8LsPENt9zx27cjqj6MazCImF+oSxRa86v+dWi6dwvWFtvnKeT8isG8HsDBBMGUrR9UqwykLQFrF/ZE4fUyRbBz9XMJGGBMEuQX+HSK/vn+7oyhl71Qa1n1DpBZpUPyO2qiKT5oZSDdgalJ8GgtZHeKs+Mvuu0vsxTgJpq3v9lmgp0T73FzF3tDtoAXoMKfBFpiQyjnencqjuOCVuzEcn9hTm/5oFz7SzPfrTvl4VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0sUYjjwU9clOQkAMwE5jQS9r7uVlFn6xRBfkPQiuCXk=; b=moSSwscggHIGWXzzPRrXZ0ocsXRsn3kSDqSDNcDbVMbByWhhAHYtHUxizi007z26ndtnrdHwU00v03lPaRdDN4B++VX0r43xrwRSne54c6gRRYW6eaHf341x/e3B3tb8w0KxiAnoDGCSza5HHnifDdt0pHsWvizizVhK8Z83fLUxrLGveLsg6Rlr3Y/1yKeqTClBC4C1JZRbUF3RgLe9XM1YPMRqvBJGnQnH1P6C6kaFLBsixq0B6Fac4f5w8YxDGbU8gcWigL1nOfGkcnjNQxuDE8c8tAUJnteOqDZpoCwSav4ZfNreK1YWVDDZSHTxg7wLFWZD+fHq3NOkS+w6yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0sUYjjwU9clOQkAMwE5jQS9r7uVlFn6xRBfkPQiuCXk=; b=D0QWG5icvBrDUjfV5NBB8D1X59aY1N1+LeU+T48x47TLhYKC1c+4BzXVslyJCk4xVAAuZj8kpYk3qWWmcp2QMRNbF3sEgO98q92eV9j+vDKYlfn7wttle43RQNlfKU5NBT7n5cyPVFW8iOSbpTx65+ETQnXBQ9iTT8eGmHxQ92Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB7PR04MB4010.eurprd04.prod.outlook.com (2603:10a6:5:21::30) by AS8PR04MB8515.eurprd04.prod.outlook.com (2603:10a6:20b:342::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Tue, 17 Oct 2023 03:25:53 +0000 Received: from DB7PR04MB4010.eurprd04.prod.outlook.com ([fe80::e796:8366:5d4:4188]) by DB7PR04MB4010.eurprd04.prod.outlook.com ([fe80::e796:8366:5d4:4188%4]) with mapi id 15.20.6886.034; Tue, 17 Oct 2023 03:25:53 +0000 From: haibo.chen@nxp.com To: linus.walleij@linaro.org, brgl@bgdev.pl Cc: andy@kernel.org, haibo.chen@nxp.com, linux-gpio@vger.kernel.org, linux-imx@nxp.com Subject: [PATCH 2/2] gpio: vf610: config the data value before the direction setting to avoid glitch Date: Tue, 17 Oct 2023 11:30:39 +0800 Message-Id: <20231017033039.1245959-2-haibo.chen@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231017033039.1245959-1-haibo.chen@nxp.com> References: <20231017033039.1245959-1-haibo.chen@nxp.com> X-ClientProxiedBy: SI1PR02CA0008.apcprd02.prod.outlook.com (2603:1096:4:1f7::14) To DB7PR04MB4010.eurprd04.prod.outlook.com (2603:10a6:5:21::30) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB7PR04MB4010:EE_|AS8PR04MB8515:EE_ X-MS-Office365-Filtering-Correlation-Id: 587dfdd9-d5b9-418a-f879-08dbcec0c4c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QfkghxZZmxlKvYIjxT70ZhD3ZzAvbvhsKeP2AR2w0nP+6QO54xnCHZqCYrxkz7tdxkmm509d08yvfCvNuWV/prNHcq+IImjzeNsh708PEGyxlR8sw07GLwpqEPfxRPR3YSHH8wBsd8hY4hERkEZx1Ef+2I+njrL6HXtLetpZ8CiuWVbYFfOvZKpH1FMLQ2OObjxcrkFOeimk8EtjsIgXCMejjyif4abhD8IWqs55/OSkrRSuxWCTW0FkMEoTeymNtM+hypFd35m/G5/rLcOyUMavl5YXPvdrAJljAP5Wvo8S8d5yBtEqHXqCNDoDIcR59WJPkm/XKfyfHw+GqgY4T493c//+t5vvgMaX65YZuCzPkQSWNSPOuy56nZXbAGM7bNDx5m+R6KUNs8jLcVvr2tSKPMYrUtmAwos7XR9gMm0yvwUJPX4NOIjbveMHnv4aCVu4hDRB7y1s0BHMC82PHYzdsXpk6lA58IthBX+MU6wEugrr+LG8lDSXll8sD5Ph3OoMZoOLGTlFBECX+HNc0ljFUDSSbnc4n9L/ndlwHFnE+r4m9STh7OBegUzx86oY5DmzU+riIKcuZS6fcBYN8VQD719cZ8i7NDEO5D4XMip7E/V8UX7so/h69KxCk0RA X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR04MB4010.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(396003)(366004)(136003)(39860400002)(230922051799003)(451199024)(64100799003)(186009)(1800799009)(4744005)(2906002)(6666004)(9686003)(38350700005)(6512007)(8936002)(8676002)(5660300002)(4326008)(41300700001)(316002)(66556008)(66476007)(66946007)(6486002)(478600001)(38100700002)(6506007)(52116002)(83380400001)(86362001)(36756003)(1076003)(26005)(2616005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: cZiRgWgNgeHDk9Fy7gEkNI/+BSkXOR9KQFOIzGUbKZ0hhAR+uu8nHkorRufQBtP3S7hfhrC1US8IYfs2lVQcv0IokPuInsLHm7uYMUDjECRlRsm2oCa5dos/NrpvwH+e/z4d+HtJv1Kx/PWmPH0b429Tt+En7nBqdb9VrilFzwO4MnS9JrX+ybPXHaA8iaDTBTdpuaPFwE4+V1AsKcK0t0GEFokB1KpAvXMW7Zv9voLLvUm80u/aac2eGgy3daTSTT+GG0JPHz60v99Aj1LnjWNuob4Hp+4UEsYPJloCmPnuVr0gOxt8jmsHE/aMTupTGapU5vl4ZbiJMVV2iRW/1eYvNw/+0yWy8krNuWcpx2Bqkx4cqki6Gy4ynScmek62klwbOOKEMhuceSCngv3xX9HWfVS93SDvXy4qGdDN2krBsNzmYDOE/9Hq8aurNzwwVEJ7g0qGbims1q2HdPcv2vYDijrNKgg6wn2Z4neTR+zdgitOO7bhkDxWAuJJUYyG+pQo3yP29qaI8+ZTuIA61Cog4hqiCrGcwJ6fgj/1LH9ohHem2DUpWjm2oVLOUro6WaEBwJMHYuGInkCdHqjvCRRuWfMvd48wU8zwoj2SvWzMhgKDfR0PpJCxg6rIXlmlc5+61tKgDkoY847zS7w9jKnFrLagUQh1iqqocEqUYqupilVMr3rMBaIOz2Csnk7ndurZQSh+T+jU64BW/+WxAIszHBPYG/R8RMZc3N/LZ4wKskvYurDShk/AD3nTSZrbODc5Ky6IH9qqgBpY/7HlgmuPmVAvxmXj7yMK+RJ/sVzKw4l9XuN8LRwEtrbqdRkwHq5jNDfDYPh/KRvowBWvs26ZoQKEOzwjIKjOyTkQ3qVIEK/fOWzQM51lNO5/IP++64xOkBZUsM+3u0nsjk/1IFO3oHkbVKTeZjBUJXUwAMI8G+n3X6bgG+VZaX01zy2gLgX89LObDwBkXpLUDWpSOHX9KBb18VCK8YV/cZQobaX88eT3BzA6y19evv+vf5Y5MQPAqz70qT1DgK+NfUN5/o8e7S56Wa1HjYYY9FoajF7TLaiYbnoHAjRJuKYbsyDrHdVOJL9xfmXNBERa24K4CaMrrRBLggI+FCiPClymw8KogEzhLUEhImGExxzeUEIV2/gtlulS+1zQ49Jst2iASHWWPC0icVp7Lb2vANBZXZoIi9PRqWnsf4TinUo446Ysm+jC22QE7FY9SgGDMfWrKXXsp6X2FBXYz6s8huxQiwd3JMOeRKTPYBIfVtQ29VeLabI+FQeFkScCJJEDqffmm88CPRCUV8B9FFaaUZS39SDDYG2B4aYuz1zMLM7MTiM8dN0nHUcsCwVsIg4xzvsAZ/weWzf71nl4TY2OOutVMbLftpE4JjUWKXYJQaPXUTTFSw6f6Kwe2jaIzzos32NLVGW1gA0OLgwzccSEghOP6N7wlAZfQXlS+Y8GMWrrRiSBu78NLl3dcm8yv2gSsc4SFRLTHLJlrdDZ5/Kll7ovlGpSFn4nmcbN1Om/i/npY9gwnInNTqQXpGHRBltT8vVUxI5+Se+0aeDwKEVl43v1+4lqCBjDwitCbg+9wuW7BKIc X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 587dfdd9-d5b9-418a-f879-08dbcec0c4c3 X-MS-Exchange-CrossTenant-AuthSource: DB7PR04MB4010.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 03:25:53.6139 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RalCAMpHBxsOagrM6KcZdBDjb6ch3CkpEkXhIdxu42oXs9na8tnMMEXzDvHOsEnYP5mbb00Bdjdil+izN/heKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8515 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Haibo Chen We find a glitch when config the pad as output high. To avoid this glitch, move the data value setting before direction config in the function vf610_gpio_direction_output(). Signed-off-by: Haibo Chen --- drivers/gpio/gpio-vf610.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c index 77d5b8dd2bd5..444501c56a3b 100644 --- a/drivers/gpio/gpio-vf610.c +++ b/drivers/gpio/gpio-vf610.c @@ -140,14 +140,14 @@ static int vf610_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, unsigned long mask = BIT(gpio); u32 val; + vf610_gpio_set(chip, gpio, value); + if (port->sdata->have_paddr) { val = vf610_gpio_readl(port->gpio_base + GPIO_PDDR); val |= mask; vf610_gpio_writel(val, port->gpio_base + GPIO_PDDR); } - vf610_gpio_set(chip, gpio, value); - return pinctrl_gpio_direction_output(chip->base + gpio); }