| Message ID | 20240914052413.68177-6-towinchenmi@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Initial device trees for A7-A11 based Apple devices | expand |
On Sun, Sep 15, 2024 at 01:17:57AM +0800, Nick Chan wrote: > > > On 14/9/2024 13:17, Nick Chan wrote: > > The block found on the Apple A10 SoC is compatible with the > > existing driver so just add its per-SoC compatible. > > > > Signed-off-by: Nick Chan <towinchenmi@gmail.com> > > --- > > .../devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml > > index 76cb9726660e..e0d1a9813696 100644 > > --- a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml > > +++ b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml > > @@ -24,7 +24,9 @@ properties: > > - apple,t8112-cluster-cpufreq > > - const: apple,cluster-cpufreq > > - items: > > - - const: apple,t6000-cluster-cpufreq > > + - enum: > > + - apple,t8010-cluster-cpufreq > > + - apple,t6000-cluster-cpufreq > > - const: apple,t8103-cluster-cpufreq > > - const: apple,cluster-cpufreq > > > > Have to retract the cpufreq patches, a v3 without them will be available > tomorrow. cpufreq works on iPad 7 (A10). However it is already pretty > weird when the cpufreq did not work on Apple TV 4K (A10X), with adjusted > p-states. However, it seems that iPhone 7 (A10) is also not working. So > this is definitely broken. As far as the hardware interfaces go they should > be compatible, so the only explanation that makes sense is that the behavior > is not correct on t8010 and t8011 and it only *happened* to work on iPad 7, > with some incorrect behaviors. > > Marked as deferred on patchwork. When you send the v3, make sure you pick up the acks I already gave you. I didn't check all the patches on this version, but I think you forgot to add some. Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml index 76cb9726660e..e0d1a9813696 100644 --- a/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml +++ b/Documentation/devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml @@ -24,7 +24,9 @@ properties: - apple,t8112-cluster-cpufreq - const: apple,cluster-cpufreq - items: - - const: apple,t6000-cluster-cpufreq + - enum: + - apple,t8010-cluster-cpufreq + - apple,t6000-cluster-cpufreq - const: apple,t8103-cluster-cpufreq - const: apple,cluster-cpufreq
The block found on the Apple A10 SoC is compatible with the existing driver so just add its per-SoC compatible. Signed-off-by: Nick Chan <towinchenmi@gmail.com> --- .../devicetree/bindings/cpufreq/apple,cluster-cpufreq.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)