From patchwork Tue May 6 07:29:32 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 887932 Received: from MRWPR03CU001.outbound.protection.outlook.com (mail-francesouthazon11011004.outbound.protection.outlook.com [40.107.130.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8C8E23314B; Tue, 6 May 2025 07:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.130.4 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516675; cv=fail; b=BVQ1HfMnW4sUW++tdVPwHYL85AWfCkxxrtKeWP3N8rGDExjh+cTHjYqCzlGogRwApruWRBrW7bfrGk4y2Kn3riaGFBT5Y46s/kn0AODYfmGWGWsveCrjbkh9XYWsoiMzSHTdWKxSYaGLwHycNc36tLMlyPxH6jxJYK3HrTvvvrw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516675; c=relaxed/simple; bh=d9XsZOm5HN31TB3o+Cc3rtYz1J+CsGeVUq+zrNjEVpA=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=NOs0CH9102dji7KUEOL9GHp1bt+8lArfpZF3RXH22G/yqoA+S8pw6Mms2u/SkJ5Q6oJ1QD/ShZ2M/yihJCmBhdbRcWGR922AbhB1RgdvbOFNVsTbv3gVtZXvFpkw335xbVYa5naYZcE2Ib/DkA4KUXRaH6xcMZU7MIfU1laHp7w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=bVDuF+NW; arc=fail smtp.client-ip=40.107.130.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="bVDuF+NW" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DZfpO0oRET95dni19w26p1gaKaBOVYYxL9PSKEK63PjfffRRJ/JEY9jCg0M08RjVRDf6SH3CKWrexxAoUpJMzuiBlxn6cIBlksf5XX+JZPSd8Mo8ltXulVq8eSD9C3UIWPI/j15v2vTa32SOFv+YpvpNTTHYIWdvDn8V/LZWkUAUotb2wgyjq0/1/4s9tdZ2xca6MxaaJJDKvf1EjLGRF7/t7wL0IzJQB5Vche4ij7efjzqibkoOKvSBsUuW74tQoEr7nuBpI5EzeXXkAZDpBZW1p14jDHwZ2oSKYaNuCla12a8G1yZwTFmJM8I3Ac+HA84HeGuv0es/KxHe+HU3Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tCcNcUQb6VDoFfspJ29cZ90knzyy35SVsuFGx5dhAjg=; b=NpFPKGQpspPYqD2PDE73d55ZotjbYUfuDI1ORY8OwBZabZkL4mKrOXrRBJdPDqCuvBFDF2aFiTMeJtMLLaz4ZOaKezTARabVTSrGAOg8CwWptMuYLcQq6s55E+JWZjydyOHLcRYWcy7HOUtzT+k88YfiyjA4JflIleTVekgSv/Re72a83DSWwc4eNJyyYH2TxHQU81H45Qp5PJVlnWl7DvvxC37vKnwfzbkYUlLb5R5tZY7Sq989CNmJlq/8C28V+9J50tlpBxKAyju5hulIspKFEK8OAju3lJm4Wc5C2zH+aKIVpZsVY7yfZgk0nqEYcHrNvlURMS2g2H6/ySPbzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tCcNcUQb6VDoFfspJ29cZ90knzyy35SVsuFGx5dhAjg=; b=bVDuF+NW4tPcJYaZKhvFHTgB/RxmqkGrOyQ+owjUGH9sfwoN1wO34FRDRmFoIPwmD9TAJv8nGUPsj+NPtLa1Fqd158Pm9QLSozj0+dHQizQTpc8jXcBWW5H7TZkKU1CXtI3fAD+sc0ofYMKaRsb+INDqdJPN1c18h9j1bWR5nnec3xqzvZlfcUfuBQZ4uJkykcnLsF8LhwX2GCCUg8xTfGPmPwjJ20kJS9iE2aZlZ03Ht8TzD2Ysz1zYZRdD4rD4/cPXt3BObSNvfFjGJmOLYxe7sWfVeb3o8R9YlA5sthTEkpk79v92VSOSSdNlAWBHzDTLBk8orCfdMTzscc7b3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7196.eurprd04.prod.outlook.com (2603:10a6:10:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Tue, 6 May 2025 07:31:09 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8699.026; Tue, 6 May 2025 07:31:09 +0000 From: "Peng Fan (OSS)" Date: Tue, 06 May 2025 15:29:32 +0800 Subject: [PATCH v3 2/9] ASoC: codec: cs42l56: Drop cs42l56.h Message-Id: <20250506-csl42x-v3-2-e9496db544c4@nxp.com> References: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> In-Reply-To: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746516585; l=4414; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=eQ7UdEZ4xHJklXPmR4di3YvcmBTWJXIeJvZOIGA8q0U=; b=cukX6B4dylPXdPLfg6q2rW19aJzWL08TFsI8T3UuSD2nhqYPPNwmRa3llNdrQemmPVg0YBsQ4 nKbjmkIDqzkC0kl/oi+mAfprDTx9kZHevcMSweLJP756nSvnKZPPqEA X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR01CA0176.apcprd01.prod.exchangelabs.com (2603:1096:4:28::32) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 952f785b-63df-4feb-ef67-08dd8c6ff880 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?b6ieUD3nZiLracSFvo+DWIeYQd/f3jV?= =?utf-8?q?YbhoCjmCMVD/qsJoekd0QVMRqEQ9QQ9ooMkDQLmBB49QZ9sdYI3cTA5Ass3Z/6vxS?= =?utf-8?q?sEu8wK0EkPTEUzaXhFEkDdoi+NvaBhCvljMpKwYACctsjxKPse+57e+HEga4DVj02?= =?utf-8?q?3JJDXWAXVdtDWXfMr3PNL2h+LUKGxJ21LwBPL3g2uXiQOEVeuZfwgdratyd0UQRd2?= =?utf-8?q?bYu9DfUpd+q3aGJTrf8VYMEL0r94d+jMgv/5lJFlOfiUVEKeDqd0Kqyns/QTMDGh4?= =?utf-8?q?T90fIjVDu4njtBY7Ikv8G6M1kmxfYpyeL7xDEGiKSRxIMoKIhpy0vRZPJmy44Zi6S?= =?utf-8?q?fGFBZJqcs92iwvUV+4WBra+wVwigGiz5w3VZu9DoGm3yIol0QVNPQSES0CyICCRxP?= =?utf-8?q?g+q++EZJrlCMovyEFb0pGZYMIhHqzMf72pISblbLy8fSxWfCo2XOVHViWE2U2baMU?= =?utf-8?q?AYvZuHng9lynYIDdpDKCytPlR8sLQCJYkikRk/lAODEmJp/88zSIb8pLQkjNwQNLg?= =?utf-8?q?Kf4m4LJ6FntUSUZDSfeqfaui6sYMGkcRpOrTxnYWM9IHHshWdR7xGxGXIjzzzM/CG?= =?utf-8?q?s3wKpzvZFUiDggximrJYTmL+KdRHriQwk5WvLzEGTmEBmWSJkqhVErvL+PCydDfBA?= =?utf-8?q?/3JOi3qHzU+tpsYlUXi4entxAtPI5vsDmSkYnQuWHm7zsoVpzNOLaCPjMEnFyNpFh?= =?utf-8?q?hlEWLkjiLtFWh35xyTkf95CvW2AQs4jjde2+xkhdKH3wkK6bXpYHkz9C9jLC/0u6/?= =?utf-8?q?0u70igCVVRjFAGwq1NwquU9S/OrV1qhYYjhUp1r8Ozhn+kSJZpgGTFkjCtewHqY2u?= =?utf-8?q?a/Ai3H0DaMKy9/z1HnhjJ+H6Bg919txCaDQ7GX7ugFyQqTAfgcvguMpyiSo+pBezf?= =?utf-8?q?VFKWvalFwot+zPdist7HfnLMtSiUuEwO97Qg+9BS4Jp7MAHWRcgDDWLpbfpygwK+U?= =?utf-8?q?mCrGeE6DRbseylqQm28hpRZQaohR+Jqt+lwft2NOdU6cRWQUoaUeYVE3SkSsiq90c?= =?utf-8?q?A7ek/I3PQT364tqrXC6e2IeeRiTwUibfhT3YHKwWRL8/YJ5hxeXa6hBjtlE2+YKn9?= =?utf-8?q?CDT2t/K2pxVPw9H6WqZoPmhpOjL4k1mHr8kHlfqMQbu/CQmyFjIhNcdFehc6g0YEx?= =?utf-8?q?2FWphC8N6FKAeNJTcZe/wf9A/Sdj+FWii5VaaaSOGQFR1iqVyqtJ8y/lUQ4lSET8s?= =?utf-8?q?54rvM1U+jXMZjNh1hL2GoJABKD1hZ1sR8g5wTjv2Hb7U5Y7T5HxnYxHohIZRJEWfI?= =?utf-8?q?FKQ4yVltmXazqPpyvCk/WLrBsnwBrMzZ81E3XMzu1QStMMgtBDCCiKEP/UM3eFUM1?= =?utf-8?q?fImQlmymt34+NGGkfyGm7yjXIJvab4rXaKDNk5HteOJ+gtq/nix9p/Fea0Dklvab4?= =?utf-8?q?DYT6EGGCwu2Wq0L0iZNS2tjkwXUVqZdsg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?B1jE/Y+cfFgT6D5ZtQCXyocVSatW?= =?utf-8?q?wTVn3D22S1XFYJCqT7ZUVMFlsIr2ivVZDDUr5ONBCnqv4jt6UnLD8kkQio+5oNI/l?= =?utf-8?q?tyeQeJDhNec18KOEe3gf0xA91zJjFLQ5UWQ0JEeE/qPXg/2073xWXs3isCkSbN4rt?= =?utf-8?q?0jAkvBUdk5SJzViJKQY5iDp/dJQNvnPFAS2tH4JMKoEbyTjGwKPYKHtLi2/d+n46f?= =?utf-8?q?XvEUbRYMYvG0+fxvpXtFveaFbCUsoBA0gmhhWcMh9I60IJ1CW8oaxA2wa1ZUSVVjT?= =?utf-8?q?MxDcFL+rx/aNlljxi/wuaOPczkDX9WHCqXJiTAzuKVGlhKSDw56c7doZx+0FxzVJh?= =?utf-8?q?uY5s9/+OI91WfwDulGZlz+9HfEbcIYsufnCELQMRA1OXIKOjArtfMlTtHJ55BTB9H?= =?utf-8?q?PkgKDcLcA+yYFXWBsp+KfjZ6eKpkwh2191cj627/UMYFSw+w15xndKzXFKZJVir5p?= =?utf-8?q?lUWhVruI6XHvZevr0IDoY8zjyQUGtXGVGKRWU3o3nEJlyr13bVy1yhW0paHWi+03p?= =?utf-8?q?y/3dR38Oz3/ZStEUQRTbWuR8jv5XbQwAKbbXRZ4Rspyq/ng734Id5bqJ62UDrxXqP?= =?utf-8?q?Svj+YfNxXT2DK/dM/kULVz2b6bZ8DTjpnm9/6xg2OtsDUhCDo2SAcQGluYxkPrDsR?= =?utf-8?q?2Y/bLJXjAdO5lMaU4/QnPTjggychzkymZ9xw/FN0VXJsHku0Rlg8dy23WZKepXaRh?= =?utf-8?q?edHRmuaejqEOkkTb8ot4AdaCRHBtrpLobdWUxGBq+h+Yq1M/GHvmXH3kDteC1JX8x?= =?utf-8?q?/7Wo1JOokJWSTLn0nw4YdekQb/Q76uFCXaGKtU7NXVbq5HDV15kViNpA5jVAe7UX8?= =?utf-8?q?FhgrKnRp9UhSA6EI9d8HsQcy/5qY/4Wjqad0j756Mj6RTa8m/O/e1vWI4/UO2Xm4r?= =?utf-8?q?77dJcPF9DaBnv1j4mms/vbQTftnkrQBbxX38AxzOLAb2xN8kr/0Xql8WE80vr5WKv?= =?utf-8?q?Kkzi+BbNCuINnGRaNK/X579mqK0+l0SVPhM+Q5ESMfJ/1nwo4wYbrHtnDNdFkE8T+?= =?utf-8?q?8lF6l9qd3ow5WJQ1chojxjY48Fkoz2RyjarkQmdPgQZmlT42tV7FxnQ4r30/fTAiG?= =?utf-8?q?QNTTHSS65uZQRh9RoIntBctzck8Ma2Z3Th9idwpmS7P46DlRJK8SS1nAmt5GPZT7B?= =?utf-8?q?h3P6GcU/mDjTlvT+yWxQc1qeEOO9Jby1/3utxNvMXgiLIfDyAA0ghGhGKm8Exi7NX?= =?utf-8?q?Dv+4KJWfB9mZjjAifzkh09MkiCIwLv+EGB/NqOWQP4IepWT3snCfZWS+x7T2Igx0Y?= =?utf-8?q?2Mn4aFzsC0cwLFbOTUSftFaoh78E8QWMxpGXHbTnOo/QEYHdleFPlXn2NZ+hmvznA?= =?utf-8?q?VyDo/KwjmARS0ny7mOhfaZ0PsxZHJPCTYTFwL0tTKAfkTcZoenVv27n2H6dbcBwyi?= =?utf-8?q?bwU5FEBMmKdp+FTcFccYJirxBAs0i6vCIVM9Y8CgJhQi+OV1jgpKY7JmmfcWnhcu6?= =?utf-8?q?uFym2EbSqhEPFGZrj/nZfJqQjMn1WdPRpsDLQHzsrgmSeDV2dhepIKE4xgMC1syA7?= =?utf-8?q?UimQZywEE52A?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 952f785b-63df-4feb-ef67-08dd8c6ff880 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2025 07:31:09.6669 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QIsOLeGxueiZADrOXGnBJBDgHiEhloVDZGRKZhGYmlkGQZlUwtYPJPf/NbIILYtkT0HlJwRBLIcfH5G33QYcDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7196 From: Peng Fan There is no in-tree user of "include/sound/cs42l56.h", so move 'struct cs42l56_platform_data' to cs42l56.c and remove the header file. And platform data is mostly for platforms that create devices non using device tree. CS42L56 is a discontinued product, there is less possibility that new users will use legacy method to create devices. So drop cs42l56.h to prepare using GPIOD API. Signed-off-by: Peng Fan --- include/sound/cs42l56.h | 45 ------------------------------------------ sound/soc/codecs/cs42l56.c | 49 ++++++++++++++++++++++++++++++++++------------ 2 files changed, 37 insertions(+), 57 deletions(-) diff --git a/include/sound/cs42l56.h b/include/sound/cs42l56.h deleted file mode 100644 index 62e9f7a3b414f6d1bcb651b22f7f8bd1f29b0eb3..0000000000000000000000000000000000000000 --- a/include/sound/cs42l56.h +++ /dev/null @@ -1,45 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ -/* - * linux/sound/cs42l56.h -- Platform data for CS42L56 - * - * Copyright (c) 2014 Cirrus Logic Inc. - */ - -#ifndef __CS42L56_H -#define __CS42L56_H - -struct cs42l56_platform_data { - - /* GPIO for Reset */ - unsigned int gpio_nreset; - - /* MICBIAS Level. Check datasheet Pg48 */ - unsigned int micbias_lvl; - - /* Analog Input 1A Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain1a_ref_cfg; - - /* Analog Input 2A Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain2a_ref_cfg; - - /* Analog Input 1B Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain1b_ref_cfg; - - /* Analog Input 2B Reference 0=Single 1=Pseudo-Differential */ - unsigned int ain2b_ref_cfg; - - /* Charge Pump Freq. Check datasheet Pg62 */ - unsigned int chgfreq; - - /* HighPass Filter Right Channel Corner Frequency */ - unsigned int hpfb_freq; - - /* HighPass Filter Left Channel Corner Frequency */ - unsigned int hpfa_freq; - - /* Adaptive Power Control for LO/HP */ - unsigned int adaptive_pwr; - -}; - -#endif /* __CS42L56_H */ diff --git a/sound/soc/codecs/cs42l56.c b/sound/soc/codecs/cs42l56.c index 0201206518cd9ea8ecfb823a96fb59cae37c36f4..9c58d4f08692871c5baf2702c73367287735cf24 100644 --- a/sound/soc/codecs/cs42l56.c +++ b/sound/soc/codecs/cs42l56.c @@ -23,7 +23,6 @@ #include #include #include -#include #include #include #include @@ -33,6 +32,39 @@ #include "cs42l56.h" #define CS42L56_NUM_SUPPLIES 3 + +struct cs42l56_platform_data { + /* GPIO for Reset */ + unsigned int gpio_nreset; + + /* MICBIAS Level. Check datasheet Pg48 */ + unsigned int micbias_lvl; + + /* Analog Input 1A Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain1a_ref_cfg; + + /* Analog Input 2A Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain2a_ref_cfg; + + /* Analog Input 1B Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain1b_ref_cfg; + + /* Analog Input 2B Reference 0=Single 1=Pseudo-Differential */ + unsigned int ain2b_ref_cfg; + + /* Charge Pump Freq. Check datasheet Pg62 */ + unsigned int chgfreq; + + /* HighPass Filter Right Channel Corner Frequency */ + unsigned int hpfb_freq; + + /* HighPass Filter Left Channel Corner Frequency */ + unsigned int hpfa_freq; + + /* Adaptive Power Control for LO/HP */ + unsigned int adaptive_pwr; +}; + static const char *const cs42l56_supply_names[CS42L56_NUM_SUPPLIES] = { "VA", "VCP", @@ -1169,8 +1201,6 @@ static int cs42l56_handle_of_data(struct i2c_client *i2c_client, static int cs42l56_i2c_probe(struct i2c_client *i2c_client) { struct cs42l56_private *cs42l56; - struct cs42l56_platform_data *pdata = - dev_get_platdata(&i2c_client->dev); int ret, i; unsigned int devid; unsigned int alpha_rev, metal_rev; @@ -1188,15 +1218,10 @@ static int cs42l56_i2c_probe(struct i2c_client *i2c_client) return ret; } - if (pdata) { - cs42l56->pdata = *pdata; - } else { - if (i2c_client->dev.of_node) { - ret = cs42l56_handle_of_data(i2c_client, - &cs42l56->pdata); - if (ret != 0) - return ret; - } + if (i2c_client->dev.of_node) { + ret = cs42l56_handle_of_data(i2c_client, &cs42l56->pdata); + if (ret != 0) + return ret; } if (cs42l56->pdata.gpio_nreset) {