From patchwork Tue May 6 07:29:36 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 887930 Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazon11011059.outbound.protection.outlook.com [52.101.65.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3D9D23C390; Tue, 6 May 2025 07:31:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.65.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516690; cv=fail; b=RAV+s91bpF+FswcPo4k9AI6oCup1vUXbOkrv1sn/YpiyFJncE3lAjDk1SsZjx+3igj3KXjXRJ8MZKuUoFGVwbcperOZimW/FpJF+iXhERO1iZrYNuKYKkzjI/sS6xEH77xB37UUc9b9TckT0DarNYCL0IlQVNb+XYrr5W1hU1aI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746516690; c=relaxed/simple; bh=loGsb8BxVV8cN59KlSXd4XjQDzgQcKtScg539R8bxEM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=LuHWV2Lh2uW85/SV+YuzXw/jFUKUgOtXI0Hsu3zfwbY5u5jfqVoZz2pJ9mPDTqJa1kXem1pybN5A/06X5o+tuJnfml/6kK3XEe30g/DM7BhQbvi1ZFqnvGSMkpN95liYFUHaEtnMOap5eYopn/VZv0y/3BwXPK4adS+re5IxrcY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=Kd/jIUZt; arc=fail smtp.client-ip=52.101.65.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="Kd/jIUZt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=X1N2FPBuYeHamzwWu+qqu4ZP0Nr5DrJ2qVeN9S0Q6BTBkFTSRXnH9o0WUlLQPtenND6ZG5fLb9Wbg3hLi4GjEir2DtITHxOLSu9DaH6wy06TCh9iI7mgBV8gYmgcWHDblvvivpm0qi3axSeUzx0WSoa2/4JjREUlcPw+NOM/s6jIBlffglrJyfo0TYz4vTWi/R1M3CdP4xN1NvPf7cX+ZrofLxIyoz2Z2KnaMcdeYNMl90qJm3ecEhvWof66krz4+DQZ5Yw/N8jiimeCcIeMpYhDNCN2dAApKQywNa7A2t+H1peZ9byxFiXf/p8DxdHLlZTc4h3X2dj56mOgG07Ozw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I6VsyhUjYzbIhuCFZYke3WjMogqPQM7yhWcLNVJYzbQ=; b=jFFpzGwwBeRAjFNguB8V200ssQSUleodR5BPjozrvAOMIRcyyZcBYrXsiUgeQRhbARck52C+0Gifk0drL46zErqlFoLRtm2seeq8FNNnXT/Aq2XiyFqrx94/6xiGyxFP5gzs7ZNOUQBCGbMfiVZr2h7+k0AI8LtUv033t57Ig41wCI3VKG29+uBVh9Mdmm2kwGMer1W43vU6XFd7fM/a8MXHiREKEG3VyEf3/6zDJQf4kpczCswwGyZk0KzUldyjj4bMDnxSLLZhpQ/2e8TXND9e3CXLlQsZkkip+4+7DiakctDCmrgZ1nhjc68r9XeEChyIrerpKAFOavyY47jZiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I6VsyhUjYzbIhuCFZYke3WjMogqPQM7yhWcLNVJYzbQ=; b=Kd/jIUZt0ghKR+1AAL3lFXGpgzRwsFSi9J4OONQnH4bJGpVvwOpLknbBaR3q+b0ngE3BNIqgvLMELDYqb70H/oyPp8twHMIcFAh8tpYUrvuBX4133y0jdiqxCB+7EZMYJfLTOvTeg8LLQKR6I4Z4QUaCZreJufozuO/uvVIBmSDoRsV9XYWvZQpWxa22o1QmnPKR0SAzsAyCWOQDt86lDPuZvPb1JZZSQc5QBfXmHibpDPMQjP769+Ksm7t3jqyNnm3tAnPLM6k0UzEAiTtt+Tq7pARDumfiAaeX462QK0n/9j/r05chXJpiZnzhAEY4dEM9RJxIAssBU+XPpFuaFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DB8PR04MB7196.eurprd04.prod.outlook.com (2603:10a6:10:123::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8632.32; Tue, 6 May 2025 07:31:26 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%5]) with mapi id 15.20.8699.026; Tue, 6 May 2025 07:31:26 +0000 From: "Peng Fan (OSS)" Date: Tue, 06 May 2025 15:29:36 +0800 Subject: [PATCH v3 6/9] ASoC: codec: cs42l73: Convert to GPIO descriptors Message-Id: <20250506-csl42x-v3-6-e9496db544c4@nxp.com> References: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> In-Reply-To: <20250506-csl42x-v3-0-e9496db544c4@nxp.com> To: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski , Charles Keepax Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1746516585; l=3281; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=EJwDsMlb68b2TeHr3o9byLSOgFkhPb3M5yScw8I2Ms4=; b=B5PwnJETGNUr6rUlwhjL86Oddm8Jhy8HPlS/c+LOQE+AZx6AzSxU2ywKUt7NOEKQQKY3KdoyD AA8a9+dzkT4CuOtpB/uSkYZTmum8Q433qtCWGOjM0NNg183vhBLnUSn X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SG2PR01CA0176.apcprd01.prod.exchangelabs.com (2603:1096:4:28::32) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DB8PR04MB7196:EE_ X-MS-Office365-Filtering-Correlation-Id: 61fac5d0-f142-4cea-177a-08dd8c700254 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|52116014|7416014|376014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?6R0PUAZxNO59szhKyFwbWK3PT8fPSVB?= =?utf-8?q?jECwKLkw3a3KcS8aPGf0TZlR4nhhBXgBYND+ucHDQ/i0YYiCkvhdJX8VW/v92UbvW?= =?utf-8?q?nnv5lByOyyb9JmPWwUH+dMkfuwUKiJQTFUPm8kuDQDwziSQ/Jg/cWuIzW8bkZoTgm?= =?utf-8?q?lY+szZer79InOEllVDgyfjpED2AGwkleZaGqZJ0n842EdwupJbRifgCDyX8I/PAuK?= =?utf-8?q?bPafN2kJzKZseOoBh/QTtTLO6qmv0/Ox1IppK7MIK9dsDDh2kmvQeh72z06HvTKJ9?= =?utf-8?q?TABUcGETDRUvoCQHEQT+rlr2BXT6QI2i0Aqv5hfmEjTgBjeozNLL8GUNAngclpsKN?= =?utf-8?q?u2SndGLboJniB6BIwxRAH44ZVQPJPI2sNS81M36AiqWnreexywobaOHOrnVRwrgo8?= =?utf-8?q?iDdkVSAuwsoVlRVLhKyb+NxkL4AprU6lSDBVJivTXOQ+f/1iFMeY2BJPIov6eRuMA?= =?utf-8?q?D0r4wZslvIhlM8A/mUNnFrnbAloLolQOwVKNEz7dbyuVYg/OBhe7525IshPdPB+3W?= =?utf-8?q?H0kkJDuI6Ec0IRaweYrxTKYvIk2Da9zwojeGSAlO7itTwHtssumomXxyWgrq4Fo7h?= =?utf-8?q?o8pAMZGQpqAk7+HHcEzr8MDloMEn82hwTJ4F44nOWZT3sCXQ0Pg7qAph6wf3o6be4?= =?utf-8?q?McxIrdO7VKf+bPx/A5vqNIKWbGu7n7YL72lLK8jiHZbJOlmEb/bcNmoB7YM9Qh6C5?= =?utf-8?q?86ZezKvlrx0GNWyOIWv68QlNKkMPvG0ZeFYti4jqcytqN8XVC/5cUbHsXqO6XshbJ?= =?utf-8?q?I1tizG2sLt425sPwnZhXA6o2W8VGl7eje2BugGJxptqZVtSxnl+Pu0adodSXF1Vyl?= =?utf-8?q?P37H+XB5E5JNztKgU/B+BMyz62sAc8vQqLzBPIV+ZEOvvXloODQBDvB4wHq7QHxED?= =?utf-8?q?fRF0XCh/iV9DTYvvlpTujE4M6oQUS9+hCljDL8NXLtF1wHISL/b/ZwNHQYoulEbed?= =?utf-8?q?Cfn8CGcxwZ0+XMDVkBV2dg4QoagZdDkyY9DWI8gabJs3DaqgwRmBask1ztb9QL/NT?= =?utf-8?q?wIVVhKLFOzN4Jl2f1tQpMnf4KgjUou4vUd7T/riSvyzESjuhJ6TJi2be/TXQXVB5p?= =?utf-8?q?WEiTtmoCxf+wZsIPG2dmBOCnEz9iwy0RzmNCkr8cNv6oYL14swx3vyuHIRV9cnVkr?= =?utf-8?q?y1ZoEwZXE3U2W+33/AOaygwozYeXNffMt+9Swiqjcu1CVOONQCemf54JnAPfQZGUK?= =?utf-8?q?nv1uAI5IOgd/vsfu9nZqmyi8pEyTgiZ/wjkiznp9AUp3jYgwyHDZBkVRjrxIkZawg?= =?utf-8?q?vIHwBFPwLAmhdxsDm0QuQGdfNM21cfGpvgyGzyFnYMM60uENC6BfbpqcdtWgHqKL7?= =?utf-8?q?EqMnZ/o35x82kVDbxQ2KgEnmvVBBASJEeCZbmiI9pyVPD9RYUjMDoW8l6fC7IP8Lr?= =?utf-8?q?GB04ckBdDeQhPIJUNTgeE+7etgOZsNlLQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(52116014)(7416014)(376014)(366016)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?LAaTUy69aHQuqRNJm+UfRKxnCkPL?= =?utf-8?q?nHJCmjDpR4zH1vPOICrtTwKWKNqJSI4E4U14MPd+rWJYADYVMNlYEmjSuLP+PlnSz?= =?utf-8?q?jVUMyGD9fo1gt422izmplPOrxWY5W7oLeoFgQtuEkn9b6ymdwCPQbYW+I3UYaKdhU?= =?utf-8?q?+h4ijVOspVdb4gbEojhi7B06cVpHAkp7KNdb2KOYR6LG7z+mVV3z7W/4A7WFlPDAI?= =?utf-8?q?uuD51kIeHbbdJQVeZw6FDiDXIu0jfbF5KDMfsfqnp4U4Xz1kXpDnWt64Ae0SJcI0v?= =?utf-8?q?F0h0eSE48dqmwgKi4ejEJ5suorzAaOG6zzXKmrUyC4UQzqmCJY75vU+yAJSbGgJwM?= =?utf-8?q?Dap8i4L/7m/vPfItbN4t9bzsI9boAR+bHcMnKhEoDty6pXeSmf7AcSf7txcQv1x8Q?= =?utf-8?q?VefDqHA28GyIqPGyQHq0Wua3k63UW3i69i31UeP50Fprgt/bAkm7ykNOAzLoy6we1?= =?utf-8?q?zHpOQ5V9WXtOhtScO9Cs+KD7qqhNec12xWZM6yyxRaBIrDrM3NXxZqtIr4Beij1SO?= =?utf-8?q?asS3EZ4Z9x/XI2GTEbD/PpsYi2rEbmNdl8ThefXWbfwZM52UhhLOrTO1OMCuK89le?= =?utf-8?q?bBuPTDvFNZiGuOg2XQgldtEUq2ECeOw2HMKY18ehjLZ17ICiS/3dlQ/du+iTGygE2?= =?utf-8?q?+qC8pUWT7rgrssLSBaNV8vXlLTwdFcy5SR7NF6ygJ766Pgl0o38zNXm6pcEKkMY+I?= =?utf-8?q?1gj0npFCnspS24ogMkx5snI7vI9NpJnjnpGroC8FISd0s1KZmbGm9uTHbd8nTvrVc?= =?utf-8?q?ziwgO9BcOc85cIuKUWpRSFiNTTcL3PVgGOhfkgRjm4FwGCK0il2x12m+Q2+4z8bs0?= =?utf-8?q?CCBFHIY+0O18mETJ7gRJxNtrTrzHEIAGxv0z2JmGiF7Fr3qAOs9vUzfI/xoKlFLOw?= =?utf-8?q?EMh5/wfrtY7x1vYIgJgG31OApyc2d7j7xpBTtB5qHlsUiwxB4dC+go2HrSTZHtksx?= =?utf-8?q?hgbEl/WNYVRmcCQ3ouo6rNzyCvTc0jkPigrh2+R+TE3yNE3WNtMih00Wkz0pOhom/?= =?utf-8?q?6D8BXxDYDnbsgoLpoZwvIsuG3GgZ90xznMGu4xaQO5PYrDIY8VLX/VA0CSSTgBOcn?= =?utf-8?q?BFwTQ06p4jCVvyozu2KbjmSSlkJSNy3wualuI07mbdEmRnLlVUZkRMZT1iZ3HIE0W?= =?utf-8?q?XYNQWiOVK6h2ZgnwjmWAL7d06ULSYYt77Fa4STTI8NYY1g+NLJU8IWfKFZf6BuEd9?= =?utf-8?q?wsREJaWzZI4t5z0utnz2L+BDJtOsPg+YqQXOt+dmCOHiy6aAoLhAMDP2KGsr+o4Qb?= =?utf-8?q?26WSENLVLt9+oJhP9OBi1xqqa823XJGZde+hhIixkO89aTB/rYmkNHqjJLFSXB9fl?= =?utf-8?q?Rtitk5SJmW9p3j5Fi9ettwH+pNEeyBv6RSK7NqAYArX1Z9bmQCXTx6pVIzpvi6G11?= =?utf-8?q?wZJn3cEX8tz+CYgh5FEccdTKSMdlHDJt1Clq9Xd+HrZpqV0uJFTIk02BB61eyb/gt?= =?utf-8?q?chn2t0qi8QqYRQBaDgxlezM4tHwOgOjYsOlCfDoO8YM3N5r1oKDk5Ho4n/8VmOKd0?= =?utf-8?q?4CL8HJphenlE?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61fac5d0-f142-4cea-177a-08dd8c700254 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2025 07:31:26.1390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SMVZ1sGK6vayxarxDPSlyyEg2nrIrfeXfrCsWBRuR/Pz75fDkNv7gCj/CJkd+K7Kcf6rf+sDexmoCl5h0QvB/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7196 From: Peng Fan of_gpio.h is deprecated, update the driver to use GPIO descriptors. - Use devm_gpiod_get_optional to get GPIO descriptor with default polarity GPIOD_OUT_LOW, set consumer name. - Use gpiod_set_value_cansleep to configure output value. Checking the current driver using legacy GPIO API, the reset value is first output HIGH, then LOW, then HIGH. Checking the datasheet, Hold RESET LOW (active) until all the power supply rails have risen to greater than or equal to the minimum recommended operating voltages. Since the driver has been here for quite long time and no complain on the reset flow, still follow original flow when using GPIOD descriptors. Per datasheet, the DTS polarity should be GPIOD_ACTIVE_LOW. The binding example use value 0(GPIOD_ACTIVE_HIGH) which seems wrong. There is no in-tree DTS has the device, so all should be fine. Signed-off-by: Peng Fan --- sound/soc/codecs/cs42l73.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/sound/soc/codecs/cs42l73.c b/sound/soc/codecs/cs42l73.c index c09c23487d2e73340b8947ed0e1ffadb24414e7c..535a867f9f2a6d32986190c4302dfeb1e9f06913 100644 --- a/sound/soc/codecs/cs42l73.c +++ b/sound/soc/codecs/cs42l73.c @@ -9,12 +9,12 @@ */ #include +#include #include #include #include #include #include -#include #include #include #include @@ -30,7 +30,7 @@ struct cs42l73_platform_data { /* RST GPIO */ - unsigned int reset_gpio; + struct gpio_desc *reset_gpio; unsigned int chgfreq; int jack_detection; unsigned int mclk_freq; @@ -1307,23 +1307,19 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client) if (of_property_read_u32(i2c_client->dev.of_node, "chgfreq", &val32) >= 0) pdata->chgfreq = val32; } - pdata->reset_gpio = of_get_named_gpio(i2c_client->dev.of_node, "reset-gpio", 0); + pdata->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, "reset", GPIOD_OUT_LOW); + + if (IS_ERR(pdata->reset_gpio)) + return PTR_ERR(pdata->reset_gpio); + + gpiod_set_consumer_name(pdata->reset_gpio, "CS42L73 /RST"); cs42l73->pdata = *pdata; i2c_set_clientdata(i2c_client, cs42l73); if (cs42l73->pdata.reset_gpio) { - ret = devm_gpio_request_one(&i2c_client->dev, - cs42l73->pdata.reset_gpio, - GPIOF_OUT_INIT_HIGH, - "CS42L73 /RST"); - if (ret < 0) { - dev_err(&i2c_client->dev, "Failed to request /RST %d: %d\n", - cs42l73->pdata.reset_gpio, ret); - return ret; - } - gpio_set_value_cansleep(cs42l73->pdata.reset_gpio, 0); - gpio_set_value_cansleep(cs42l73->pdata.reset_gpio, 1); + gpiod_set_value_cansleep(cs42l73->pdata.reset_gpio, 1); + gpiod_set_value_cansleep(cs42l73->pdata.reset_gpio, 0); } /* initialize codec */ @@ -1360,7 +1356,7 @@ static int cs42l73_i2c_probe(struct i2c_client *i2c_client) return 0; err_reset: - gpio_set_value_cansleep(cs42l73->pdata.reset_gpio, 0); + gpiod_set_value_cansleep(cs42l73->pdata.reset_gpio, 1); return ret; }