From patchwork Tue May 6 09:01:46 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 887927 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFF5E265CAF for ; Tue, 6 May 2025 09:01:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522119; cv=none; b=k42MEzUQA1hjtUkcYV/Yq4ygG4dLKtLcVQJyasbBPqSed5zAoQDc1/k0OC0OFugnY9nvwV1OF+DmCd5bmfvQW9i3VHwXNqaNT4G52vKYZra2JXhSJcpyUeP+qjiprjCeau5mqpaxZrvhTPz6/W7LsDRUS1l7792BwEAkn0YsqvM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746522119; c=relaxed/simple; bh=h/WDiVXfFCZHqvgjoPb6omhRMFBcxZL1KWQ7TBjLi3U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iN1yVLq/jb7VjhvdRCuqi3WAZCFkCH0zQC8iGlkMyfcTQt9TZ8dKeC/QQgXuR9Ywnecn3iOVeXOQxwZtx8YF2j3O648iahsfTMWP1vqBfIB4/C/mPHqAmN3X/AK5C2e7AcSTW1d6gKTYgPeAeHQKXiKIYFUzvi5+CZHYVvVH8GQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=Axtsrb9/; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="Axtsrb9/" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-43ede096d73so31958965e9.2 for ; Tue, 06 May 2025 02:01:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1746522116; x=1747126916; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=B5xX5xDK1LhTZKmUeFagQY4z7X//bT5WMr4CQHakD5w=; b=Axtsrb9/gBTNBnBN+wn/Da3sjU+W7rcDpTPyyyf1H4KskiR7W6tLd0QNO45rQWCcdz XeutclkUh5kd6zv17pINpC0vVDTIjh94HUKdmLnRiX81OPJW9Md3nOF+TF5EdtUgPo2v q3Q228AsBn6B7x1sj25FNbQExG70lCmXRonwkAumgFrmjFtpS+CxOxQ0IRZ6L2S2smoz eP5OmX2IKRUaypguMtm48Yosgqy2vReL81FH2gUHQG1Sn2j54KjEmaCUNuXC6tquij6y 9fsdGj1L/t0+9/477McPq9ckrcOQ5Gaz24oGzcS4dUwWlmkQjYtUEodEvfRWQ7RwgGsi 0Jbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746522116; x=1747126916; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=B5xX5xDK1LhTZKmUeFagQY4z7X//bT5WMr4CQHakD5w=; b=CVa4XjSovr4m6rVnfeHMZH0sFwZjRsEH6uHPx/WleC33kFJfRCmPReFHuJSIBt0Pyg ZppsnYJo2khrM1foPM9oczB9bxZDJ48FIWjs07AyJ+jUwrabpzqYQfT3KR/7F3yD6NjY XWw5qQGd0sfBLITAcsQZWm2EkPJWjgfkdvU9mXUpRnf5f+looWwqiSxY8Z+fNA009ieA 76PhlEvZG/lZ6EyImdfsiY6WNbigF3jvKQ/bTnXMxaKDEUA2mJcTMIFwDUa9iNey/C4j oS67706KPG9feHQWQsWHM/iTioHvaRQp5fQ9MfD+NeunIfK8i//wosiPg7qlLPRKTjmb OhbA== X-Gm-Message-State: AOJu0YxyjQ3kBUE5TpG4UHD1XlMn39xWoOYF95+j9pBtBtMg6S/MTeva iUS9rppiaK6cAlxxazt0nQE9dDV6wHJPiCiUQxvccFDGeBAKxFWy/P/DdJtmF1s= X-Gm-Gg: ASbGncv3kE1MKrMb5Lz1Jq9QWXdJ082Ifzr2Vj5KETZd19ui0atSNNTCSxMQEZanPA5 NmgLrJ9RRfBtyqfJKNMAgBd8Ar1vDo/JXq2/lkf5jkijCuvq7ik6iTEoTkkhl37cHnMPon6ljta l/CnUJ3qkx0QXPF1bqwaob+ZlOfvo+wJ5eWTof6GBySKspEgoGzlex9h2zsnIu/QwHBYK1dJ7Gn NQ5Ct1Z6nUCk8ey7D2LsVj/SegelCK7cnbK5YnY681aZ94EC80UTMrTeGNUHYxvOmoUZKM9iP57 im+soHL2u+oks9QFZ2HB3EyP1K2gM0nRW0c= X-Google-Smtp-Source: AGHT+IEhEQmtTeTN7IWRZ8t6vAkVX+cpAae/AbxZLwUc76/VgMs/gN09VBYqk+ftARkXwaYPcjiIdA== X-Received: by 2002:a05:600c:3d8f:b0:441:c1ea:ac35 with SMTP id 5b1f17b1804b1-441c48dc3e2mr82793035e9.18.1746522116150; Tue, 06 May 2025 02:01:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:bfd0:3ad7:fd8a:fe95]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441bc83d471sm138125725e9.26.2025.05.06.02.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 02:01:55 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 06 May 2025 11:01:46 +0200 Subject: [PATCH 03/12] gpio: lpc18xx: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250506-gpiochip-set-rv-gpio-part3-v1-3-0fbdea5a9667@linaro.org> References: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> In-Reply-To: <20250506-gpiochip-set-rv-gpio-part3-v1-0-0fbdea5a9667@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Vladimir Zapolskiy , Piotr Wojtaszczyk , Charles Keepax , Richard Fitzgerald , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, patches@opensource.cirrus.com, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1404; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=gRCbKDYWwPPaQt6l4gb0BixRmpWGNrb8kCwxis9bt0g=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoGc/9i0uQJY2BhC2Zrkvn3BoBUEcrSA7AXU5Qy HhV9DYw8tSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaBnP/QAKCRARpy6gFHHX cgjwD/93U00fkkxaHhdkDkIlVUsJezLok4i7YHaxAuCQXD7314SjDuTfb66TE169HcoiHhxuRCh oZ9hw3ekQ6adWrpAosQzSS8Y2ZhLhCox7bdRrgm5fVQOOH1Q8G+DOyHbaKjLc7aI1ntaZQNaxCX KhvlUhTFYk5VEjQAbMqTNCXOpK/wnoHjaB5G/FCOgPrBygbAgZm+HYGVLCkqBh0KmgQQopw5qFB bTbl+qG/kj7i1rjObZx6DLtTURDsJj28sztaAM5lHt9fGhrBD28XodsWCb5vU1v9qM7OZIFJ3JO cHAed/Ei61otC4cOXACJIOumlsXwVyGXf/W0Ca7VBmdUgSk6PjnVxGMjfEZK77/8dJtBPucS55R 6SeGYrN6R9bybkiF/oOdzmWfh+VsJHoqcgMgzMJxLUQP3iM1zxxyMADvjoT2dxh/H5GWR0FVzWa Kb1/HsMmdhOY+yazJo2P0qrsLQsk3HoHrh3fMzUPgDNd66E2ZIHTGEq4DQSHRg89IbZGY9f40eJ 276sGF0uzhjcKzLq1iBiDTi8iti8/9WYhenl30CK/2wkos6A9sIbIgTjGKy8VF9+Rf0lGaCS6dv LPjIK06bWcIcR8WWzwbvk1lHdjbt5yhXnftqAT3zT9PhSxFX6miZo++KAtjyw2zQnBAicckizWw n85veXeo0akuOxg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-lpc18xx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-lpc18xx.c b/drivers/gpio/gpio-lpc18xx.c index 2cf9fb4637a2b..8bb8a87ec1e99 100644 --- a/drivers/gpio/gpio-lpc18xx.c +++ b/drivers/gpio/gpio-lpc18xx.c @@ -263,10 +263,14 @@ static int lpc18xx_gpio_pin_ic_probe(struct lpc18xx_gpio_chip *gc) return ret; } -static void lpc18xx_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int lpc18xx_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct lpc18xx_gpio_chip *gc = gpiochip_get_data(chip); + writeb(value ? 1 : 0, gc->base + offset); + + return 0; } static int lpc18xx_gpio_get(struct gpio_chip *chip, unsigned offset) @@ -316,7 +320,7 @@ static const struct gpio_chip lpc18xx_chip = { .free = gpiochip_generic_free, .direction_input = lpc18xx_gpio_direction_input, .direction_output = lpc18xx_gpio_direction_output, - .set = lpc18xx_gpio_set, + .set_rv = lpc18xx_gpio_set, .get = lpc18xx_gpio_get, .ngpio = LPC18XX_MAX_PORTS * LPC18XX_PINS_PER_PORT, .owner = THIS_MODULE,