| Message ID | 20250606-s2mpg1x-regulators-v2-1-b03feffd2621@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Samsung S2MPG10 regulator and S2MPG11 PMIC drivers | expand |
On Fri, Jun 06, 2025 at 04:02:57PM GMT, André Draszik wrote: > Using lowercase for the buck and ldo nodenames is preferred, as > evidenced e.g. in [1]. > > Convert the example here to lowercase before we add any bindings > describing the s2mpg1x regulators that will enforce the spelling. > > Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1] > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) So this is also a dependency for the rest of the patches? Best regards, Krzysztof
Hi Krzysztof, On Wed, 2025-06-11 at 11:04 +0200, Krzysztof Kozlowski wrote: > On Fri, Jun 06, 2025 at 04:02:57PM GMT, André Draszik wrote: > > Using lowercase for the buck and ldo nodenames is preferred, as > > evidenced e.g. in [1]. > > > > Convert the example here to lowercase before we add any bindings > > describing the s2mpg1x regulators that will enforce the spelling. > > > > Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1] > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > > Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > So this is also a dependency for the rest of the patches? My thinking was that it makes sense to have it in context with the other patches, but it indeed could go stand-alone if that's the preference. Cheers, Andre'
diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml index 9785aac3b5f34955bbfe2718eec48581d050954f..62a3a7dac5bd250a7f216c72f3315cd9632d93e1 100644 --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml @@ -64,7 +64,7 @@ examples: interrupts-extended = <&gpa0 6 IRQ_TYPE_LEVEL_LOW>; regulators { - LDO1 { + ldo1m { regulator-name = "vdd_ldo1"; regulator-min-microvolt = <700000>; regulator-max-microvolt = <1300000>; @@ -73,7 +73,7 @@ examples: // ... - BUCK1 { + buck8m { regulator-name = "vdd_mif"; regulator-min-microvolt = <450000>; regulator-max-microvolt = <1300000>;
Using lowercase for the buck and ldo nodenames is preferred, as evidenced e.g. in [1]. Convert the example here to lowercase before we add any bindings describing the s2mpg1x regulators that will enforce the spelling. Link: https://lore.kernel.org/all/20250223-mysterious-infrared-civet-e5bcbf@krzk-bin/ [1] Signed-off-by: André Draszik <andre.draszik@linaro.org> --- Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)