| Message ID | 20250610-gpiochip-set-rv-gpio-v1-7-3a9a3c1472ff@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: convert another round of GPIO drivers to using new line value setters | expand |
Hi Bartosz, On Tue, 10 Jun 2025 at 21:33, Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > struct gpio_chip now has callbacks for setting line values that return > an integer, allowing to indicate failures. Convert the driver to using > them. > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > --- > drivers/gpio/gpio-msc313.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c > index 6db9e469e0dc254e791d497b89a4c6d329d0add4..992339a89d19840fc03ccf849972a83cb86415ae 100644 > --- a/drivers/gpio/gpio-msc313.c > +++ b/drivers/gpio/gpio-msc313.c > @@ -486,7 +486,7 @@ struct msc313_gpio { > u8 *saved; > }; > > -static void msc313_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) > +static int msc313_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) > { > struct msc313_gpio *gpio = gpiochip_get_data(chip); > u8 gpioreg = readb_relaxed(gpio->base + gpio->gpio_data->offsets[offset]); > @@ -497,6 +497,8 @@ static void msc313_gpio_set(struct gpio_chip *chip, unsigned int offset, int val > gpioreg &= ~MSC313_GPIO_OUT; > > writeb_relaxed(gpioreg, gpio->base + gpio->gpio_data->offsets[offset]); > + > + return 0; > } > > static int msc313_gpio_get(struct gpio_chip *chip, unsigned int offset) > @@ -656,7 +658,7 @@ static int msc313_gpio_probe(struct platform_device *pdev) > gpiochip->direction_input = msc313_gpio_direction_input; > gpiochip->direction_output = msc313_gpio_direction_output; > gpiochip->get = msc313_gpio_get; > - gpiochip->set = msc313_gpio_set; > + gpiochip->set_rv = msc313_gpio_set; > gpiochip->base = -1; > gpiochip->ngpio = gpio->gpio_data->num; > gpiochip->names = gpio->gpio_data->names; > > -- > 2.48.1 > Reviewed-by: Daniel Palmer <daniel@thingy.jp> Cheers, Daniel
diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c index 6db9e469e0dc254e791d497b89a4c6d329d0add4..992339a89d19840fc03ccf849972a83cb86415ae 100644 --- a/drivers/gpio/gpio-msc313.c +++ b/drivers/gpio/gpio-msc313.c @@ -486,7 +486,7 @@ struct msc313_gpio { u8 *saved; }; -static void msc313_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) +static int msc313_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { struct msc313_gpio *gpio = gpiochip_get_data(chip); u8 gpioreg = readb_relaxed(gpio->base + gpio->gpio_data->offsets[offset]); @@ -497,6 +497,8 @@ static void msc313_gpio_set(struct gpio_chip *chip, unsigned int offset, int val gpioreg &= ~MSC313_GPIO_OUT; writeb_relaxed(gpioreg, gpio->base + gpio->gpio_data->offsets[offset]); + + return 0; } static int msc313_gpio_get(struct gpio_chip *chip, unsigned int offset) @@ -656,7 +658,7 @@ static int msc313_gpio_probe(struct platform_device *pdev) gpiochip->direction_input = msc313_gpio_direction_input; gpiochip->direction_output = msc313_gpio_direction_output; gpiochip->get = msc313_gpio_get; - gpiochip->set = msc313_gpio_set; + gpiochip->set_rv = msc313_gpio_set; gpiochip->base = -1; gpiochip->ngpio = gpio->gpio_data->num; gpiochip->names = gpio->gpio_data->names;