From patchwork Tue Jun 10 12:35:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 896410 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7710C29CB3C for ; Tue, 10 Jun 2025 12:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558970; cv=none; b=qrOeMS8D7rBr6u4dt/BNISFTpteW9jJFCfhG/c2MMI+d3NQWfcOSy7QAH9ItKSFQY4SaK0JLFfMcg75YQHby7DITEHWXAo5+PyRk6By3huobELzSU5ZfchXqiq+j6bkWD2HIT4yuV+xcA406uLbjhRdcwoOo+E6FoBxhxeDoIQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749558970; c=relaxed/simple; bh=kgpyXSnZmCFwqfmomq7FGHn3gBVV4OHMPubpvkjXFrI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gIWEL/A50jfKaPjpJDsJWFn5No1qllL2yozrUQFPG1ccuTyPb/+fbWBJn0wUdXNOcMRsKuCl02hI7S8ZfWNVWUYDSb7Rj1bEPYHgaiAYs430+p3THHGSCYh9b7rCCpGIEi7h6047WyXIUu8nUG/ECMLavaDv3w1cNezVm5Ca558= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=tEHi3Bh+; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="tEHi3Bh+" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-450ccda1a6eso50419415e9.2 for ; Tue, 10 Jun 2025 05:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749558968; x=1750163768; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=tEHi3Bh+XruBKEKnMg3YGLzi97cXmiX0nLxkjNZCLaNfsbDWwJ5B9Hux2QHaEaN1Jn VCusLoE91wgtXtyZitmTaC8QM+0Yqtd9ghIONGqjRZuwKimjEH3E/4VyqEB+NKy3969G rzz0MgnbHdz3oY/Z2tOKfXJzAGgC5ufI2gPURdFRKKLkZZdwoirCxfq0ddJsuEtU8d8a LledrMs5VrMEVN1zZe2G826s/+/+MH+7TcWiOI/4rOjYhjwr4hTbRhXcEj+WcSH0NnUC U2m41Qk0tfIOYzYAMa1/GGG/Fr8ZBpvlA0V5/0PbNKdDmaLWR8PccCtOZy3DaIJYR/Mm KC9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749558968; x=1750163768; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EmUjxGb9YXlrFmgTBSGtVdHlWeBBc2YrESubaUeQXrg=; b=Oxjv4aQ3XSeoFvCPEJvX6iOhvlNAJfO8OB6hj9c3SrpWdQ2iU61nwwGfL7ngx8oqWg 56YaEt7cDx1qq20Y5e6D7prlVncFVCjzKdostw+MeraHZoFdpHsEMP9PTLwnb3DaTje0 lW/K2kGApn8/UW+4XhCKEb3PeoQyYMsjy/uOZkiPd2PEXblMiV/9JMHq7Q339N5S8+le ZfGJYzyOrS6ufq+cvMdWmWWw0DT+CDBBgXImOX1eWn172R8/ZcuBAoW84i///LYCtL2P OLtDxq1zjeWf4bdu2ftHr4ljNSQkSIFqDzW7iW7vmvEE6y1OS/IFmGHz9QvNEl5hhrwu r0CQ== X-Forwarded-Encrypted: i=1; AJvYcCVr2PiqIaNx/yH7jk++ornQcUx7aLD2/ryJiHKV6b0gT7AmpW5BIRJAihhDO/yyeXAQSrqRSL+3SdT4@vger.kernel.org X-Gm-Message-State: AOJu0YwBHRWS1g72S2NULRKl1GPX+ZS6C0qXrS50Bysp4iU35VoO+PzT pmufabAulOO5MoqVXw9fZPXrcbE3LzksPlRKN+gO4F3oi7/rTOaubIaRFY73fk+P78A= X-Gm-Gg: ASbGncuN7vxsaIms+lIBAe9M+S3zjYHnn6jCoZqhTeoGWZUJG3QIQ9AWwDZ30fxqCsX W/7CsUTiAeziDlkqaEbIRo/xXUhIeepQf7p0o41ENUYYge6gfZ6qlzmLUJtFHv537574BJFdv/f JgIE+zyZ+FgYlt9PYP74dYBVa7rjZ3tKD0+ZYNrw2yTiGMI9QJkUcUsSwYcANM4L+g2hS3kwTYc 20+WD9wgpIPaxrgNXZZHltKWBywQs42l0ywyobwCIatUhtvN7U5AcLR4Viz92N8e9qD7SlI4eZw KWrr1jnkAP2Jbnaj9EdDN+GOvTgW2ZNfaXYgKgk6kdz9hjjKMxWTjg== X-Google-Smtp-Source: AGHT+IHhf0yhbVAU53CCnx70BotxQgp+L6cndixtYZtb017L0GDbKhx9QFoSw4ecB4gLAszon3Fb8g== X-Received: by 2002:a05:600c:458a:b0:450:cabd:b4a9 with SMTP id 5b1f17b1804b1-452014ea1ebmr148815685e9.29.1749558967893; Tue, 10 Jun 2025 05:36:07 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45307b4788fsm91008455e9.21.2025.06.10.05.36.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:36:01 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:35:39 +0200 Subject: [PATCH 5/7] media: i2c: ds90ub913: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250610-gpiochip-set-rv-media-v1-5-c088006a152c@linaro.org> References: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-media-v1-0-c088006a152c@linaro.org> To: Mauro Carvalho Chehab , Linus Walleij , Bartosz Golaszewski , Bluecherry Maintainers , Andrey Utkin , Ismael Luceno , Tomi Valkeinen , Julien Massot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1383; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uirTvdGFKLj1HJ829gQF9CK8Tn6xJqSzhqLKMW/nEqE=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCad2woSfO3sebexW9Mt3ViNPTAVSqTNciWIU a1fvZKssH+JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgmnQAKCRARpy6gFHHX cisHD/485qXHf0m8whtLOAatdU72Wh0xmX1LQCoEJ8lYqmSn1CNAuUbRDS5Xt++ChKIdlUgHAUp dha8+20jLZQG8Vt+PtimqLHAcQ0C1ysgeJAZ87FRyk8gZkZqQqtM22spmbSP5rEi3FKriglwT3k dd124M1zjStOeTz+SIKmrlTOvss4mJfsmwa5TU0LUB4HMfIwHhH5mhmK8EDC2Jr13o/WP/xsOxk v/yQPNoNaPRUA2UQRTFykbqozRLnsLlGznz4myOFJIZGXHUgg63M9vMYsi9WOlYQl+n16Kva3yS vaEu0TYIMPwAQzSKUvflz6sjYTY/oWEEigaDnvmBcSIs9jnplkLNiB9YajFBnSnbACEm9BKes4l 6+wTXfBdD0VmbT6xIs8CTAXREwxDxSCbrv2PSVphbOMtF8LNH5AUCeZ86VaBIi0XFX+EozYEotG qCjcjoQkCKjX35KEy8LfeAspwkl+xHA5TmnLW/20UKv+QsWqiwIOa7ggoWaAQ7XxI9X0zZaFR4w 9N6U1gejgLfC1a0E9M30P5uL7Vmc16fsnE5V1IFHUfO2218tUcbaAvfghe2jmmwNBlGTFivrVp4 CDjsXHmTXpKm8zVrkf/ix3PYkogl3gAugAmVL9JKgI+IdlW9UmuLx6Fh/+yggvWpQ0A+ovEBeV5 5FcU4DP9GWAOfpg== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/media/i2c/ds90ub913.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c index 6d3f8617ef136c6f47871f5886193fe934c6f3b7..c34ffeae5f5080875463b6b6d45acbd9e107d461 100644 --- a/drivers/media/i2c/ds90ub913.c +++ b/drivers/media/i2c/ds90ub913.c @@ -203,9 +203,9 @@ static int ub913_gpio_direction_out(struct gpio_chip *gc, unsigned int offset, 0)); } -static void ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) +static int ub913_gpio_set(struct gpio_chip *gc, unsigned int offset, int value) { - ub913_gpio_direction_out(gc, offset, value); + return ub913_gpio_direction_out(gc, offset, value); } static int ub913_gpio_of_xlate(struct gpio_chip *gc, @@ -235,7 +235,7 @@ static int ub913_gpiochip_probe(struct ub913_data *priv) gc->ngpio = UB913_NUM_GPIOS; gc->get_direction = ub913_gpio_get_direction; gc->direction_output = ub913_gpio_direction_out; - gc->set = ub913_gpio_set; + gc->set_rv = ub913_gpio_set; gc->of_xlate = ub913_gpio_of_xlate; gc->of_gpio_n_cells = 2;