From patchwork Tue Jun 17 12:24:28 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 897776 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D242E6D36 for ; Tue, 17 Jun 2025 12:24:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163091; cv=none; b=JU8Al7jvUuxrrS0HjU8IYahNbDff3pCp3AUbbIwdMrMXGijofCFZG9pq4yrT4tzyTufvSjniyNws2r2cj4/+GZC1FgLqmhS9VdfwKGKFVslassYAYP3yLmY65JVAdFDs5kRrm9iz5LAOkr9fraKiDgZje5FQvdFaLLvlLoWNYiA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750163091; c=relaxed/simple; bh=TIbLTydFbIxMUGka9nMFS3KxZgZxnuWfV2GjJh3DcXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n0vxntPcVsKEjs+Erh3wO+Tx4EtPVBHi6Da4856d6NBr1fF0aTkJtVyqonU6df6H3sCZXL0hgDOu9dddnc0hZAhVHglrzOnGeT9Z/iz8p3UL6JWY2V7DiY4WT7gG7nwXukedcZJ77bEgL0p7Ou/kFgcqDnqkwbTnPmbmmIM584U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=HAf+3WaN; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="HAf+3WaN" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-441ab63a415so65092015e9.3 for ; Tue, 17 Jun 2025 05:24:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750163088; x=1750767888; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rBA3kzrSkCDXqL/qmFtpqMrbH8iiG3hu1F80uNaFdYQ=; b=HAf+3WaNaIkeA3s5LTvHxIKpT4cJOjuIY79m8X8/UKuupPtj5giANzCX4umC3igcKq oOShmMpcIwZSXJEUXD/7VEE35CB/YPOGEu9soY1Z1Ihm5+pIIbzDQmMghLN4PZcubMUu U7/Mn8/QCXizn/yeFzqJCb3n+ls0TmyNU4BVVPNKExbst4zipJ00lXVe3vePT7qC2YuU eHo+lxt1Su3NXeNOdo2+JciDp28Z4jTxP26c+4af0ipd4nbSYWCrCtAkrXqefQ9qE2lF DQGCpp5lYnH9Kbq7l3RLBsv1Cr7dDZJ6ABenqRD1gVDw/5hXJaSXT4vegB9NtGUQL0bb dU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750163088; x=1750767888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rBA3kzrSkCDXqL/qmFtpqMrbH8iiG3hu1F80uNaFdYQ=; b=mtOGS08DtgDwrlh5SD/vc4xedIFN3mhd4fFm3QOXIzWf5wlurEIxhdlo1GeqD5BhgW XOgg1MBeYoIhPF5m3uk67exCO0AfpJpWxJ1ZTNXa/WnMSn+FW9jOl7EOHZkHecAWYC/n jtClWoppW/jYpQvmu62YjbIBTgKj/UaMyZ4G5ZgjL9za/cmOvtFBVknDF2yrQlaTATGJ wEyHTAfxocp8NEQDGZmcaTmcLZMonH6Y2CnOG9AJYhQlQLiEfy+1VeHJdHOU2lf+fbqR x1MSRV9Jj3CWn01F5ozVSrSo59KXCR7jK48Hw4PgS/ORJwS2wiAe9U8a0WDSOMOZUK4F nKEg== X-Gm-Message-State: AOJu0YxRDK52ZPIKxY0LCjg1D9aj4CuJP3ZJEpCTEqhnJL6CKwl+4Z9t JmWDls3TlpnjvsFJlkLj9UTcCSstcY/TIY8mv8h2XftdvwfiaheH6/RvgUvrTdeaxck= X-Gm-Gg: ASbGncvX71PuuZ0smPLGSe7/wOYsdMI4+eGPaW9pjiFqT6N+b3nOThJe6KAYWrnApbh 6ZzNEHamuk/r/LBnT5X5ATEByK3Dv9bmEr2etwdg1P1kY8rfpYhZHLW2RMV8OK3rl5h7H8q21rI 2jEOG7DhrX/uGELfXQMlkTee7paHRd6e9BMXB6EB843/5HcSPdZ1/rDEGHMNoCwVe2mCzRcLoAz kjGKLCe7wZisrsfBL8D30OHO7yDgj5aX+Dvhe9V9h8d81PGykn5K+2JyCC9/p9X0ew3ObmWLLMw xROS9ylEVsFkncjyQxQEgAij70GGAldynzp8LRYpqXY9jFoL2c7MqLSN X-Google-Smtp-Source: AGHT+IFM4CB6egWygK88t1cCzbwx8tBuCLfY0nKXhXb0rSxlnrlGoYbjnFIM6NMIfDKL54dPCw7nOA== X-Received: by 2002:a05:600c:6989:b0:442:e147:bea6 with SMTP id 5b1f17b1804b1-4533ca54d9bmr129406995e9.11.1750163088388; Tue, 17 Jun 2025 05:24:48 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:90df:ded7:9cbf:4074]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320562afbsm173816135e9.1.2025.06.17.05.24.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 05:24:47 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 17 Jun 2025 14:24:28 +0200 Subject: [PATCH 06/12] gpio: pxa: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250617-gpiochip-set-rv-gpio-v1-6-903703881fa2@linaro.org> References: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> In-Reply-To: <20250617-gpiochip-set-rv-gpio-v1-0-903703881fa2@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1502; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=B+Qz2OspKJ91xFNTEdAqgmxdOA/mnHzp8sm3HNk30eo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoUV6H5nCXll2tmzt32qwVJ5b3oXA1BlRJjKdG9 qyMmbsQkzKJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaFFehwAKCRARpy6gFHHX crYrEACAJfGgkYJZ/u6TIzjXF0YEJwOtUfXB3u9+xQg83jnj0Sz1G2H/QIRldbaqCd8kUmXDI65 U0eFZ619I553u6CBkPVrChl3ZZpXtUKtGWeB6ManlL30/0d31D70RtVTKbKWHN4SkTFXOUwr61V us0hdDZcVXONIlywiB7f9yUPaJb+SEygs3L2h2URtZ9XF7mwRvxRQVJ9HKe1sSnkEGczZDCQ+82 Zi+gBEJnqqEK6cyMQmdBTYAPcSLi+GT5y6AHFGh50EKfqzjR9wEvwZ5E5GrfQM+SNxZVEXYL64v SbJH6gq+aHB9TwUiVoFRA6GI5ex4dq0Dx+R6b/k+ObpgcBKB0fCm5OCACmniQ4J0nHwpFNe69/Q 0/MXLF/xPeNfTqpMFjRSoYsHf5OJTFyidc9WUKOkPWLakCilxZVYLXovCTdgyaGpr2u5H01mNFO gaTuYuqpVkMmeGw2KEwr4qaQaQeb+yBpGBcKNt6ntqnpsRfMz1sIgF4/s9yJZddJ9NOA8xWR/VN OXZ2p/rlEhoTCRH1kmNm6TqTFs72FvtA7UXobCt3Ya+NAIr6F7X9iLX0CEaY0w78ZnJWqkUxlBJ EQQaPvVZWslahNf+l5I7HxiDZ3oB5l6gkBTIG66RkME6zNBACqjO0X8zT1wS4UiXp+ChfLA8HBF /Ooc4sXgrvhot6g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-pxa.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 131ab79ebce7555313fd93b3ebd80582d1b9327d..13f7da2a9486428bb8d1d44d2caf9f21f82cbca5 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/drivers/gpio/gpio-pxa.c @@ -315,12 +315,14 @@ static int pxa_gpio_get(struct gpio_chip *chip, unsigned offset) return !!(gplr & GPIO_bit(offset)); } -static void pxa_gpio_set(struct gpio_chip *chip, unsigned offset, int value) +static int pxa_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) { void __iomem *base = gpio_bank_base(chip, offset); writel_relaxed(GPIO_bit(offset), base + (value ? GPSR_OFFSET : GPCR_OFFSET)); + + return 0; } #ifdef CONFIG_OF_GPIO @@ -353,7 +355,7 @@ static int pxa_init_gpio_chip(struct pxa_gpio_chip *pchip, int ngpio, void __iom pchip->chip.direction_input = pxa_gpio_direction_input; pchip->chip.direction_output = pxa_gpio_direction_output; pchip->chip.get = pxa_gpio_get; - pchip->chip.set = pxa_gpio_set; + pchip->chip.set_rv = pxa_gpio_set; pchip->chip.to_irq = pxa_gpio_to_irq; pchip->chip.ngpio = ngpio; pchip->chip.request = gpiochip_generic_request;