From patchwork Thu Jun 19 08:33:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 898093 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D5DB2676D9 for ; Thu, 19 Jun 2025 08:33:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322017; cv=none; b=L9jUK6cH00fAgXq76gkAJKToJHmZzDiCSRL6agFYMH5DzVQGFPsfhbWeuUZnEON3uAccrEfmj+sWFEu3mHBrSS97p8uLgP9kuwF+wK3y7X6rnRSylet9MuXVN/xEyOCdQccb8Muy1R2ZmwNJoWOoixMfWkpKpHBkEYrGTnY8RdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750322017; c=relaxed/simple; bh=KyzGRm5PzFaaCx6vaqmEFT/UHLNaTRS0BfqoZ2z4ZkM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RFmokhbxoWQc9yjedRZwnhkGKWDYBjtcsxzCoCNH7R2cC+tpdmYpl5OyqgpUilCa7JeAVdRg9nb8ETyc57hFCfP4JXRS3NMQt0gbTfvZpmY86aMLi3/LvpB1Zi/sfEL/zy1NfUraQ64JGJS3saB+IX94AfoZ7B0MTyA+c5HNgak= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=iAdD94qF; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="iAdD94qF" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-3a4fd1ba177so278434f8f.0 for ; Thu, 19 Jun 2025 01:33:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1750322013; x=1750926813; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8+GlKxeWL5Yw829/r0IFKSs2jp0Xuv75Z5VhmG/MTnU=; b=iAdD94qFvWGppkwFRh/nDnZuzgMBWiwjVN8bqYdEksYXHYlDWwgG0M/rug2K5SbjnG 8aKuit9eP7531YEvIbpYUOfbJnallHS/bbSQwMC3mu+AYiuKlJlyepLRoLvxcJ+bbavD DunzRrK/8KsXMODgUCAr9No+xPtrVDN34qVoQ3dOytdkLNGmoBHYaMe6zPfH3h4PmgLO ZM9s0K5HpDfy9ijNsnu6ducf/156sT0etzMFx697bDOt/gYYvQylNmoSaZ4GbURZKWOA teKH5ww88yahRT4jFiV16ev0K6U1lzw3Tt9nyNqDcpbI8Vvq0MzttZzXq195mjNFoIDa A01g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750322013; x=1750926813; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8+GlKxeWL5Yw829/r0IFKSs2jp0Xuv75Z5VhmG/MTnU=; b=B2PPGsiIWrDrg2heYrFQn4Sq1U86WRGu0a/I69ZWLkvpQOtfSgDBjFw5R72htU054d 3IlBQ/iv6EsGhn5Hy2HgsAIPdMewLi1amPQjFF71kZhJQ9KyNdPduf6FO5nt9kV9dcPI YtLP1LgpDna+jsUFQoHdWiKUeQ2+wvZ7uzvRk8k7d1xErDj+lvB3Se8WxssqJqZb6IBS QjV7y9IGCQNYZC4S+UWlHJbmPztcoUghZ6l3TFKxt9Uw1jIE8vdCkzY+q5AiB0aLavt2 prHa7HCPpyp20CXMVhXfOeACIfhp+Uryx3vGlSLmjd02Ad/v+5SNZ2qqQyU9DnQ7DVXw e/kA== X-Gm-Message-State: AOJu0YwXCCsw46dqW6qrGCu7jGAGKGBuZ4fQx5hI+sS6Nrfmghsm7KVY f+FkFlluH7Fade8eP1TyChhZsRzptX0nFKkuFha7C3irUg0NFFyU4Msl5XMuZSsquZ8= X-Gm-Gg: ASbGncso2AdLUSGBhP3YHUB44v4hFeJLG52zF5LOO1PAtjpqv7Bvc5GAifEFZuBAoLw 3yT/3eMRbrCqFVNM7dC+TP5Eq1jhr/am0C3b3UO4qwSszVs/BDVvWtQe7eljO2tX/FszLh6zHgF lhrLHf7hlymB6AXO1nDRTuCFmj53K7IkIgzoD35macQCS5jcQHQC7kRINigLd2Klt+GUjK5cZem VK4caSkx/m6qhxJmQ4GWXF4Hb9AkhOi3GQ16R5qWjTbh8k+k/LCYjrw6XAzQLZbtVLw1mLqxNgm dtCrVI/8oN6XmQJyZzpbBILboqud9Hg8qnahx85SxLBWTvPjY3JxfKTO X-Google-Smtp-Source: AGHT+IEYd8zh0M+GIxvzO+cbczfDdVgwEB9/rBo3uvdJxipNvbLdwuD0peBA9caOs/ahFdM6KsbEFw== X-Received: by 2002:a05:6000:1448:b0:3a3:6478:e08 with SMTP id ffacd0b85a97d-3a6c96e5663mr1866539f8f.23.1750322013194; Thu, 19 Jun 2025 01:33:33 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:c485:fe15:c9ab:c72f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a63a42sm18828151f8f.28.2025.06.19.01.33.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 01:33:32 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 19 Jun 2025 10:33:20 +0200 Subject: [PATCH v2 07/12] gpio: rc5t583: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250619-gpiochip-set-rv-gpio-v2-7-74abf689fbd8@linaro.org> References: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> In-Reply-To: <20250619-gpiochip-set-rv-gpio-v2-0-74abf689fbd8@linaro.org> To: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Orson Zhai , Baolin Wang , Chunyan Zhang , Robert Jarzmik , Heiko Stuebner Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2356; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=aSlqvGnhuSY1VlIGZB65GCCYVPKtjnadnIRxz6DCqho=; b=kA0DAAoBEacuoBRx13IByyZiAGhTy1KgqNjnmKmQLkXGxxWam8m1Wn84v8Mmm9k8q48PP1VEY 4kCMwQAAQoAHRYhBBad62wLw8RgE9LHnxGnLqAUcddyBQJoU8tSAAoJEBGnLqAUcddyFFkP/3zl 9RL/sxOpe2l7ZXx8muE1QdETZweVSf+QCakclyiBOlu9V+DX29m4PgdsLs7RKPBYR0bOoIDi37b cUxvgu1Db2DezcO6Hg/kISB1+kKTP1ra+mLibE2HkoRO0mGxEZUk5K7kWPfZxSjj0TkNOmIYb0u w0USK1lo+9vZbTXvUhMyxNzwP1oIzKV4EWICo7JXE3Yb25kPiera8eYaDQJmiGVzqsx2zlhOY4y 7JpKNjCYk38N9bAJpcMTpRe6X0HRqLob3wwRAWArAqfiyx4pM391d/laNhzmaB1EXW1G4p3X//z kXkuOi4cLqMXpbFt975vL5Aio5buuqcB83ajhxzy3o4j9rx2josJqR9yLf6HyV/FrTjJPQNRHw8 NFmhK39BfihcDsv2CStjI+rOhyR3whWppE+BvJi1H/Coa74Nsu1RblwOdUZzsvAY2NZMdgFXeE7 X+5yOnzSdyGBGTPyO1Nmy9T/cPj8C0zokeHVrUU7+nsQuYPa5xy2UNrO8KoZoZytP5mmMTmmupL JHLECUgyjbL/duwYUzSsQGm3c8sEogb2FjvnpzeA0Ryk2j+tI7D0R03WcI9DpCgUNZSVWpGgk41 TStG9T3DmCHn5cFwFUUV/EdG9woFsowNaioLk3P5F3nzAJk4sqhrc1Ge2ABs06g4AZ0JULQEtRY L7iFT X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-rc5t583.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-rc5t583.c b/drivers/gpio/gpio-rc5t583.c index c34dcadaee36d5fb775d4aaa8c8f8b275f4e2382..cf3e91d235df2eefc7d0fc93a58824edd55e9aba 100644 --- a/drivers/gpio/gpio-rc5t583.c +++ b/drivers/gpio/gpio-rc5t583.c @@ -35,14 +35,20 @@ static int rc5t583_gpio_get(struct gpio_chip *gc, unsigned int offset) return !!(val & BIT(offset)); } -static void rc5t583_gpio_set(struct gpio_chip *gc, unsigned int offset, int val) +static int rc5t583_gpio_set(struct gpio_chip *gc, unsigned int offset, int val) { struct rc5t583_gpio *rc5t583_gpio = gpiochip_get_data(gc); struct device *parent = rc5t583_gpio->rc5t583->dev; + int ret; + if (val) - rc5t583_set_bits(parent, RC5T583_GPIO_IOOUT, BIT(offset)); + ret = rc5t583_set_bits(parent, RC5T583_GPIO_IOOUT, + BIT(offset)); else - rc5t583_clear_bits(parent, RC5T583_GPIO_IOOUT, BIT(offset)); + ret = rc5t583_clear_bits(parent, RC5T583_GPIO_IOOUT, + BIT(offset)); + + return ret; } static int rc5t583_gpio_dir_input(struct gpio_chip *gc, unsigned int offset) @@ -66,7 +72,10 @@ static int rc5t583_gpio_dir_output(struct gpio_chip *gc, unsigned offset, struct device *parent = rc5t583_gpio->rc5t583->dev; int ret; - rc5t583_gpio_set(gc, offset, value); + ret = rc5t583_gpio_set(gc, offset, value); + if (ret) + return ret; + ret = rc5t583_set_bits(parent, RC5T583_GPIO_IOSEL, BIT(offset)); if (ret < 0) return ret; @@ -109,7 +118,7 @@ static int rc5t583_gpio_probe(struct platform_device *pdev) rc5t583_gpio->gpio_chip.free = rc5t583_gpio_free, rc5t583_gpio->gpio_chip.direction_input = rc5t583_gpio_dir_input, rc5t583_gpio->gpio_chip.direction_output = rc5t583_gpio_dir_output, - rc5t583_gpio->gpio_chip.set = rc5t583_gpio_set, + rc5t583_gpio->gpio_chip.set_rv = rc5t583_gpio_set, rc5t583_gpio->gpio_chip.get = rc5t583_gpio_get, rc5t583_gpio->gpio_chip.to_irq = rc5t583_gpio_to_irq, rc5t583_gpio->gpio_chip.ngpio = RC5T583_MAX_GPIO,