| Message ID | 20250620103012.360794-2-mohammad.rafi.shaik@oss.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | Handle shared reset GPIO for WSA883x speakers | expand |
On 20/06/2025 12:30, Mohammad Rafi Shaik wrote: > On Qualcomm platforms, like QCS6490-RB3Gen2 and QCM6490-IDP, the > WSA884x speakers share SD_N GPIOs between two speakers, thus You copied everything from my commit 26c8a435fce6 ... even device name. Please don't blindly copy, but check what you are actually pasting. Best regards, Krzysztof
On 6/23/2025 1:33 PM, Krzysztof Kozlowski wrote: > On 20/06/2025 12:30, Mohammad Rafi Shaik wrote: >> On Qualcomm platforms, like QCS6490-RB3Gen2 and QCM6490-IDP, the >> WSA884x speakers share SD_N GPIOs between two speakers, thus > > You copied everything from my commit 26c8a435fce6 ... even device name. > Please don't blindly copy, but check what you are actually pasting. > Ack, Sorry about that Will take care and update the proper commit message. Thanks & Regards, Rafi. > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml index 14d312f9c345..098f1df62c8c 100644 --- a/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,wsa883x.yaml @@ -29,6 +29,10 @@ properties: description: GPIO spec for Powerdown/Shutdown line to use (pin SD_N) maxItems: 1 + reset-gpios: + description: Powerdown/Shutdown line to use (pin SD_N) + maxItems: 1 + vdd-supply: description: VDD Supply for the Codec @@ -50,10 +54,15 @@ required: - compatible - reg - vdd-supply - - powerdown-gpios - "#thermal-sensor-cells" - "#sound-dai-cells" +oneOf: + - required: + - powerdown-gpios + - required: + - reset-gpios + unevaluatedProperties: false examples:
On Qualcomm platforms, like QCS6490-RB3Gen2 and QCM6490-IDP, the WSA884x speakers share SD_N GPIOs between two speakers, thus a coordinated assertion is needed. Linux supports handling shared GPIO lines through "reset-gpios"property, thus allow specifying either powerdown or reset GPIOs (these are the same). Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com> --- .../devicetree/bindings/sound/qcom,wsa883x.yaml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)