From patchwork Fri May 19 11:02:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 684151 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64AAC77B7F for ; Fri, 19 May 2023 11:03:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231947AbjESLDk (ORCPT ); Fri, 19 May 2023 07:03:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231967AbjESLDe (ORCPT ); Fri, 19 May 2023 07:03:34 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38621987; Fri, 19 May 2023 04:03:03 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2af290cf9b7so870901fa.3; Fri, 19 May 2023 04:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684494180; x=1687086180; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sK2xLHjcRHLrAnodiL9Mcc2q7WIuVpBASOZhsxiKp2o=; b=bzrHSZustUkWunhpAmaCubObV3Vl6sxXAKkjy8GT3sbSBohJu6G5LcyeMXvRtAjdjx rmn4QrEb4YMfEyjpcyORajQmdpBbfV49BLyrD60hQ6RM9owJRCHaDMXifAjUpynxfOWI YtLdsWoUDt/YINJPKSd5TyNAl4xexJvlw2DfdeeRfMLovDHk5awMIkbOqouBE18ftQuJ /PyTtWQGCHvLtUWWJ+vL8kUKm8SjjIHWTymekaDOl4jAFbGgAFnEId61rdYFcNlGnd/8 xBU/hwdJ0/hYXu2zwaTL7qrf6OKxOA1873UUpnmnWLs/lxX5oMK3dgCliCM8f9OBDYZv 6YbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684494180; x=1687086180; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sK2xLHjcRHLrAnodiL9Mcc2q7WIuVpBASOZhsxiKp2o=; b=TUo8MZGNxuHo5hnmlSXLr3x2fbZrjlZM+O3dZ3UrFVVIt08UKd39Cw40ulM6xvrHjg aTB0jgIlm8hU1UKQeqnDf2YkjGgBeQh9BFpKAicjX3p5LO3GL/EB4vCsjsj6Sy7Kk9fx 72hPYWngJz6rqXCZQoxWY4DGctzmb4tUihjMUXcy8j7tOTOluRm0DhaOZ7Miz7aYF8NF lhKncV9N+ErCYQC614KE0FjGXofM/lBaz/S+kt683XCr8jZnl8Ho3I6Hj7C83JRpUwKM 9l1i3D270zhxX7NY14ycR9FCFadR8sDDWcM3nE0TTjdCUNbMquNaHpl8JMEqYq2WE5OJ 49Zw== X-Gm-Message-State: AC+VfDx/ZkR5uYjPx0CCyHU0At/Fe9oIuTq7zbBzlNkA0RWlh0tJYfAV RFOZsOkUKB2cCBr6i6zRauw= X-Google-Smtp-Source: ACHHUZ5chLqQVl/sJRSoXh8LQwArbENYGHlmyooCeukzCHPICy04tGwa9LnbVEMDxFXKYQejNic/uw== X-Received: by 2002:a2e:96cd:0:b0:2af:22a0:81ec with SMTP id d13-20020a2e96cd000000b002af22a081ecmr729672ljj.27.1684494180206; Fri, 19 May 2023 04:03:00 -0700 (PDT) Received: from fedora (62-78-225-252.bb.dnainternet.fi. [62.78.225.252]) by smtp.gmail.com with ESMTPSA id u22-20020a2e91d6000000b002a8c3ca2541sm776405ljg.121.2023.05.19.04.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 04:02:59 -0700 (PDT) Date: Fri, 19 May 2023 14:02:55 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v5 6/8] pinctrl: pistachio: relax return value check for IRQ get Message-ID: <5d74bdf2ef8738aec0b419392b8d0f38a1b0728b.1684493615.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org fwnode_irq_get[_byname]() were changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen Acked-by: Linus Walleij --- Please note, I took Linus' reply to v4 cover-letter as ack && added the tag. Please let me know if this was not Ok. The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/pinctrl/pinctrl-pistachio.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 53408344927a..8c50e0091b32 100644 --- a/drivers/pinctrl/pinctrl-pistachio.c +++ b/drivers/pinctrl/pinctrl-pistachio.c @@ -1393,12 +1393,6 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl) dev_err(pctl->dev, "Failed to retrieve IRQ for bank %u\n", i); goto err; } - if (!ret) { - fwnode_handle_put(child); - dev_err(pctl->dev, "No IRQ for bank %u\n", i); - ret = -EINVAL; - goto err; - } irq = ret; bank = &pctl->gpio_banks[i];