| Message ID | 20230317233338.424864-1-andi.shyti@kernel.org |
|---|---|
| Headers | show |
| Series | Add the clock stretching i2c property | expand |
> The DTS schema has been applied in commit c83dd2cb836e ("schemas: > i2c: Add the clock stretching property"). Everyone, A general remark: If bindings for the dtschema are added, please include the linux-i2c mailing list. This binding is OK, but it would be good to have the discussion also here for additional input.
Hi Wolfram, On Wed, Mar 29, 2023 at 09:06:43PM +0200, Wolfram Sang wrote: > > > The DTS schema has been applied in commit c83dd2cb836e ("schemas: > > i2c: Add the clock stretching property"). > > Everyone, A general remark: If bindings for the dtschema are added, > please include the linux-i2c mailing list. This binding is OK, but it > would be good to have the discussion also here for additional input. Thanks for letting me know. It's actually my mistake, as I didn't check how to properly distribute the patch to all relevant parties. Regarding dtschema patches, they are typically submitted as GitHub pull requests. How should I send it to the linux-i2c? Should I also send it to the mailing list like any other patch? (This might make the code review process somewhat confusing, though). Thanks, Andi
Hello, fter a discussion between Krzysztof and Ryan[1], it has become apparent that the i2c binding is lacking the definition of a property that needs to be added at a more generic level. This property is also used by the mpc i2c controller, which has been updated in the second patch. The DTS schema has been applied in commit c83dd2cb836e ("schemas: i2c: Add the clock stretching property"). Thanks Krzysztof, Chris and Rob for the reviews. Thank you, Andi [1] https://lore.kernel.org/all/c41ee6b5-ddb4-1253-de54-a295b3bab2cc@linaro.org/ Changelog ========= v4 -> v5: - Add the clock stretching i2c property - Added r-b from Rob Herring in Patch 1 and from Krzysztof in Patch 3. v3 -> v4: - Replaced "i2c-scl-clk-low-timeout-ms" with "i2c-scl-clk-low-timeout-us". Use microseconds instead of milliseconds. - Add tags from Chris. v2 -> v3: - Chris recommended to use of_property_read_u32() instead of of_get_property(). Because there were two use of it I added the suggested cleanup in a separate patch. v1 -> v2: - Removed the binding patch and send through a different channel - To ensure back compatibility, which was broken in v1, the legacy "fsl,timeout" has not been removed and marked as deprecated. In the driver the that property is checked anyway as a fallback in case the main i2c-scl-clk-low-timeout-ms is missing. Andi Shyti (3): dt-bindings: i2c: mpc: Mark "fsl,timeout" as deprecated i2c: mpc: Use of_property_read_u32 instead of of_get_property i2c: mpc: Use i2c-scl-clk-low-timeout-us i2c property .../devicetree/bindings/i2c/i2c-mpc.yaml | 3 +- drivers/i2c/busses/i2c-mpc.c | 35 ++++++++++++------- 2 files changed, 25 insertions(+), 13 deletions(-)