mbox series

[v8,0/6] Use CCP driver to handle PSP I2C arbitration

Message ID 20230403183216.3493-1-mario.limonciello@amd.com
Headers show
Series Use CCP driver to handle PSP I2C arbitration | expand

Message

Mario Limonciello April 3, 2023, 6:32 p.m. UTC
The CCP driver now has symbols that can be used by i2c-designware-amdpsp
to handle the communication regarding i2c arbitration with the PSP for
both Cezanne and Mendocino based designs.

Utilize those symbols.

v7->v8:
 * Pick up tags
 * Drop hunk for error message change
 * Fix kernel robot build failures

Mario Limonciello (6):
  crypto: ccp: Drop extra doorbell checks
  crypto: ccp: Bump up doorbell debug message to error
  crypto: ccp: Return doorbell status code as an argument
  crypto: ccp: Use lower 8 bytes to communicate with doorbell command
    register
  i2c: designware: Use PCI PSP driver for communication
  i2c: designware: Add doorbell support for Mendocino

 drivers/crypto/ccp/platform-access.c        |  31 +--
 drivers/i2c/busses/Kconfig                  |   5 +-
 drivers/i2c/busses/i2c-designware-amdpsp.c  | 197 +++++---------------
 drivers/i2c/busses/i2c-designware-core.h    |   1 -
 drivers/i2c/busses/i2c-designware-platdrv.c |   1 -
 include/linux/psp-platform-access.h         |   5 +-
 6 files changed, 62 insertions(+), 178 deletions(-)


base-commit: d6cb9ab4bfeaaa69147948e42d7cff080db82d07

Comments

Wolfram Sang April 6, 2023, 6:42 a.m. UTC | #1
On Mon, Apr 03, 2023 at 01:32:09PM -0500, Mario Limonciello wrote:
> The CCP driver now has symbols that can be used by i2c-designware-amdpsp
> to handle the communication regarding i2c arbitration with the PSP for
> both Cezanne and Mendocino based designs.

How should this go upstream, i.e. are there dependencies? Shall I pick
the I2C patches or is it better if all goes via the crypto tree?
Mario Limonciello April 6, 2023, 11:58 a.m. UTC | #2
On 4/6/23 01:42, Wolfram Sang wrote:
> On Mon, Apr 03, 2023 at 01:32:09PM -0500, Mario Limonciello wrote:
>> The CCP driver now has symbols that can be used by i2c-designware-amdpsp
>> to handle the communication regarding i2c arbitration with the PSP for
>> both Cezanne and Mendocino based designs.
> How should this go upstream, i.e. are there dependencies? Shall I pick
> the I2C patches or is it better if all goes via the crypto tree?
>
IMO it's better to go through the crypto tree.  There are dependencies
in the crypto part from the earlier series that was merged.
Wolfram Sang April 7, 2023, 6:18 a.m. UTC | #3
> > How should this go upstream, i.e. are there dependencies? Shall I pick
> > the I2C patches or is it better if all goes via the crypto tree?
> > 
> IMO it's better to go through the crypto tree.  There are dependencies
> in the crypto part from the earlier series that was merged.

Ok, fine with me. I acked the I2C patches. Thanks for the heads up.
Mario Limonciello April 12, 2023, 4:28 p.m. UTC | #4
On 4/7/2023 01:18, Wolfram Sang wrote:
> 
>>> How should this go upstream, i.e. are there dependencies? Shall I pick
>>> the I2C patches or is it better if all goes via the crypto tree?
>>>
>> IMO it's better to go through the crypto tree.  There are dependencies
>> in the crypto part from the earlier series that was merged.
> 
> Ok, fine with me. I acked the I2C patches. Thanks for the heads up.
> 

Herbert,

Would you mind to queue these up for -next?  I do have some other 
separate work I will be submitting that is going to layer on top of 
them, so I'd like to base it off your branch with these landed.
Herbert Xu April 14, 2023, 11:05 a.m. UTC | #5
On Mon, Apr 03, 2023 at 01:32:09PM -0500, Mario Limonciello wrote:
> The CCP driver now has symbols that can be used by i2c-designware-amdpsp
> to handle the communication regarding i2c arbitration with the PSP for
> both Cezanne and Mendocino based designs.
> 
> Utilize those symbols.
> 
> v7->v8:
>  * Pick up tags
>  * Drop hunk for error message change
>  * Fix kernel robot build failures
> 
> Mario Limonciello (6):
>   crypto: ccp: Drop extra doorbell checks
>   crypto: ccp: Bump up doorbell debug message to error
>   crypto: ccp: Return doorbell status code as an argument
>   crypto: ccp: Use lower 8 bytes to communicate with doorbell command
>     register
>   i2c: designware: Use PCI PSP driver for communication
>   i2c: designware: Add doorbell support for Mendocino
> 
>  drivers/crypto/ccp/platform-access.c        |  31 +--
>  drivers/i2c/busses/Kconfig                  |   5 +-
>  drivers/i2c/busses/i2c-designware-amdpsp.c  | 197 +++++---------------
>  drivers/i2c/busses/i2c-designware-core.h    |   1 -
>  drivers/i2c/busses/i2c-designware-platdrv.c |   1 -
>  include/linux/psp-platform-access.h         |   5 +-
>  6 files changed, 62 insertions(+), 178 deletions(-)
> 
> 
> base-commit: d6cb9ab4bfeaaa69147948e42d7cff080db82d07
> -- 
> 2.34.1

Patches 1-4 applied.  Thanks.