| Message ID | 20241216175044.4144442-1-ninad@linux.ibm.com |
|---|---|
| Headers | show |
| Series | Add support for Intel CRPS PSU | expand |
On 12/16/24 09:50, Ninad Palsule wrote: > Add INTEL Common Redundant Power Supply Versions crps185 bindings as > trivial. It is trivial because only compatibility string is required in > the device tree to load this driver. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> Krzysztof had Acked this patch. I don't immediately see why you dropped it. Am I missing something ? Guenter > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 73a49d50c4ef..7d07b08b1459 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -151,6 +151,8 @@ properties: > - injoinic,ip5306 > # Inspur Power System power supply unit version 1 > - inspur,ipsps1 > + # Intel common redudant power supply crps185 > + - intel,crps185 > # Intersil ISL29028 Ambient Light and Proximity Sensor > - isil,isl29028 > # Intersil ISL29030 Ambient Light and Proximity Sensor
Hi Guenter, Thanks for the review. On 12/16/24 12:48, Guenter Roeck wrote: > On 12/16/24 09:50, Ninad Palsule wrote: >> Hello, >> >> Please review the patchset for Intel CRPS185 driver. >> V2: >> --- >> - Incorporated review comments by Guenter Roeck >> - Incorporated review comments by Krzysztof Kozlowski >> > > That is not a useful change log. Please describe what you changed, not > who > asked for it. > > Guenter > ok, I will improve it in version 3. Regards, Ninad >> Ninad Palsule (4): >> hwmon: (pmbus/core) Add PMBUS_REVISION in debugfs >> hwmon: (pmbus/crps) Add Intel CRPS185 power supply >> dt-bindings: hwmon: intel,crps185: Add to trivial >> ARM: dts: aspeed: system1: Use crps PSU driver >> >> .../devicetree/bindings/trivial-devices.yaml | 2 + >> Documentation/hwmon/crps.rst | 97 +++++++++++++++++++ >> Documentation/hwmon/index.rst | 1 + >> MAINTAINERS | 7 ++ >> .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 8 +- >> drivers/hwmon/pmbus/Kconfig | 9 ++ >> drivers/hwmon/pmbus/Makefile | 1 + >> drivers/hwmon/pmbus/crps.c | 79 +++++++++++++++ >> drivers/hwmon/pmbus/pmbus_core.c | 13 ++- >> 9 files changed, 211 insertions(+), 6 deletions(-) >> create mode 100644 Documentation/hwmon/crps.rst >> create mode 100644 drivers/hwmon/pmbus/crps.c >> > >
Hi Guenter, Thanks for the review. On 12/16/24 12:47, Guenter Roeck wrote: > On 12/16/24 09:50, Ninad Palsule wrote: >> Add INTEL Common Redundant Power Supply Versions crps185 bindings as >> trivial. It is trivial because only compatibility string is required in >> the device tree to load this driver. >> >> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > > Krzysztof had Acked this patch. I don't immediately see why you > dropped it. > Am I missing something ? > > Guenter > I think that was my mistake. Adding it in version 3. >> --- >> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml >> b/Documentation/devicetree/bindings/trivial-devices.yaml >> index 73a49d50c4ef..7d07b08b1459 100644 >> --- a/Documentation/devicetree/bindings/trivial-devices.yaml >> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml >> @@ -151,6 +151,8 @@ properties: >> - injoinic,ip5306 >> # Inspur Power System power supply unit version 1 >> - inspur,ipsps1 >> + # Intel common redudant power supply crps185 >> + - intel,crps185 >> # Intersil ISL29028 Ambient Light and Proximity Sensor >> - isil,isl29028 >> # Intersil ISL29030 Ambient Light and Proximity Sensor > >