mbox series

[v4,0/8] i2c: add zhaoxin i2c controller driver

Message ID cover.1703647471.git.hanshu-oc@zhaoxin.com
Headers show
Series i2c: add zhaoxin i2c controller driver | expand

Message

Hans Hu Dec. 27, 2023, 4:39 a.m. UTC 
In version v4, the patch consists of 8 files. 
This version is based on the latest for-next branch,
with some adjustments as suggested by Wolfram.

Hans Hu (8):
  i2c: wmt: create wmt_i2c_init for general init
  i2c: wmt: rename marcos with prefix WMTI2C_
  i2c: wmt: adjust line length to meet style
  i2c: wmt: split out common files
  i2c: wmt: rename with prefix VIAI2C_ and viai2c_
  i2c: wmt: fix a bug when thread blocked
  i2c: wmt: add platform type VIAI2C_PLAT_WMT
  i2c: add zhaoxin i2c controller driver

 MAINTAINERS                            |   8 +
 drivers/i2c/busses/Kconfig             |  10 +
 drivers/i2c/busses/Makefile            |   4 +
 drivers/i2c/busses/i2c-viai2c-common.c | 278 +++++++++++++++++
 drivers/i2c/busses/i2c-viai2c-common.h |  79 +++++
 drivers/i2c/busses/i2c-wmt-plt.c       | 139 +++++++++
 drivers/i2c/busses/i2c-wmt.c           | 417 -------------------------
 drivers/i2c/busses/i2c-zhaoxin-plt.c   | 299 ++++++++++++++++++
 8 files changed, 817 insertions(+), 417 deletions(-)
 create mode 100644 drivers/i2c/busses/i2c-viai2c-common.c
 create mode 100644 drivers/i2c/busses/i2c-viai2c-common.h
 create mode 100644 drivers/i2c/busses/i2c-wmt-plt.c
 delete mode 100644 drivers/i2c/busses/i2c-wmt.c
 create mode 100644 drivers/i2c/busses/i2c-zhaoxin-plt.c

Comments

Wolfram Sang Dec. 27, 2023, 7 p.m. UTC | #1 
On Wed, Dec 27, 2023 at 12:39:44PM +0800, Hans Hu wrote:
> Some common initialization actions are put in the function
> wmt_i2c_init(), which is convenient to share with zhaoxin.
> 
> Signed-off-by: Hans Hu <hanshu-oc@zhaoxin.com>

I get a build error:

  CC      drivers/i2c/busses/i2c-wmt.o
drivers/i2c/busses/i2c-wmt.c:289:5: error: no previous prototype for ‘wmt_i2c_init’ [-Werror=missing-prototypes]
  289 | int wmt_i2c_init(struct platform_device *pdev, struct wmt_i2c_dev **pi2c_dev)
      |     ^~~~~~~~~~~~
Hans Hu Dec. 28, 2023, 2:05 a.m. UTC | #2 
On 2023/12/28 03:00, Wolfram Sang wrote:
> On Wed, Dec 27, 2023 at 12:39:44PM +0800, Hans Hu wrote:
>> Some common initialization actions are put in the function
>> wmt_i2c_init(), which is convenient to share with zhaoxin.
>>
>> Signed-off-by: Hans Hu <hanshu-oc@zhaoxin.com>
> I get a build error:
>
>    CC      drivers/i2c/busses/i2c-wmt.o
> drivers/i2c/busses/i2c-wmt.c:289:5: error: no previous prototype for ‘wmt_i2c_init’ [-Werror=missing-prototypes]
>    289 | int wmt_i2c_init(struct platform_device *pdev, struct wmt_i2c_dev **pi2c_dev)
>        |     ^~~~~~~~~~~~


Sorry, I only checked after the last V4 patch using sparse/cocci/smatch. 
Fixed V5 will be re-sent within an hour.