@@ -684,19 +684,19 @@ static int __maybe_unused tegra_i2c_runtime_resume(struct device *dev)
return ret;
ret = clk_enable(i2c_dev->fast_clk);
- if (ret < 0) {
+ if (ret) {
dev_err(dev, "failed to enable fast clock: %d\n", ret);
return ret;
}
ret = clk_enable(i2c_dev->slow_clk);
- if (ret < 0) {
+ if (ret) {
dev_err(dev, "failed to enable slow clock: %d\n", ret);
goto disable_fast_clk;
}
ret = clk_enable(i2c_dev->div_clk);
- if (ret < 0) {
+ if (ret) {
dev_err(dev, "failed to enable div clock: %d\n", ret);
goto disable_slow_clk;
}
@@ -1057,7 +1057,7 @@ static void tegra_i2c_config_fifo_trig(struct tegra_i2c_dev *i2c_dev,
slv_config.device_fc = true;
ret = dmaengine_slave_config(chan, &slv_config);
- if (ret < 0) {
+ if (ret) {
dev_err(i2c_dev->dev, "DMA config failed: %d\n", ret);
dev_err(i2c_dev->dev, "falling back to PIO\n");
tegra_i2c_release_dma(i2c_dev);
@@ -1245,7 +1245,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
xfer_size,
DMA_FROM_DEVICE);
err = tegra_i2c_dma_submit(i2c_dev, xfer_size);
- if (err < 0) {
+ if (err) {
dev_err(i2c_dev->dev,
"starting RX DMA failed: %d\n", err);
return err;
@@ -1304,7 +1304,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev,
xfer_size,
DMA_TO_DEVICE);
err = tegra_i2c_dma_submit(i2c_dev, xfer_size);
- if (err < 0) {
+ if (err) {
dev_err(i2c_dev->dev,
"starting TX DMA failed: %d\n", err);
return err;
The driver's code is inconsistent in regards to the error values checking. The correct way should be to check both positive and negative values. This patch cleans up the error-checks in the code. Note that the pm_runtime_get_sync() could return positive value on success, hence only relevant parts of the code are changed by this patch. Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- drivers/i2c/busses/i2c-tegra.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)