diff mbox series

[v4,3/4] dt-bindings: i2c: imx: Add properties and use unevaluatedProperties

Message ID 20200917191321.28741-3-krzk@kernel.org
State Accepted
Commit 37859693f83f9325559d8ec980310b3a13fa5924
Headers show
Series None | expand

Commit Message

Krzysztof Kozlowski Sept. 17, 2020, 7:13 p.m. UTC
Additional properties actually might appear (e.g. power-domains) so
describe all typical properties, reference generic i2c schema and use
unevaluatedProperties to fix dtbs_check warnings like:

  arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:
    '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v3:
1. Drop address/size cells

Changes since v2:
1. None

Changes since v1:
1. Add more properties and include /schemas/i2c/i2c-controller.yaml#
---
 Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) Sept. 23, 2020, 8:25 p.m. UTC | #1
On Thu, 17 Sep 2020 21:13:20 +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. power-domains) so

> describe all typical properties, reference generic i2c schema and use

> unevaluatedProperties to fix dtbs_check warnings like:

> 

>   arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:

>     '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'

> 

> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

> 

> ---

> 

> Changes since v3:

> 1. Drop address/size cells

> 

> Changes since v2:

> 1. None

> 

> Changes since v1:

> 1. Add more properties and include /schemas/i2c/i2c-controller.yaml#

> ---

>  Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 5 ++++-

>  1 file changed, 4 insertions(+), 1 deletion(-)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Wolfram Sang Sept. 27, 2020, 6:02 p.m. UTC | #2
On Thu, Sep 17, 2020 at 09:13:20PM +0200, Krzysztof Kozlowski wrote:
> Additional properties actually might appear (e.g. power-domains) so
> describe all typical properties, reference generic i2c schema and use
> unevaluatedProperties to fix dtbs_check warnings like:
> 
>   arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000:
>     '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 

Applied to for-next, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
index 810536953177..a0c87307ca07 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-imx.yaml
@@ -9,6 +9,9 @@  title: Freescale Inter IC (I2C) and High Speed Inter IC (HS-I2C) for i.MX
 maintainers:
   - Wolfram Sang <wolfram@the-dreams.de>
 
+allOf:
+  - $ref: /schemas/i2c/i2c-controller.yaml#
+
 properties:
   compatible:
     oneOf:
@@ -75,7 +78,7 @@  required:
   - interrupts
   - clocks
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |