| Message ID | 20210520190105.3772683-2-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 72ab7b6bb1a60bfc7baba1864fa28383dab4f862 |
| Headers | show |
| Series | Rid W=1 warnings from I2C | expand |
On Thu, May 20, 2021 at 9:01 PM Lee Jones <lee.jones@linaro.org> wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/busses/i2c-nomadik.c:184: warning: Function parameter or member 'timeout' not described in 'nmk_i2c_dev' > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com> > Cc: Sachin Verma <sachin.verma@st.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
On Thu, May 20, 2021 at 08:00:50PM +0100, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/i2c/busses/i2c-nomadik.c:184: warning: Function parameter or member 'timeout' not described in 'nmk_i2c_dev' > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com> > Cc: Sachin Verma <sachin.verma@st.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-i2c@vger.kernel.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied to for-current, thanks!
On Thu, 27 May 2021, Wolfram Sang wrote: > On Thu, May 20, 2021 at 08:00:50PM +0100, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/i2c/busses/i2c-nomadik.c:184: warning: Function parameter or member 'timeout' not described in 'nmk_i2c_dev' > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com> > > Cc: Sachin Verma <sachin.verma@st.com> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-i2c@vger.kernel.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Applied to for-current, thanks! Thanks for these buddy. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
> > Applied to for-current, thanks! > > Thanks for these buddy. You're welcome. The rest will also land in 5.13, but I want to give the driver maintainers one week more time.
On Fri, 28 May 2021, Wolfram Sang wrote: > > > > Applied to for-current, thanks! > > > > Thanks for these buddy. > > You're welcome. The rest will also land in 5.13, but I want to give the > driver maintainers one week more time. Understood. There is no rush from my side. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c index dc77e1c4e80f9..a2d12a5b1c34c 100644 --- a/drivers/i2c/busses/i2c-nomadik.c +++ b/drivers/i2c/busses/i2c-nomadik.c @@ -159,7 +159,7 @@ struct i2c_nmk_client { * @clk_freq: clock frequency for the operation mode * @tft: Tx FIFO Threshold in bytes * @rft: Rx FIFO Threshold in bytes - * @timeout Slave response timeout (ms) + * @timeout: Slave response timeout (ms) * @sm: speed mode * @stop: stop condition. * @xfer_complete: acknowledge completion for a I2C message.
Fixes the following W=1 kernel build warning(s): drivers/i2c/busses/i2c-nomadik.c:184: warning: Function parameter or member 'timeout' not described in 'nmk_i2c_dev' Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Srinidhi Kasagar <srinidhi.kasagar@stericsson.com> Cc: Sachin Verma <sachin.verma@st.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-i2c@vger.kernel.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/i2c/busses/i2c-nomadik.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.31.1