From patchwork Mon Jun 20 10:54:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alain Volmat X-Patchwork-Id: 583498 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7768C43334 for ; Mon, 20 Jun 2022 10:56:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240153AbiFTK4n (ORCPT ); Mon, 20 Jun 2022 06:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231657AbiFTK4m (ORCPT ); Mon, 20 Jun 2022 06:56:42 -0400 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 202D4140E1; Mon, 20 Jun 2022 03:56:40 -0700 (PDT) Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25K9Do45018607; Mon, 20 Jun 2022 12:56:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=selector1; bh=/27zQWoEehvonrwk1M+eautT9fqPRtVSLLEq3FnQ5SQ=; b=c/h1IZEwCONGsD/qmUWVYx6Hko9r5a+FlBhl0Ijr+bFygQgyU+xCzx8kbrpJ2ukOKfCw Cgm+uEHqh/m+p7uq2NsWjc3Wsip3Y9gCh62KOJyBgZnQG5DO519PglEApSzr8dtqZBTa 8qi5vkPRCfbMQM4dm0auhSCmOTbFDDrxWiXOTw0gNLUnc4coO6qB1mhIGma0RnQKCtJa V9tDhSzzj0b9U9Jyl8di30nIFJveM8iM946sILwERtGfScW+8wtwdAKwHp4VoKi+G5iK HRysClq9Y+jOLZNDqH3IZClpt49y/x62HV7JVUTObZw83J0UYpnZ5oxjctVYtn9rHSSP Lg== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3gtp31rmrb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Jun 2022 12:56:18 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id B85DA100038; Mon, 20 Jun 2022 12:56:16 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id B3B3D21D380; Mon, 20 Jun 2022 12:56:16 +0200 (CEST) Received: from localhost (10.75.127.51) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2308.20; Mon, 20 Jun 2022 12:56:16 +0200 From: Alain Volmat To: , CC: , , , , , , , , , , , Subject: [PATCH 2/4] i2c: stm32: only perform a reset if there is a reset property Date: Mon, 20 Jun 2022 12:54:03 +0200 Message-ID: <20220620105405.145959-3-alain.volmat@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220620105405.145959-1-alain.volmat@foss.st.com> References: <20220620105405.145959-1-alain.volmat@foss.st.com> MIME-Version: 1.0 X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-06-20_05,2022-06-17_01,2022-02-23_01 Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org Allow the driver to properly initialize even if there is no reset property given. In such case reset control is not done and initialization proceed. Signed-off-by: Alain Volmat Reviewed-by: Pierre-Yves MORDRET --- drivers/i2c/busses/i2c-stm32f7.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c index 6d4aa64b195d..b29d8e476342 100644 --- a/drivers/i2c/busses/i2c-stm32f7.c +++ b/drivers/i2c/busses/i2c-stm32f7.c @@ -2138,13 +2138,14 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) rst = devm_reset_control_get(&pdev->dev, NULL); if (IS_ERR(rst)) { - ret = dev_err_probe(&pdev->dev, PTR_ERR(rst), - "Error: Missing reset ctrl\n"); - goto clk_free; + ret = PTR_ERR(rst); + if (ret == -EPROBE_DEFER) + goto clk_free; + } else { + reset_control_assert(rst); + udelay(2); + reset_control_deassert(rst); } - reset_control_assert(rst); - udelay(2); - reset_control_deassert(rst); i2c_dev->dev = &pdev->dev;