From patchwork Thu Apr 10 20:02:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mario Limonciello X-Patchwork-Id: 880383 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B78E290BC2; Thu, 10 Apr 2025 20:02:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744315345; cv=none; b=L41fyG9VzlHop4KgYw16dQ9dRtSaoojM5RsJnH3VFGJ8GQWZ/0uJPbxoLpFyTgZ2OdCTz5bEjeCfOoaJDL57gZ75P+W1dCLavrMEnwnUTnFZiGPyH++ABcv23FUUT8G7/+s1wd2UkyqFGYUUpK9Pk5dbqBnxrJCzav9VH7zKopY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744315345; c=relaxed/simple; bh=w/RU2A4df4biQl18BgwTSbH3JxoDffUQCgnJgrJx7gQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bAUHW036em/sROZwQ27eFY3LSu1nBHAjnOaR6FEj/132knN4o9SHPwSfPvNslYa1XNeG0LZ24OfK/TYytjcIEjqiXBi877+MjK0CQdqNeEy6yTjzVHzGy9DW8FS1EvGInX/zaakzRCt3qBLAV3uL2vZxSNnw1IV7omu2wHCdipQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u41KXSbx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u41KXSbx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32300C4CEF0; Thu, 10 Apr 2025 20:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744315344; bh=w/RU2A4df4biQl18BgwTSbH3JxoDffUQCgnJgrJx7gQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=u41KXSbxzySGPgWWMEoPvJYRRYjoqHM/CWspk3nBt1++CsW3vOdNM3D/UKeEwWJnM K5btupqvestckKK3A8D41pEBnANFWNDLIlyJhlvZPoPGEslJF1w8jU35mJG3J1FmwE MeIztEmilf3Gaz95pSvwBFD23rlH0X1NHEpmG5a/6yGvI1KwTaFvTht9p2DtXIvTDt xfI+P+4JlxKblXSfpgMoWwA8sxNcAJ5sr5GNsW1v2hGjwdu9zE47/hWVQd5/OPsZ/h TOnoqCJPcxTosq1X8j+NEWgQ5edov7ZBraXA6A2+lJUYpWobxrvivIc11pM0Oe7cB8 leUwmVyO2qXnQ== From: Mario Limonciello To: Borislav Petkov , Jean Delvare , Andi Shyti , =?utf-8?q?Ilpo_J=C3=A4rvinen?= Cc: Jonathan Corbet , Mario Limonciello , Yazen Ghannam , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)), "H . Peter Anvin" , Shyam Sundar S K , Hans de Goede , linux-doc@vger.kernel.org (open list:DOCUMENTATION), linux-kernel@vger.kernel.org (open list), linux-i2c@vger.kernel.org (open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC), platform-driver-x86@vger.kernel.org (open list:AMD PMC DRIVER) Subject: [PATCH v3 3/4] platform/x86/amd: pmc: use FCH_PM_BASE definition Date: Thu, 10 Apr 2025 15:02:01 -0500 Message-ID: <20250410200202.2974062-4-superm1@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250410200202.2974062-1-superm1@kernel.org> References: <20250410200202.2974062-1-superm1@kernel.org> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Mario Limonciello The s2idle mmio quirk uses a scratch register in the FCH. Adjust the code to clarify that. Signed-off-by: Mario Limonciello --- drivers/platform/x86/amd/pmc/pmc-quirks.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c index b4f49720c87f6..9d817209e407f 100644 --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c @@ -8,19 +8,22 @@ * Author: Mario Limonciello */ +#include #include #include #include #include "pmc.h" +#define FCH_PM_SCRATCH 0x80 + struct quirk_entry { u32 s2idle_bug_mmio; bool spurious_8042; }; static struct quirk_entry quirk_s2idle_bug = { - .s2idle_bug_mmio = 0xfed80380, + .s2idle_bug_mmio = FCH_PM_BASE + FCH_PM_SCRATCH, }; static struct quirk_entry quirk_spurious_8042 = {