| Message ID | 20250603153022.39434-1-akhilrajeev@nvidia.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v4,1/3] dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties | expand |
On 03/06/2025 17:30, Akhil R wrote: > Specify the properties which are essential and which are not for the > Tegra I2C driver to function correctly. This was not added correctly when > the TXT binding was converted to yaml. All the existing DT nodes have > these properties already and hence this does not break the ABI. > > dmas and dma-names which were specified as a must in the TXT binding > is now made optional since the driver can work in PIO mode if dmas are > missing. > > Fixes: f10a9b722f80 ("dt-bindings: i2c: tegra: Convert to json-schema”) > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
>> Specify the properties which are essential and which are not for the >> Tegra I2C driver to function correctly. This was not added correctly when >> the TXT binding was converted to yaml. All the existing DT nodes have >> these properties already and hence this does not break the ABI. >> >> dmas and dma-names which were specified as a must in the TXT binding >> is now made optional since the driver can work in PIO mode if dmas are >> missing. >> >> Fixes: f10a9b722f80 ("dt-bindings: i2c: tegra: Convert to json-schema”) >> Signed-off-by: Akhil R <akhilrajeev@nvidia.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Thanks Krzysztof for the review. Hi Andi and Wolfram, Could you share if you see any more concerns with these patches? Regards, Akhil
On 09/06/2025 11:02, Akhil R wrote: >>> Specify the properties which are essential and which are not for the >>> Tegra I2C driver to function correctly. This was not added correctly when >>> the TXT binding was converted to yaml. All the existing DT nodes have >>> these properties already and hence this does not break the ABI. >>> >>> dmas and dma-names which were specified as a must in the TXT binding >>> is now made optional since the driver can work in PIO mode if dmas are >>> missing. >>> >>> Fixes: f10a9b722f80 ("dt-bindings: i2c: tegra: Convert to json-schema”) >>> Signed-off-by: Akhil R <akhilrajeev@nvidia.com> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Thanks Krzysztof for the review. > > Hi Andi and Wolfram, > > Could you share if you see any more concerns with these patches? You sent it during merge window and a week later you ping? Considering the quiet time, you sent it basically yesterday, so you gave people only 1 day... Don't ping after one day. Two weeks. Best regards, Krzysztof
Hi Akhil, On Tue, Jun 03, 2025 at 09:00:20PM +0530, Akhil R wrote: > Specify the properties which are essential and which are not for the > Tegra I2C driver to function correctly. This was not added correctly when > the TXT binding was converted to yaml. All the existing DT nodes have > these properties already and hence this does not break the ABI. > > dmas and dma-names which were specified as a must in the TXT binding > is now made optional since the driver can work in PIO mode if dmas are > missing. > > Fixes: f10a9b722f80 ("dt-bindings: i2c: tegra: Convert to json-schema”) > Signed-off-by: Akhil R <akhilrajeev@nvidia.com> I took just this patch into i2c/i2c-host-fixes. Thanks, Andi
diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml index b57ae6963e62..10f30d6a1fad 100644 --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml @@ -97,7 +97,10 @@ properties: resets: items: - - description: module reset + - description: + Module reset. This property is optional for controllers in Tegra194, + Tegra234 etc where an internal software reset is available as an + alternative. reset-names: items: @@ -116,6 +119,13 @@ properties: - const: rx - const: tx +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + allOf: - $ref: /schemas/i2c/i2c-controller.yaml - if: @@ -169,6 +179,18 @@ allOf: properties: power-domains: false + - if: + not: + properties: + compatible: + contains: + enum: + - nvidia,tegra194-i2c + then: + required: + - resets + - reset-names + unevaluatedProperties: false examples:
Specify the properties which are essential and which are not for the Tegra I2C driver to function correctly. This was not added correctly when the TXT binding was converted to yaml. All the existing DT nodes have these properties already and hence this does not break the ABI. dmas and dma-names which were specified as a must in the TXT binding is now made optional since the driver can work in PIO mode if dmas are missing. Fixes: f10a9b722f80 ("dt-bindings: i2c: tegra: Convert to json-schema”) Signed-off-by: Akhil R <akhilrajeev@nvidia.com> --- v3->v4: * Updated commit message, and "description" section. v2->v3: * Updated commit description on the details and fixed indentation issue. v1->v2: * Added all required properties .../bindings/i2c/nvidia,tegra20-i2c.yaml | 24 ++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)