mbox series

[v6,0/5] Input: joystick: xpad: Add X-Box Adaptive Controller support

Message ID 20220908173930.28940-1-nate@yocom.org
Headers show
Series Input: joystick: xpad: Add X-Box Adaptive Controller support | expand

Message

Nate Yocom Sept. 8, 2022, 5:39 p.m. UTC
Adds support for the X-Box Adaptive Controller, which is protocol
compatible with the XTYPE_XBOXONE support in the driver with two deltas:

 - The X-Box button sets 0x02 as its activation ID, where others set
   0x01
 - The controller has an additional Profile button with 4 active states,
   which this change maps to an Axis control with 4 possible values

Patch series adds device to the supported table, adds support for the
Profile button, and adds support for the X-Box button as distinct
changes.

Signed-off-by: Nate Yocom <nate@yocom.org>

Nate Yocom (5):
  Input: joystick: xpad: Add X-Box Adaptive support
  Input: joystick: xpad: Add X-Box Adaptive XBox button
  Input: joystick: xpad: Add ABS_PROFILE to uapi
  Input: joystick: xpad: Add ABS_PROFILE to Docs
  Input: joystick: xpad: Add X-Box Adaptive Profile button

 v2: Fix warning Reported-by: kernel test robot <lkp@intel.com>
 v3: Break into multi-part and remove VID/PID check for XBox button
 v4: Rename Layer -> Profile as suggested by Bastien Nocera
 v5: Add new ABS_PROFILE axis to uapi and use it for the profile button
 v6: Add ABS_PROFILE to absolutes array and docs as requested by Dmitry

 Documentation/input/event-codes.rst    |  6 ++++++
 Documentation/input/gamepad.rst        |  6 ++++++
 drivers/hid/hid-debug.c                |  3 ++-
 drivers/input/joystick/xpad.c          | 15 ++++++++++++++-
 include/uapi/linux/input-event-codes.h |  1 +
 5 files changed, 29 insertions(+), 2 deletions(-)


base-commit: 26b1224903b3fb66e8aa564868d0d57648c32b15

Comments

Nate Yocom Sept. 13, 2022, 9:46 p.m. UTC | #1
On Thu, Sep 08, 2022 at 10:39:25AM -0700, Nate Yocom wrote:
> Adds support for the X-Box Adaptive Controller, which is protocol
> compatible with the XTYPE_XBOXONE support in the driver with two deltas:
>
>  - The X-Box button sets 0x02 as its activation ID, where others set
>    0x01
>  - The controller has an additional Profile button with 4 active states,
>    which this change maps to an Axis control with 4 possible values
>
> Patch series adds device to the supported table, adds support for the
> Profile button, and adds support for the X-Box button as distinct
> changes.
>
> Signed-off-by: Nate Yocom <nate@yocom.org>
>
> Nate Yocom (5):
>   Input: joystick: xpad: Add X-Box Adaptive support
>   Input: joystick: xpad: Add X-Box Adaptive XBox button
>   Input: joystick: xpad: Add ABS_PROFILE to uapi
>   Input: joystick: xpad: Add ABS_PROFILE to Docs
>   Input: joystick: xpad: Add X-Box Adaptive Profile button
>
>  v2: Fix warning Reported-by: kernel test robot <lkp@intel.com>
>  v3: Break into multi-part and remove VID/PID check for XBox button
>  v4: Rename Layer -> Profile as suggested by Bastien Nocera
>  v5: Add new ABS_PROFILE axis to uapi and use it for the profile button
>  v6: Add ABS_PROFILE to absolutes array and docs as requested by Dmitry
>
>  Documentation/input/event-codes.rst    |  6 ++++++
>  Documentation/input/gamepad.rst        |  6 ++++++
>  drivers/hid/hid-debug.c                |  3 ++-
>  drivers/input/joystick/xpad.c          | 15 ++++++++++++++-
>  include/uapi/linux/input-event-codes.h |  1 +
>  5 files changed, 29 insertions(+), 2 deletions(-)
>
>
> base-commit: 26b1224903b3fb66e8aa564868d0d57648c32b15
> --
> 2.30.2
>

Dmitry et al, anything else I can do to see this through?  Thanks!

- Nate
Nate Yocom Sept. 28, 2022, 2:36 a.m. UTC | #2
> On Sep 13, 2022, at 3:46 PM, Nate Yocom <nate@yocom.org> wrote:
> 
> On Thu, Sep 08, 2022 at 10:39:25AM -0700, Nate Yocom wrote:
>> Adds support for the X-Box Adaptive Controller, which is protocol
>> compatible with the XTYPE_XBOXONE support in the driver with two deltas:
>> 
>> - The X-Box button sets 0x02 as its activation ID, where others set
>>   0x01
>> - The controller has an additional Profile button with 4 active states,
>>   which this change maps to an Axis control with 4 possible values
>> 
>> Patch series adds device to the supported table, adds support for the
>> Profile button, and adds support for the X-Box button as distinct
>> changes.
>> 
>> Signed-off-by: Nate Yocom <nate@yocom.org>
>> 
>> Nate Yocom (5):
>>  Input: joystick: xpad: Add X-Box Adaptive support
>>  Input: joystick: xpad: Add X-Box Adaptive XBox button
>>  Input: joystick: xpad: Add ABS_PROFILE to uapi
>>  Input: joystick: xpad: Add ABS_PROFILE to Docs
>>  Input: joystick: xpad: Add X-Box Adaptive Profile button
>> 
>> v2: Fix warning Reported-by: kernel test robot <lkp@intel.com>
>> v3: Break into multi-part and remove VID/PID check for XBox button
>> v4: Rename Layer -> Profile as suggested by Bastien Nocera
>> v5: Add new ABS_PROFILE axis to uapi and use it for the profile button
>> v6: Add ABS_PROFILE to absolutes array and docs as requested by Dmitry
>> 
>> Documentation/input/event-codes.rst    |  6 ++++++
>> Documentation/input/gamepad.rst        |  6 ++++++
>> drivers/hid/hid-debug.c                |  3 ++-
>> drivers/input/joystick/xpad.c          | 15 ++++++++++++++-
>> include/uapi/linux/input-event-codes.h |  1 +
>> 5 files changed, 29 insertions(+), 2 deletions(-)
>> 
>> 
>> base-commit: 26b1224903b3fb66e8aa564868d0d57648c32b15
>> --
>> 2.30.2
>> 
> 
> Dmitry et al, anything else I can do to see this through?  Thanks!

Anything missing here? Any chance of getting this in?
Dmitry Torokhov Sept. 29, 2022, 1:34 a.m. UTC | #3
On Thu, Sep 08, 2022 at 10:39:25AM -0700, Nate Yocom wrote:
> Adds support for the X-Box Adaptive Controller, which is protocol
> compatible with the XTYPE_XBOXONE support in the driver with two deltas:
> 
>  - The X-Box button sets 0x02 as its activation ID, where others set
>    0x01
>  - The controller has an additional Profile button with 4 active states,
>    which this change maps to an Axis control with 4 possible values
> 
> Patch series adds device to the supported table, adds support for the
> Profile button, and adds support for the X-Box button as distinct
> changes.
> 
> Signed-off-by: Nate Yocom <nate@yocom.org>
> 
> Nate Yocom (5):
>   Input: joystick: xpad: Add X-Box Adaptive support
>   Input: joystick: xpad: Add X-Box Adaptive XBox button
>   Input: joystick: xpad: Add ABS_PROFILE to uapi
>   Input: joystick: xpad: Add ABS_PROFILE to Docs
>   Input: joystick: xpad: Add X-Box Adaptive Profile button

Combined patches 3 and 4 and applied the lot, thank you.