From patchwork Thu Mar 13 16:02:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Rameshbabu X-Patchwork-Id: 873262 Received: from mail-10629.protonmail.ch (mail-10629.protonmail.ch [79.135.106.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57991268C48 for ; Thu, 13 Mar 2025 16:02:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=79.135.106.29 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741881780; cv=none; b=N/H+Zmb/xidSXm0n1NbgcLeal8lPY12x++k9QQ1WR/8/yW3ww7G+Em+Y65FcOi92NG7CgHoI2/Eb6Tj6Lpzc9QQuBOKIw+nk9zbtyFjZ6dpkaBN14aCOT15UWODiEt3fIfpkoHNY0T6yrVz5G0TKXay630V7uij286H8NmpH9w8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741881780; c=relaxed/simple; bh=3MxODXhUyDWZ/m6JfPXzUJhXPAMmYaBGPrDeg7AXWGs=; h=Date:To:From:Cc:Subject:Message-ID:MIME-Version:Content-Type; b=MFMA77JqFKO3b7xYkZHGpOCSYeL1M38BIb/fRlKXPtNWtTBralSHG77V4chxR9JYbYq9Km4XOU3x2Qn4CDd5xmxHZk3xBR1BGeEXDexGMTaUp9yE+ICeFFR3cT4UjmfWWoWJKS1HqzaNGwm99giSLiaGJ9mcurJwEt7pl6FFN7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=PaAlGdPr; arc=none smtp.client-ip=79.135.106.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="PaAlGdPr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1741881769; x=1742140969; bh=BQ4wJAhy2dpyN+MuSRLCyVk3VO5GKkBoc4sLhOsLk04=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector: List-Unsubscribe:List-Unsubscribe-Post; b=PaAlGdPrUf+jO4kxjZ9r/b4CZUlb/UQh4hV1S0yyF0gUCa35LP7a8l0Gu1ge7NIxb wE1Z4RQfH7jTDB1OcwTPSGX7y7jB1aCAtiFcBl/vuAheunyDuhuwDPE8ILJ2sXH6/2 Bzc8puAaD16tm+/IBqdS4oq4Qv7i01P0X5//93ZrQ1cS0aOFHGFLhL4v5KrmOnMOPW yErOquFahSGV+y98+WsoGciOjkEkSOEWduxCqrqJVjR6/TM7dMy/G4dx57xtbeh2Ez TVzNHcgsyLOEqUsNJbbi0oyQAQ2m0pNoF/wCBAcw4E7SIR+VMpSski8ea+igP2cZri HIfmjBbnHUsTg== Date: Thu, 13 Mar 2025 16:02:45 +0000 To: linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-input@vger.kernel.org, dri-devel@lists.freedesktop.org From: Rahul Rameshbabu Cc: Jiri Kosina , Benjamin Tissoires , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?B?= =?utf-8?q?j=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rahul Rameshbabu Subject: [PATCH RFC 0/3] Initial work for Rust abstraction for HID device driver development Message-ID: <20250313160220.6410-2-sergeantsagara@protonmail.com> Feedback-ID: 26003777:user:proton X-Pm-Message-ID: 7b970764ee6dc7211652295f774311d67daa40a7 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hello, I am a hobbyist developer who has been working on a project to create a new Rust HID device driver and the needed core abstractions for writing more HID device drivers in Rust. My goal is to support the USB Monitor Control Class needed for functionality such as backlight control for monitors like the Apple Studio Display and Apple Pro Display XDR. A new backlight API will be required to support multiple backlight instances and will be mapped per DRM connector. The current backlight API is designed around the assumption of only a single internal panel being present. I am currently working on making this new API for DRM in parallel to my work on the HID side of the stack for supporting these displays. https://binary-eater.github.io/tags/usb-monitor-control/ Julius Zint had attempted to do so a year ago with a C HID driver but was gated by the lack of an appropriate backlight API for external displays. I asked him for permission to do the work need in Rust and plan to accredit him for the HID report handling for backlight in the USB Monitor Control Class standard. https://lore.kernel.org/lkml/f95da7ff-06dd-2c0e-d563-7e5ad61c3bcc@redhat.com/ I was hoping to get initial feedback on this work to make sure I am on the right path for making a Rust HID abstraction that would be acceptable upstream. The patches compile with WERROR being disabled. This is necessary since Rust treats missing documentation comments as warnings (which is a good thing). I also need to go in and add more SAFETY comments. Thanks, Rahul Rameshbabu Rahul Rameshbabu (3): rust: core abstractions for HID drivers rust: hid: USB Monitor Control Class driver rust: hid: demo the core abstractions for probe and remove drivers/hid/Kconfig | 16 ++ drivers/hid/Makefile | 1 + drivers/hid/hid_monitor_control.rs | 42 +++++ rust/bindings/bindings_helper.h | 1 + rust/kernel/hid.rs | 245 +++++++++++++++++++++++++++++ rust/kernel/lib.rs | 2 + 6 files changed, 307 insertions(+) create mode 100644 drivers/hid/hid_monitor_control.rs create mode 100644 rust/kernel/hid.rs