mbox series

[0/2] Input: adp5588-keys Please correct and add

Message ID 20250516134313.282564-1-arefev@swemel.ru
Headers show
Series Input: adp5588-keys Please correct and add | expand

Message

Denis Arefev May 16, 2025, 1:43 p.m. UTC 
1. Add check on return code
2. Prevent buffer overflow

Denis Arefev (2):
  Input: adp5588-keys Add check on return code
  Input: adp5588-keys Prevent buffer overflow

 drivers/input/keyboard/adp5588-keys.c | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

Comments

Nuno Sá May 16, 2025, 1:47 p.m. UTC | #1 
On Fri, 2025-05-16 at 16:43 +0300, Denis Arefev wrote:
> 1. Add check on return code
> 2. Prevent buffer overflow
> 
> Denis Arefev (2):
>   Input: adp5588-keys Add check on return code
>   Input: adp5588-keys Prevent buffer overflow
> 
>  drivers/input/keyboard/adp5588-keys.c | 18 ++++++++++++++----
>  1 file changed, 14 insertions(+), 4 deletions(-)

Hi,

Thanks for the patch. However, not sure if this is really worth it... This is
driver is in the process of being removed:

https://lore.kernel.org/linux-input/04b8a6d68fdc0c0eadf69fbbc6a130ecc6c49360.camel@gmail.com/T/#mad1980e9652161a6a2e36c2aeeb97f900c6e9fc2

Unless we want somehow to backport these patches?

- Nuno Sá