mbox series

[RFC,v2,0/5] Support for MELFAS MIP4 touchkey devices

Message ID 20250613-mip4-touchkey-v2-0-9bbbe14c016d@disroot.org
Headers show
Series Support for MELFAS MIP4 touchkey devices | expand

Message

Kaustabh Chakraborty June 12, 2025, 7:41 p.m. UTC
MIP4 is a protocol developed and used by MELFAS in its touchscreen and
touchkey devices. The MIP4 touchscreen driver acknowledges the
touchscreen capabilities, but touchkeys are left unimplemented.

Apart from touchscreen + touchkey devices, the protocol is also used by
devices which are, functionally, touchkey devices. Thus, the driver
should also be compatible with those devices. This series aims to
introduce such required changes.

RFC: How should the compatible string be handled? The string defined in
dtschema is 'melfas,mip4_ts', which implies that it's a MIP4 *touchscreen*
by MELFAS.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
Changes in v2:
- rewrite MIP4 documentation in dtschema (robh)
- Link to v1: https://lore.kernel.org/r/20250503-mip4-touchkey-v1-0-b483cda29a5b@disroot.org

---
Kaustabh Chakraborty (5):
      dt-bindings: input: melfas-mip4: convert to dtschema
      dt-bindings: input: melfas-mip4: document linux,keycodes property
      Input: melfas-mip4 - add support for touchkey input events
      Input: melfas-mip4 - initialize touch events only if the device is a touchscreen
      Input: melfas-mip4 - add support for event formats 4 and 9

 .../bindings/input/touchscreen/melfas,mip4_ts.yaml | 61 ++++++++++++++
 .../bindings/input/touchscreen/melfas_mip4.txt     | 20 -----
 drivers/input/touchscreen/melfas_mip4.c            | 98 ++++++++++++++++------
 3 files changed, 133 insertions(+), 46 deletions(-)
---
base-commit: 0bb71d301869446810a0b13d3da290bd455d7c78
change-id: 20250501-mip4-touchkey-66a113226bce

Best regards,

Comments

Krzysztof Kozlowski June 13, 2025, 7:09 a.m. UTC | #1
On Fri, Jun 13, 2025 at 01:11:33AM GMT, Kaustabh Chakraborty wrote:
> Port the documentation file melfas_mip4.txt over to melfas,mip4_ts.yaml.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  .../bindings/input/touchscreen/melfas,mip4_ts.yaml | 55 ++++++++++++++++++++++
>  .../bindings/input/touchscreen/melfas_mip4.txt     | 20 --------
>  2 files changed, 55 insertions(+), 20 deletions(-)

You need to fix MAINTAINERS as well. With that:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof