mbox series

[v2,0/2] Miscellaneous fixes for Azoteq IQS626A

Message ID Y9RQCQa69f3TaiWf@nixie71
Headers show
Series Miscellaneous fixes for Azoteq IQS626A | expand

Message

Jeff LaBundy Jan. 27, 2023, 10:28 p.m. UTC 
This series addresses a fwnode_handle reference count leak. Tightly
coupled with this logic is that behind the discussion in [1], where
it was pointed out that two properties in question have different
types across bindings for the same vendor.

Addressing the latter in fact simplifies the former; therefore both
changes are introduced in patch [1/2]. As there are no known users
of this driver, it is safe to change the binding in this way.

Patch [2/2] makes the corresponding documentation change and carries
a fixes tag so that it accompanies patch [1/2] into stable releases.

[1] https://patchwork.kernel.org/patch/13116327/

Jeff LaBundy (2):
  Input: iqs626a - drop unused device node references
  dt-bindings: input: iqs626a: Redefine trackpad property types

 .../devicetree/bindings/input/iqs626a.yaml    |  94 ++++++++---
 drivers/input/misc/iqs626a.c                  | 156 ++++++++----------
 2 files changed, 140 insertions(+), 110 deletions(-)

Comments

Dmitry Torokhov Feb. 4, 2023, 1:21 a.m. UTC | #1 
On Fri, Jan 27, 2023 at 04:29:41PM -0600, Jeff LaBundy wrote:
> Each call to device/fwnode_get_named_child_node() must be matched
> with a call to fwnode_handle_put() once the corresponding node is
> no longer in use. This ensures a reference count remains balanced
> in the case of dynamic device tree support.
> 
> Currently, the driver never calls fwnode_handle_put(); this patch
> adds the missing calls. Because fwnode_handle_put() does not take
> a const *fwnode_handle, the const qualifier is removed across all
> corresponding *fwnode_handle instances.
> 
> As part of this change, trackpad channel touch thresholds and ATI
> base values are now specified under single trackpad channel child
> nodes. This enhancement moves both properties to scalar values as
> opposed to arrays, making their types consistent across bindings.
> 
> Fixes: f1d2809de97a ("Input: Add support for Azoteq IQS626A")
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>

Applied, thank you.