From patchwork Tue Mar 31 10:50:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wang, Jiada" X-Patchwork-Id: 207981 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF009C43331 for ; Tue, 31 Mar 2020 10:53:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B643A208E0 for ; Tue, 31 Mar 2020 10:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730748AbgCaKx4 (ORCPT ); Tue, 31 Mar 2020 06:53:56 -0400 Received: from esa4.mentor.iphmx.com ([68.232.137.252]:43597 "EHLO esa4.mentor.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730442AbgCaKxy (ORCPT ); Tue, 31 Mar 2020 06:53:54 -0400 IronPort-SDR: FI83d+LP6hQCVO7qeDjAtyqLRylOo0iZxrYFONzU18h1LGhmaQplFE3XNm37X1mpkJqvt5nli9 gS+CRKsiLu/0FMxDsednGFADXt8IrSjvha+8+sQ3a/olLvttgsqMdGOjC05TclxGuuNoqdFY61 IRzWk+PsvtQrZ1+z2Ft9qYeddI59LvtqIjevviIONGU4QY9vkJdi53yGvPnNzYJaaWWX9oRrhx y67agsZnn1PUqhIBzME8hQ6/Xf5+UhhGFTxu5e1blkc4KiJvsg1WmZMlE1vG4wEmClU25yHvy1 gwU= X-IronPort-AV: E=Sophos;i="5.72,327,1580803200"; d="scan'208";a="47330846" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 31 Mar 2020 02:53:53 -0800 IronPort-SDR: 9nLGWcYtbMcKIIL9wJ8C5xMlioyufVD/KUUOGX5rjnF/YBam1WnLR76VJJxlVTMSzARajY1kqb 5uoPI7prUwh1IphNNqK/uFWD5u4MJv/VSyrNObWXmGeVjRl9ZHoneaJIW3vhfy5iMiOf3Ifjr4 Evk1leMshBBGptTupOi0j5GbCyYnjH9a63yVLsgAIOtPrymnE6omQDhcMMyjNnQ742yhg7JEFu Y7heyLgJatbMc05HedJ7RDpkxiYYbkKaxLvG2j3AO5ZoPNUyTxVxdiW1osCsELvT74YCqP+WTV f0k= From: Jiada Wang To: , , , , CC: , , , , Subject: [PATCH v10 47/55] Input: Atmel: improve error handling in mxt_update_cfg() Date: Tue, 31 Mar 2020 03:50:43 -0700 Message-ID: <20200331105051.58896-48-jiada_wang@mentor.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200331105051.58896-1-jiada_wang@mentor.com> References: <20200331105051.58896-1-jiada_wang@mentor.com> MIME-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org From: Deepak Das mxt_update_cfg() failed to propagate the error code from mxt_init_t7_power_cfg() so return the error code. Signed-off-by: Deepak Das Signed-off-by: George G. Davis Signed-off-by: Jiada Wang --- drivers/input/touchscreen/atmel_mxt_ts.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 258dcd8a68e5..069a532bd0b2 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2185,7 +2185,9 @@ static int mxt_update_cfg(struct mxt_data *data, const struct firmware *fw) dev_info(dev, "Config successfully updated\n"); /* T7 config may have changed */ - mxt_init_t7_power_cfg(data); + ret = mxt_init_t7_power_cfg(data); + if (ret) + dev_warn(dev, "Power Config failed to update\n"); release_mem: kfree(cfg.mem);