From patchwork Fri Mar 26 14:34:35 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 409490 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1488742jai; Fri, 26 Mar 2021 07:35:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyXWunS4/D1vqvbTUlO5RrlNmnYP9BJAVlqfwgM/zVQWP9yswZSC2r5pjPeF+emt4SjY9h X-Received: by 2002:a50:ef0a:: with SMTP id m10mr15429666eds.261.1616769351786; Fri, 26 Mar 2021 07:35:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616769351; cv=none; d=google.com; s=arc-20160816; b=NECUZjmGFRrcjcYi5LFiGJn55FtCkYedXUCzQvu2jNiCRVvQUYQ59AwVxcmjuZzCJA 55FBCUn5gkGJfT6+okjw8GrLPsFs+Yuzsdx75bYuZloeYI1GBvkhbWZGNqb7Wdf1lgch Vbh3Qht0X3oID/JPjIG9niWes6v5livElErkCNLKj1BrGb5nBlYEAofqDTYXHzr5PWHS j1rmdaSKmpMjEw4J7s2d1lwp1lz+fAtKMNwJaYwQgEFxZn9ZUDmzNCWoamLz26zr8D5/ YUbJ8GEP/7L5Tf0Qkop8hTigUovehu7M6GXZn/HnM+XlyTRT7LQXMEJggSjoo3947UZ3 uJJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QVmPdW315bcMNCrhn2o1gVugo/fPOa1lxmMCL3Wjz+Y=; b=aCCmF/nKdxFA1XxfA7bZkc4OcAp5kXlnTJxm73nqD3LroghX+njk41QldqelBgoQlJ flDkTaMwWE10mTdElDdB1nBQQH+P6tGMrslvxak3zpuDnpvjZ0HK7N4OhcIzWOeeLicB cCRB3Z0jNTgFbx2/INqvUVtOK5GBv2T4fpmqTyDJ9sAe5U9M7abNVKb1TitVg0WQM9by N7VEasXd/QgwN04Y6DMT8YWL4raQjZ+Jya6OQak6Blp40m4ibvPInPHBkOur3anVQkYO R8+eZ2zDWR1Zos1rFtcG22TMWtEKuGMZ/HGbCaHO8mJj0xO+giVWzCrJ1mJA236FNpUB +Zfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ED8HacYf; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e16si2126144edz.7.2021.03.26.07.35.51; Fri, 26 Mar 2021 07:35:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ED8HacYf; spf=pass (google.com: domain of linux-input-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-input-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230274AbhCZOfS (ORCPT + 1 other); Fri, 26 Mar 2021 10:35:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230179AbhCZOfI (ORCPT ); Fri, 26 Mar 2021 10:35:08 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3AC1C0613BC for ; Fri, 26 Mar 2021 07:35:05 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id e18so5870243wrt.6 for ; Fri, 26 Mar 2021 07:35:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QVmPdW315bcMNCrhn2o1gVugo/fPOa1lxmMCL3Wjz+Y=; b=ED8HacYfYn6YJjZ0KkKvWkz8yYZq1TC+nrf/H+kyQ1IIfzl50xLOCLW4Fm+JEwgUzA xp+L5FlsRqou4qpw9+VZ+4DEuus50xbo0Qyfh+ZOuySePEB1EW1eGMmG21yX1zb6t1PJ czXpkjIvhXlibEKrL1H21gusLkrBcLoEAZw6tXqbE0xJ43SqmvNKX7s/2IdlJ4Ou9Nua yLSqhX9Nsy8rJcvbsRS5Rs1gsVJ4BJXZqymsSFboYExammE9/wscC5GgAjUfcJ8BtXrq 6+MLu3+qYLrXuluhvLsxFQ8zGEbMVYnhjgJuUWklHogHD4KqmjVa4lfpOzhw1bG8qyIG yHAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QVmPdW315bcMNCrhn2o1gVugo/fPOa1lxmMCL3Wjz+Y=; b=F5aYpCad8IrzvAFWu4c6pgYTPAu1PZnqzJHsceI1PFWCJ1fGQooyha7A/ic5X6JsiG bnomqwjnuzXT0B0ztq6WvDZF6Hzkb4yhjMIWH7nt8Frurscdtogndz8/XbdahTHk2y2d huBeLddZzhj5JA6j34mD3H76lLb+rpyENZ5l9qEP+xAnp6g4ak11edHmIgiYPhLPb+VD nkUryfL+KemxnbyIQ/+1K+TBKpcY9bCAbtbh45KwcPCd2FOr2ji3dFxCD5FgZNAt4sck 18obsN3T3r++kSb4q4eVK8WVH3icEu/U7T43d1a6FkwMlRq85XEIWLISZZUCMnCji4us UEaA== X-Gm-Message-State: AOAM530DJhUpmiO9yfEBf6Y5lc5wVCWwZ9nUpYp8SAGLHa/Y0i1/0UiK xdZ3Q6gM87CsM/V5kNvhil9TSz5SMS73oQ== X-Received: by 2002:a5d:4fd0:: with SMTP id h16mr14405613wrw.178.1616769304525; Fri, 26 Mar 2021 07:35:04 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id j26sm12878225wrh.57.2021.03.26.07.35.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Mar 2021 07:35:04 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Srinivas Pandruvada , Jiri Kosina , Benjamin Tissoires , Daniel Drubin , linux-input@vger.kernel.org Subject: [PATCH 02/25] HID: ishtp-hid-client: Move variable to where it's actually used Date: Fri, 26 Mar 2021 14:34:35 +0000 Message-Id: <20210326143458.508959-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210326143458.508959-1-lee.jones@linaro.org> References: <20210326143458.508959-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Fixes the following W=1 kernel build warning(s): In file included from drivers/hid/intel-ish-hid/ishtp-hid.c:11: drivers/hid/intel-ish-hid/ishtp-hid.h:24:21: warning: ‘hid_ishtp_guid’ defined but not used [-Wunused-const-variable=] Cc: Srinivas Pandruvada Cc: Jiri Kosina Cc: Benjamin Tissoires Cc: Daniel Drubin Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Srinivas Pandruvada --- drivers/hid/intel-ish-hid/ishtp-hid-client.c | 5 +++++ drivers/hid/intel-ish-hid/ishtp-hid.h | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.27.0 diff --git a/drivers/hid/intel-ish-hid/ishtp-hid-client.c b/drivers/hid/intel-ish-hid/ishtp-hid-client.c index 0f1b5283bab42..24599280105d8 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid-client.c +++ b/drivers/hid/intel-ish-hid/ishtp-hid-client.c @@ -11,6 +11,11 @@ #include #include "ishtp-hid.h" +/* ISH Transport protocol (ISHTP in short) GUID */ +static const guid_t hid_ishtp_guid = + GUID_INIT(0x33AECD58, 0xB679, 0x4E54, + 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); + /* Rx ring buffer pool size */ #define HID_CL_RX_RING_SIZE 32 #define HID_CL_TX_RING_SIZE 16 diff --git a/drivers/hid/intel-ish-hid/ishtp-hid.h b/drivers/hid/intel-ish-hid/ishtp-hid.h index 5ffd0da3cf1fa..e2423f7d2b547 100644 --- a/drivers/hid/intel-ish-hid/ishtp-hid.h +++ b/drivers/hid/intel-ish-hid/ishtp-hid.h @@ -20,11 +20,6 @@ extern void (*hid_print_trace)(void *unused, const char *format, ...); #define hid_ishtp_trace(client, ...) \ (hid_print_trace)(NULL, __VA_ARGS__) -/* ISH Transport protocol (ISHTP in short) GUID */ -static const guid_t hid_ishtp_guid = - GUID_INIT(0x33AECD58, 0xB679, 0x4E54, - 0x9B, 0xD9, 0xA0, 0x4D, 0x34, 0xF0, 0xC2, 0x26); - /* ISH HID message structure */ struct hostif_msg_hdr { uint8_t command; /* Bit 7: is_response */