| Message ID | 20220126153519.3637496-2-mkorpershoek@baylibre.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add matrix keypad driver support for Mediatek SoCs | expand |
On Wed, 26 Jan 2022 16:35:17 +0100, Mattijs Korpershoek wrote: > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:28:13: [warning] wrong indentation: expected 14 but found 12 (indentation) ./Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml:43:8: [warning] wrong indentation: expected 6 but found 7 (indentation) dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1584526 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Wed, Jan 26, 2022 at 9:35 AM Mattijs Korpershoek <mkorpershoek@baylibre.com> wrote: > > From: "fengping.yu" <fengping.yu@mediatek.com> > > This patch add devicetree bindings for Mediatek matrix keypad driver. > > Signed-off-by: fengping.yu <fengping.yu@mediatek.com> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> > Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > .../input/mediatek,mt6779-keypad.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > > diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > new file mode 100644 > index 000000000000..2c76029224a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: GPL-2.0 dual license new bindings > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek's Keypad Controller device tree bindings > + > +maintainers: > + - Fengping Yu <fengping.yu@mediatek.com> > + > +allOf: > + - $ref: "/schemas/input/matrix-keymap.yaml#" > + > +description: | > + Mediatek's Keypad controller is used to interface a SoC with a matrix-type > + keypad device. The keypad controller supports multiple row and column lines. > + A key can be placed at each intersection of a unique row and a unique column. > + The keypad controller can sense a key-press and key-release and report the > + event using a interrupt to the cpu. > + > +properties: > + compatible: > + oneOf: > + - const: mediatek,mt6779-keypad > + - items: > + - enum: > + - mediatek,mt6873-keypad > + - const: mediatek,mt6779-keypad > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: Names of the clocks listed in clocks property in the same order Drop generic descriptions. > + items: > + - const: kpd > + > + wakeup-source: > + description: use any event on keypad as wakeup event > + type: boolean > + > + mediatek,debounce-us: We already a somewhat common property: debounce-delay-ms > + description: | > + Debounce interval in microseconds, if not specified, the default > + value is 16000 > + maximum: 256000 default: 16000 > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/input/input.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + kp@10010000 { Use a standard node name: keyboard@... or keys@... > + compatible = "mediatek,mt6779-keypad"; > + reg = <0 0x10010000 0 0x1000>; > + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; > + clocks = <&clk26m>; > + clock-names = "kpd"; > + }; > + }; > -- > 2.32.0 >
diff --git a/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml new file mode 100644 index 000000000000..2c76029224a0 --- /dev/null +++ b/Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml @@ -0,0 +1,80 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/input/mediatek,mt6779-keypad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek's Keypad Controller device tree bindings + +maintainers: + - Fengping Yu <fengping.yu@mediatek.com> + +allOf: + - $ref: "/schemas/input/matrix-keymap.yaml#" + +description: | + Mediatek's Keypad controller is used to interface a SoC with a matrix-type + keypad device. The keypad controller supports multiple row and column lines. + A key can be placed at each intersection of a unique row and a unique column. + The keypad controller can sense a key-press and key-release and report the + event using a interrupt to the cpu. + +properties: + compatible: + oneOf: + - const: mediatek,mt6779-keypad + - items: + - enum: + - mediatek,mt6873-keypad + - const: mediatek,mt6779-keypad + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + description: Names of the clocks listed in clocks property in the same order + items: + - const: kpd + + wakeup-source: + description: use any event on keypad as wakeup event + type: boolean + + mediatek,debounce-us: + description: | + Debounce interval in microseconds, if not specified, the default + value is 16000 + maximum: 256000 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/input/input.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + kp@10010000 { + compatible = "mediatek,mt6779-keypad"; + reg = <0 0x10010000 0 0x1000>; + interrupts = <GIC_SPI 75 IRQ_TYPE_EDGE_FALLING>; + clocks = <&clk26m>; + clock-names = "kpd"; + }; + };