| Message ID | 20220928-mdm9615-dt-schema-fixes-v2-8-87fbeb4ae053@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm: qcom: mdm9615: first round of bindings and DT fixes | expand |
On 04/10/2022 11:02, Krzysztof Kozlowski wrote: > On 04/10/2022 10:08, Neil Armstrong wrote: >> The PM8921 compatible is used as fallback when PM8018 is available, >> then remove PM8018 compatible. > > s/then/so/ > > But it's a bit confusing because PM8018 is not "available". It is > "present" or "is" instead, so rather: > "The PM8018 compatible is always used with PM8921 fallback, so PM8018 > compatible can be safely removed from device ID table". Thx for the suggestion, will use this wording, same in patch 9. > >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof > Thanks, Neil
diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c index 2f2734ba5273..601106580e2e 100644 --- a/drivers/mfd/qcom-pm8xxx.c +++ b/drivers/mfd/qcom-pm8xxx.c @@ -497,7 +497,6 @@ static const struct pm_irq_data pm8821_data = { }; static const struct of_device_id pm8xxx_id_table[] = { - { .compatible = "qcom,pm8018", .data = &pm8xxx_data}, { .compatible = "qcom,pm8058", .data = &pm8xxx_data}, { .compatible = "qcom,pm8821", .data = &pm8821_data}, { .compatible = "qcom,pm8921", .data = &pm8xxx_data},
The PM8921 compatible is used as fallback when PM8018 is available, then remove PM8018 compatible. Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>