diff mbox series

[v3,01/11] Input: xpad - improve name of 8BitDo controller 2dc8:3106

Message ID 20250107192830.414709-2-rojtberg@gmail.com
State New
Headers show
Series Input: xpad - sync with github fork | expand

Commit Message

Pavel Rojtberg Jan. 7, 2025, 7:28 p.m. UTC 
From: Leonardo Brondani Schenkel <leonardo@schenkel.net>

8BitDo Pro 2 Wired Controller shares the same USB identifier
(2dc8:3106) as a different device, so amend name to reflect that and
reduce confusion as the user might think the controller was misdetected.

I have personally tested it and I can confirm that Pro 2 Wired will also
not work in XTYPE_XBOXONE mode (buton presses won't register), therefore
XTYPE_XBOX360 remains appropriate.

Signed-off-by: Leonardo Brondani Schenkel <leonardo@schenkel.net>
Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
---
 drivers/input/joystick/xpad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dmitry Torokhov Jan. 21, 2025, 4:20 a.m. UTC | #1 
On Tue, Jan 07, 2025 at 08:28:20PM +0100, Pavel Rojtberg wrote:
> From: Leonardo Brondani Schenkel <leonardo@schenkel.net>
> 
> 8BitDo Pro 2 Wired Controller shares the same USB identifier
> (2dc8:3106) as a different device, so amend name to reflect that and
> reduce confusion as the user might think the controller was misdetected.
> 
> I have personally tested it and I can confirm that Pro 2 Wired will also
> not work in XTYPE_XBOXONE mode (buton presses won't register), therefore
> XTYPE_XBOX360 remains appropriate.
> 
> Signed-off-by: Leonardo Brondani Schenkel <leonardo@schenkel.net>
> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>

Applied, thank you.Applied, thank you.

Thanks.
diff mbox series

Patch

diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index ff9bc87f2f70..8a02b9a5ef79 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -373,7 +373,7 @@  static const struct xpad_device {
 	{ 0x294b, 0x3303, "Snakebyte GAMEPAD BASE X", 0, XTYPE_XBOXONE },
 	{ 0x294b, 0x3404, "Snakebyte GAMEPAD RGB X", 0, XTYPE_XBOXONE },
 	{ 0x2dc8, 0x2000, "8BitDo Pro 2 Wired Controller fox Xbox", 0, XTYPE_XBOXONE },
-	{ 0x2dc8, 0x3106, "8BitDo Pro 2 Wired Controller", 0, XTYPE_XBOX360 },
+	{ 0x2dc8, 0x3106, "8BitDo Ultimate Wireless / Pro 2 Wired Controller", 0, XTYPE_XBOX360 },
 	{ 0x2dc8, 0x310a, "8BitDo Ultimate 2C Wireless Controller", 0, XTYPE_XBOX360 },
 	{ 0x2e24, 0x0652, "Hyperkin Duke X-Box One pad", 0, XTYPE_XBOXONE },
 	{ 0x31e3, 0x1100, "Wooting One", 0, XTYPE_XBOX360 },