| Message ID | 20250303-pocof1-touchscreen-support-v4-1-cdc3bebc3942@joelselvaraj.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add Xiaomi Poco F1 touchscreen support | expand |
On Mon, Mar 03, 2025 at 04:36:55PM -0600, Joel Selvaraj via B4 Relay wrote: > From: Joel Selvaraj <foss@joelselvaraj.com> > > In Xiaomi Poco F1 (qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech > FT8719 touchscreen is integrally connected to the display panel > (EBBG FT8719) and thus should be power sequenced together with display > panel using the panel property. Since the edt-ft5x06 touchscreen binding > uses almost all the properties present in touchscreen.yaml, let's remove > additionalProperties: false and use unevaluatedProperties to include all > the properties, including the needed panel property. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com> I believe this is better be merged through the arch tree together with the dts changes. Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Thanks.
On Tue, Mar 04, 2025 at 10:45:35PM -0800, Dmitry Torokhov wrote: > On Mon, Mar 03, 2025 at 04:36:55PM -0600, Joel Selvaraj via B4 Relay wrote: > > From: Joel Selvaraj <foss@joelselvaraj.com> > > > > In Xiaomi Poco F1 (qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech > > FT8719 touchscreen is integrally connected to the display panel > > (EBBG FT8719) and thus should be power sequenced together with display > > panel using the panel property. Since the edt-ft5x06 touchscreen binding > > uses almost all the properties present in touchscreen.yaml, let's remove > > additionalProperties: false and use unevaluatedProperties to include all > > the properties, including the needed panel property. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com> > > I believe this is better be merged through the arch tree together with > the dts changes. > Then I will have to come up with a motivation to why it needed to go together with the dts change ;) Please pick the binding change through the input tree and I'll pick the dts changes once the binding has landed in linux-next. > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Thank you, Bjorn > Thanks. > > -- > Dmitry
Hi Bjorn Andersson and Dmitry Torokhov, On 3/13/25 17:18, Bjorn Andersson wrote: > On Tue, Mar 04, 2025 at 10:45:35PM -0800, Dmitry Torokhov wrote: >> On Mon, Mar 03, 2025 at 04:36:55PM -0600, Joel Selvaraj via B4 Relay wrote: >>> From: Joel Selvaraj <foss@joelselvaraj.com> >>> >>> In Xiaomi Poco F1 (qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech >>> FT8719 touchscreen is integrally connected to the display panel >>> (EBBG FT8719) and thus should be power sequenced together with display >>> panel using the panel property. Since the edt-ft5x06 touchscreen binding >>> uses almost all the properties present in touchscreen.yaml, let's remove >>> additionalProperties: false and use unevaluatedProperties to include all >>> the properties, including the needed panel property. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com> >> >> I believe this is better be merged through the arch tree together with >> the dts changes. >> > > Then I will have to come up with a motivation to why it needed to go > together with the dts change ;) > > Please pick the binding change through the input tree and I'll pick the > dts changes once the binding has landed in linux-next. > >> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> >> A gently ping on this patch. It seems there was a confusion on which tree the patch should go, but ended up not landing yet. Kindly let me know if any further fixes are needed from my end. Would be nice to get this landed. Thank you both. Regards, Joel Selvaraj
diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml index 70a922e213f2..ab821490284a 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml @@ -103,16 +103,9 @@ properties: minimum: 0 maximum: 255 - touchscreen-size-x: true - touchscreen-size-y: true - touchscreen-fuzz-x: true - touchscreen-fuzz-y: true - touchscreen-inverted-x: true - touchscreen-inverted-y: true - touchscreen-swapped-x-y: true interrupt-controller: true -additionalProperties: false +unevaluatedProperties: false required: - compatible