| Message ID | 20250610-pf1550-v5-4-ed0d9e3aaac7@savoirfairelinux.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | add support for pf1550 PMIC MFD-based drivers | expand |
On Tue, Jun 10, 2025 at 03:47:32PM -0400, Samuel Kayode wrote: > Add support for the onkey of the pf1550 PMIC. > > Signed-off-by: Samuel Kayode <samuel.kayode@savoirfairelinux.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > v4: > - Address Dmitry's feedback > - Drop irq variable in onkey_drv_data > - Drop keycode variable in onkey_drv_data > - Define wakeup as type bool > - Use platform_get_irq > - Use type const for struct pf1550_dev in onkey_drv_data > - Replace (error < 0) with (error) in if statement when applicable > - No need to define driver_data in table id > - Define driver.pm with pm_sleep_ptr > v3: > - Address Dmitry's feedback > - Drop compatible string > - Remove dependency on OF > - Use generic device properties > - Drop unnecessary includes > - Drop unnecessary initializations in probe > - Always use the KEY_POWER property for onkey->keycode > - Do mapping of irqs in MFD driver > - Define onkey->input before interrupts are active > - Drop unnecessary input_free_device since devm > - Manage onkey irqs instead of the main interrupt line. > - Fix integer overflow when unmasking onkey irqs in onkey_resume. > v2: > - Add driver for onkey > --- > drivers/input/misc/Kconfig | 11 +++ > drivers/input/misc/Makefile | 1 + > drivers/input/misc/pf1550-onkey.c | 183 ++++++++++++++++++++++++++++++++++++++ > 3 files changed, 195 insertions(+) > > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig > index f5496ca0c0d2bfcb7968503ccd1844ff43bbc1c0..47b3c43ff0550f14d61990997976366436411adc 100644 > --- a/drivers/input/misc/Kconfig > +++ b/drivers/input/misc/Kconfig > @@ -179,6 +179,17 @@ config INPUT_PCSPKR > To compile this driver as a module, choose M here: the > module will be called pcspkr. > > +config INPUT_PF1550_ONKEY > + tristate "NXP PF1550 Onkey support" > + depends on MFD_PF1550 > + help > + Say Y here if you want support for PF1550 PMIC. Onkey can trigger > + release and 1s(push hold), 2s, 3s, 4s, 8s interrupt for long press > + detect. > + > + To compile this driver as a module, choose M here. The module will be > + called pf1550-onkey. > + > config INPUT_PM8941_PWRKEY > tristate "Qualcomm PM8941 power key support" > depends on MFD_SPMI_PMIC > diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile > index 6d91804d0a6f761a094e6c380f878f74c3054d63..c652337de464c1eeaf1515d0bc84d10de0cb3a74 100644 > --- a/drivers/input/misc/Makefile > +++ b/drivers/input/misc/Makefile > @@ -62,6 +62,7 @@ obj-$(CONFIG_INPUT_PCAP) += pcap_keys.o > obj-$(CONFIG_INPUT_PCF50633_PMU) += pcf50633-input.o > obj-$(CONFIG_INPUT_PCF8574) += pcf8574_keypad.o > obj-$(CONFIG_INPUT_PCSPKR) += pcspkr.o > +obj-$(CONFIG_INPUT_PF1550_ONKEY) += pf1550-onkey.o > obj-$(CONFIG_INPUT_PM8941_PWRKEY) += pm8941-pwrkey.o > obj-$(CONFIG_INPUT_PM8XXX_VIBRATOR) += pm8xxx-vibrator.o > obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY) += pmic8xxx-pwrkey.o > diff --git a/drivers/input/misc/pf1550-onkey.c b/drivers/input/misc/pf1550-onkey.c > new file mode 100644 > index 0000000000000000000000000000000000000000..7e604c5544066eefbd84abe7bdff767b8b8978ab > --- /dev/null > +++ b/drivers/input/misc/pf1550-onkey.c > @@ -0,0 +1,183 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// > +// Driver for the PF1550 ON_KEY > +// Copyright (C) 2016 Freescale Semiconductor, Inc. All Rights Reserved. > +// > +// Portions Copyright (c) 2025 Savoir-faire Linux Inc. > +// Samuel Kayode <samuel.kayode@savoirfairelinux.com> > +// > + > +#include <linux/err.h> > +#include <linux/input.h> > +#include <linux/interrupt.h> > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/mfd/pf1550.h> > +#include <linux/platform_device.h> > + > +#define PF1550_ONKEY_IRQ_NR 6 > + > +struct onkey_drv_data { > + struct device *dev; > + const struct pf1550_dev *pf1550; > + bool wakeup; > + struct input_dev *input; > +}; > + > +static irqreturn_t pf1550_onkey_irq_handler(int irq, void *data) > +{ > + struct onkey_drv_data *onkey = data; > + struct platform_device *pdev = to_platform_device(onkey->dev); > + int i, state, irq_type = -1; > + > + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) > + if (irq == platform_get_irq(pdev, i)) > + irq_type = i; > + > + switch (irq_type) { > + case PF1550_ONKEY_IRQ_PUSHI: > + state = 0; > + break; > + case PF1550_ONKEY_IRQ_1SI: > + case PF1550_ONKEY_IRQ_2SI: > + case PF1550_ONKEY_IRQ_3SI: > + case PF1550_ONKEY_IRQ_4SI: > + case PF1550_ONKEY_IRQ_8SI: > + state = 1; > + break; > + default: > + dev_err(onkey->dev, "onkey interrupt: irq %d occurred\n", > + irq_type); > + return IRQ_HANDLED; > + } > + > + input_event(onkey->input, EV_KEY, KEY_POWER, state); > + input_sync(onkey->input); > + > + return IRQ_HANDLED; > +} > + > +static int pf1550_onkey_probe(struct platform_device *pdev) > +{ > + struct onkey_drv_data *onkey; > + struct input_dev *input; > + int i, irq, error; > + > + onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL); > + if (!onkey) > + return -ENOMEM; > + > + onkey->dev = &pdev->dev; > + > + onkey->pf1550 = dev_get_drvdata(pdev->dev.parent); > + if (!onkey->pf1550->regmap) > + return dev_err_probe(&pdev->dev, -ENODEV, > + "failed to get regmap\n"); > + > + onkey->wakeup = device_property_read_bool(pdev->dev.parent, > + "wakeup-source"); > + > + input = devm_input_allocate_device(&pdev->dev); > + if (!input) > + return dev_err_probe(&pdev->dev, -ENOMEM, > + "failed to allocate the input device\n"); > + > + input->name = pdev->name; > + input->phys = "pf1550-onkey/input0"; > + input->id.bustype = BUS_HOST; > + > + input_set_capability(input, EV_KEY, KEY_POWER); > + > + onkey->input = input; > + platform_set_drvdata(pdev, onkey); > + > + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) { > + irq = platform_get_irq(pdev, i); > + if (irq < 0) > + return irq; > + > + error = devm_request_threaded_irq(&pdev->dev, irq, NULL, > + pf1550_onkey_irq_handler, > + IRQF_NO_SUSPEND, > + "pf1550-onkey", onkey); > + if (error) > + return dev_err_probe(&pdev->dev, error, > + "failed: irq request (IRQ: %d)\n", > + i); > + } > + > + error = input_register_device(input); > + if (error) > + return dev_err_probe(&pdev->dev, error, > + "failed to register input device\n"); > + > + device_init_wakeup(&pdev->dev, onkey->wakeup); > + > + return 0; > +} > + > +static int pf1550_onkey_suspend(struct device *dev) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + struct onkey_drv_data *onkey = platform_get_drvdata(pdev); > + int i, irq; > + > + if (!device_may_wakeup(&pdev->dev)) > + regmap_write(onkey->pf1550->regmap, > + PF1550_PMIC_REG_ONKEY_INT_MASK0, > + ONKEY_IRQ_PUSHI | ONKEY_IRQ_1SI | ONKEY_IRQ_2SI | > + ONKEY_IRQ_3SI | ONKEY_IRQ_4SI | ONKEY_IRQ_8SI); > + else > + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) { > + irq = platform_get_irq(pdev, i); > + if (irq > 0) > + enable_irq_wake(irq); > + } > + > + return 0; > +} > + > +static int pf1550_onkey_resume(struct device *dev) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + struct onkey_drv_data *onkey = platform_get_drvdata(pdev); > + int i, irq; > + > + if (!device_may_wakeup(&pdev->dev)) > + regmap_write(onkey->pf1550->regmap, > + PF1550_PMIC_REG_ONKEY_INT_MASK0, > + ~((u8)(ONKEY_IRQ_PUSHI | ONKEY_IRQ_1SI | > + ONKEY_IRQ_2SI | ONKEY_IRQ_3SI | ONKEY_IRQ_4SI | > + ONKEY_IRQ_8SI))); > + else > + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) { > + irq = platform_get_irq(pdev, i); > + if (irq > 0) > + disable_irq_wake(irq); > + } > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(pf1550_onkey_pm_ops, pf1550_onkey_suspend, > + pf1550_onkey_resume); > + > +static const struct platform_device_id pf1550_onkey_id[] = { > + { "pf1550-onkey", 0 }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(platform, pf1550_onkey_id); > + > +static struct platform_driver pf1550_onkey_driver = { > + .driver = { > + .name = "pf1550-onkey", > + .pm = pm_sleep_ptr(&pf1550_onkey_pm_ops), > + }, > + .probe = pf1550_onkey_probe, > + .id_table = pf1550_onkey_id, > +}; > +module_platform_driver(pf1550_onkey_driver); > + > +MODULE_AUTHOR("Freescale Semiconductor"); > +MODULE_DESCRIPTION("PF1550 onkey Driver"); > +MODULE_LICENSE("GPL"); > > -- > 2.49.0 >
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig index f5496ca0c0d2bfcb7968503ccd1844ff43bbc1c0..47b3c43ff0550f14d61990997976366436411adc 100644 --- a/drivers/input/misc/Kconfig +++ b/drivers/input/misc/Kconfig @@ -179,6 +179,17 @@ config INPUT_PCSPKR To compile this driver as a module, choose M here: the module will be called pcspkr. +config INPUT_PF1550_ONKEY + tristate "NXP PF1550 Onkey support" + depends on MFD_PF1550 + help + Say Y here if you want support for PF1550 PMIC. Onkey can trigger + release and 1s(push hold), 2s, 3s, 4s, 8s interrupt for long press + detect. + + To compile this driver as a module, choose M here. The module will be + called pf1550-onkey. + config INPUT_PM8941_PWRKEY tristate "Qualcomm PM8941 power key support" depends on MFD_SPMI_PMIC diff --git a/drivers/input/misc/Makefile b/drivers/input/misc/Makefile index 6d91804d0a6f761a094e6c380f878f74c3054d63..c652337de464c1eeaf1515d0bc84d10de0cb3a74 100644 --- a/drivers/input/misc/Makefile +++ b/drivers/input/misc/Makefile @@ -62,6 +62,7 @@ obj-$(CONFIG_INPUT_PCAP) += pcap_keys.o obj-$(CONFIG_INPUT_PCF50633_PMU) += pcf50633-input.o obj-$(CONFIG_INPUT_PCF8574) += pcf8574_keypad.o obj-$(CONFIG_INPUT_PCSPKR) += pcspkr.o +obj-$(CONFIG_INPUT_PF1550_ONKEY) += pf1550-onkey.o obj-$(CONFIG_INPUT_PM8941_PWRKEY) += pm8941-pwrkey.o obj-$(CONFIG_INPUT_PM8XXX_VIBRATOR) += pm8xxx-vibrator.o obj-$(CONFIG_INPUT_PMIC8XXX_PWRKEY) += pmic8xxx-pwrkey.o diff --git a/drivers/input/misc/pf1550-onkey.c b/drivers/input/misc/pf1550-onkey.c new file mode 100644 index 0000000000000000000000000000000000000000..7e604c5544066eefbd84abe7bdff767b8b8978ab --- /dev/null +++ b/drivers/input/misc/pf1550-onkey.c @@ -0,0 +1,183 @@ +// SPDX-License-Identifier: GPL-2.0 +// +// Driver for the PF1550 ON_KEY +// Copyright (C) 2016 Freescale Semiconductor, Inc. All Rights Reserved. +// +// Portions Copyright (c) 2025 Savoir-faire Linux Inc. +// Samuel Kayode <samuel.kayode@savoirfairelinux.com> +// + +#include <linux/err.h> +#include <linux/input.h> +#include <linux/interrupt.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/mfd/pf1550.h> +#include <linux/platform_device.h> + +#define PF1550_ONKEY_IRQ_NR 6 + +struct onkey_drv_data { + struct device *dev; + const struct pf1550_dev *pf1550; + bool wakeup; + struct input_dev *input; +}; + +static irqreturn_t pf1550_onkey_irq_handler(int irq, void *data) +{ + struct onkey_drv_data *onkey = data; + struct platform_device *pdev = to_platform_device(onkey->dev); + int i, state, irq_type = -1; + + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) + if (irq == platform_get_irq(pdev, i)) + irq_type = i; + + switch (irq_type) { + case PF1550_ONKEY_IRQ_PUSHI: + state = 0; + break; + case PF1550_ONKEY_IRQ_1SI: + case PF1550_ONKEY_IRQ_2SI: + case PF1550_ONKEY_IRQ_3SI: + case PF1550_ONKEY_IRQ_4SI: + case PF1550_ONKEY_IRQ_8SI: + state = 1; + break; + default: + dev_err(onkey->dev, "onkey interrupt: irq %d occurred\n", + irq_type); + return IRQ_HANDLED; + } + + input_event(onkey->input, EV_KEY, KEY_POWER, state); + input_sync(onkey->input); + + return IRQ_HANDLED; +} + +static int pf1550_onkey_probe(struct platform_device *pdev) +{ + struct onkey_drv_data *onkey; + struct input_dev *input; + int i, irq, error; + + onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL); + if (!onkey) + return -ENOMEM; + + onkey->dev = &pdev->dev; + + onkey->pf1550 = dev_get_drvdata(pdev->dev.parent); + if (!onkey->pf1550->regmap) + return dev_err_probe(&pdev->dev, -ENODEV, + "failed to get regmap\n"); + + onkey->wakeup = device_property_read_bool(pdev->dev.parent, + "wakeup-source"); + + input = devm_input_allocate_device(&pdev->dev); + if (!input) + return dev_err_probe(&pdev->dev, -ENOMEM, + "failed to allocate the input device\n"); + + input->name = pdev->name; + input->phys = "pf1550-onkey/input0"; + input->id.bustype = BUS_HOST; + + input_set_capability(input, EV_KEY, KEY_POWER); + + onkey->input = input; + platform_set_drvdata(pdev, onkey); + + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) { + irq = platform_get_irq(pdev, i); + if (irq < 0) + return irq; + + error = devm_request_threaded_irq(&pdev->dev, irq, NULL, + pf1550_onkey_irq_handler, + IRQF_NO_SUSPEND, + "pf1550-onkey", onkey); + if (error) + return dev_err_probe(&pdev->dev, error, + "failed: irq request (IRQ: %d)\n", + i); + } + + error = input_register_device(input); + if (error) + return dev_err_probe(&pdev->dev, error, + "failed to register input device\n"); + + device_init_wakeup(&pdev->dev, onkey->wakeup); + + return 0; +} + +static int pf1550_onkey_suspend(struct device *dev) +{ + struct platform_device *pdev = to_platform_device(dev); + struct onkey_drv_data *onkey = platform_get_drvdata(pdev); + int i, irq; + + if (!device_may_wakeup(&pdev->dev)) + regmap_write(onkey->pf1550->regmap, + PF1550_PMIC_REG_ONKEY_INT_MASK0, + ONKEY_IRQ_PUSHI | ONKEY_IRQ_1SI | ONKEY_IRQ_2SI | + ONKEY_IRQ_3SI | ONKEY_IRQ_4SI | ONKEY_IRQ_8SI); + else + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) { + irq = platform_get_irq(pdev, i); + if (irq > 0) + enable_irq_wake(irq); + } + + return 0; +} + +static int pf1550_onkey_resume(struct device *dev) +{ + struct platform_device *pdev = to_platform_device(dev); + struct onkey_drv_data *onkey = platform_get_drvdata(pdev); + int i, irq; + + if (!device_may_wakeup(&pdev->dev)) + regmap_write(onkey->pf1550->regmap, + PF1550_PMIC_REG_ONKEY_INT_MASK0, + ~((u8)(ONKEY_IRQ_PUSHI | ONKEY_IRQ_1SI | + ONKEY_IRQ_2SI | ONKEY_IRQ_3SI | ONKEY_IRQ_4SI | + ONKEY_IRQ_8SI))); + else + for (i = 0; i < PF1550_ONKEY_IRQ_NR; i++) { + irq = platform_get_irq(pdev, i); + if (irq > 0) + disable_irq_wake(irq); + } + + return 0; +} + +static SIMPLE_DEV_PM_OPS(pf1550_onkey_pm_ops, pf1550_onkey_suspend, + pf1550_onkey_resume); + +static const struct platform_device_id pf1550_onkey_id[] = { + { "pf1550-onkey", 0 }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(platform, pf1550_onkey_id); + +static struct platform_driver pf1550_onkey_driver = { + .driver = { + .name = "pf1550-onkey", + .pm = pm_sleep_ptr(&pf1550_onkey_pm_ops), + }, + .probe = pf1550_onkey_probe, + .id_table = pf1550_onkey_id, +}; +module_platform_driver(pf1550_onkey_driver); + +MODULE_AUTHOR("Freescale Semiconductor"); +MODULE_DESCRIPTION("PF1550 onkey Driver"); +MODULE_LICENSE("GPL");