From patchwork Mon Feb 17 04:45:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 866014 Received: from MA0PR01CU009.outbound.protection.outlook.com (mail-southindiaazolkn19010000.outbound.protection.outlook.com [52.103.67.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BDA7155A52; Mon, 17 Feb 2025 04:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767511; cv=fail; b=pqjxPhs9btavw7xj87kYG38pSqhZWx2f6Z7fjPW3mBhp1+xO9SHsAoVF5Xis9ZI/9ER+8DIJeyx6d20dXiy4ytjE99gtMhJNGtXhIexO2zcBE/yNhzgnItv3k92W8fOmudHZv2XRYmi3QH8aSfz9n/XVKP1R5zOmjzv3AxGz3Xw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739767511; c=relaxed/simple; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=IC/mIOUM0rWh7gk41US/GTZVCuER/Axq/RpludUXp57xW3U9IYLpHyksYy9CkNP0VMh5DVBk1TEtWC69SRAcTSvF2ctke3QCP3ERM86eCq7DFtYzhcGg5y/2pcDAsem0mR885WQWOgMsQln9AVl22O6ROIr3Kbdn3XtIIZgkWUo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=rbgsBoHN; arc=fail smtp.client-ip=52.103.67.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="rbgsBoHN" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OR5OLWd6x5vkQqxEWmAS57LdU4I6cnUbiY6dvJnonAg3DnZY8LkWBspw1tWSZPiVuU5HmaBlDtU/qvNKJXUNDi0Qmbv4M+/NzjyM2YDRgI9tiEgIA+CDQ0MPGTljU8T4VNvIRta2JGamivNQby+PbVMZnKIO6YAHAfM+59NpYcCzsIQjACUXSMLwqHnL+eg5txMBgjeF385FzAvMRGMBMMqkdRAvCNf14MjBtHwAxIFfy6TM24vZ1MaRDkz3c2BKHR5411lDq7iyA3f1/xV0s0jgFTp3FynELxWRWDGC2KG9B2mnNz04ZNn4TEa8LPCVFeyTF2D0y/H0iDdjEYCq5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; b=AsX8xyRCnnRL5C8vgo3olRwjOLqmiYr1DYZcT12fzknYg7TqL5l1sWc2j625ri8num2q9fHSf6TRXPF1KvbiJ5EtxPaRV/EZn26x1c9dMSnxUGIM9z5s8mTaOEusAZGZPNzGwOeSmUI4PXoZgqHmWah6weHmGKlE9/66HcS7YCk8tIQI6IzrVJBR5zHAZBhjAAOgqtRJsYmcC9Z05gwDMkdr1IwzId582RA1MUOozRAmxLJvikZBZbsDa3CwlGwfOeBDI2G/TlvRKk5G435gUHYcmnUx1PlOi4FB+eSfmh8DpkevUQHzCrq7ZB5jy3Wp7MOxBM+Rn2aFFTzw5Jj4iA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PPi15f63hoAy86xQcZ45uU/GC2NgZXi0T9pMc3VgLvo=; b=rbgsBoHNrIwWaFkCVKWSc90tELOozepLpk0Bawrm1eity3LlCaylYR36Meu1g80eJbST4ItqBxVZbWMWzw0uD/oXqexxBY13x0llO+ERJ3v7S7Rtl5PjfT46tc8FtDja10y186F5GJvlcJNcveMakFq6/iF7Aifsu2sbpV1Vxo3m6T/nhaGkbEfXI/HEPpU64PFdhcU9u0WktLKwFC3CXUB4NHG0up0Xr7yFvJ8Xcikc/R4mXnD53YBq5ca5dQT2ad2FPsgU/0WygBW9WOvQXzieisBQc3qOgxQ8r+JYMnhzz5sD4St0tuuodbFC2kXxn0mOP4QJSakDa8BEFDQmzg== Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:110::10) by PN3PR01MB7015.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:ab::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Mon, 17 Feb 2025 04:45:04 +0000 Received: from PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde]) by PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM ([fe80::972:abe8:752:bbde%6]) with mapi id 15.20.8445.017; Mon, 17 Feb 2025 04:45:04 +0000 From: Aditya Garg To: Jiri Kosina , "jkosina@suse.com" , Benjamin Tissoires , "bentiss@kernel.org" , Dan Carpenter CC: Orlando Chamberlain , Kerem Karabay , "linux-input@vger.kernel.org" , Linux Kernel Mailing List Subject: [PATCH v4 2/3] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Topic: [PATCH v4 2/3] HID: hid-appletb-bl: fix incorrect error message for default brightness Thread-Index: AQHbgPa24BMjEJUStUyBicLEVwkKQw== Date: Mon, 17 Feb 2025 04:45:04 +0000 Message-ID: <3AB4CA1B-6FDB-4A21-9AAF-8D72A6F12D90@live.com> References: <8365C1B3-3A38-4F6E-955B-D6BBABA6B00A@live.com> In-Reply-To: <8365C1B3-3A38-4F6E-955B-D6BBABA6B00A@live.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PN0PR01MB9608:EE_|PN3PR01MB7015:EE_ x-ms-office365-filtering-correlation-id: 2d6d20e0-06b5-4b38-cbbb-08dd4f0dd886 x-microsoft-antispam: BCL:0; ARA:14566002|8062599003|19110799003|7092599003|8060799006|461199028|15080799006|440099028|3412199025|102099032; x-microsoft-antispam-message-info: =?utf-8?q?BIe4g680nwcPWB+l1S/b7sTcQJcMZFi?= =?utf-8?q?KE7In8XHkZkuc3/TXh+qrgGJhUyjD9IHsfTCAZ2Mbfeu3edq7g+Rxi5gA0cBxJGMM?= =?utf-8?q?4cCTl0YpIHM+2gAWsjtGMCRdZcM1nzR4rXf+jjVBNITO7ApJfpJEqVgkLCxtA0OVy?= =?utf-8?q?SEjR2Dp5kccrAHSl0C+nYiSBMXUGDAl2ju08d8/qGeFNMmkw4o2DeuCoPVkGDGSY6?= =?utf-8?q?8kaHghH5MF02wuY7edqGaiCG3Wzmt6Jqq7x+D7MWeuco/BEseTTA9d9xXMIny27C/?= =?utf-8?q?E4qOoszdiL/eG2MWf+9c2/sLkQiaLdo+/xRQiCYYMyfJQXXANPmIgls7WeEZBRCDB?= =?utf-8?q?wSN0kq6jeUKIQlR9Jp5lSLNHAvnLKE4PlBNtlxWR6kOSUIfe1/oWR6vJCYibUZx2o?= =?utf-8?q?vK1rIWDk/4zG3BdAkVPGxGrDufqYDyHvrjhdIfiTurnEV0ftqJ2Hr6SYSpRqdkDkZ?= =?utf-8?q?Q0ANKdNspxsjeNYcJqjn266uXe9rnzOM9RjeKHKZVMDYeRpI0mxSJXQ3eiyvvajNv?= =?utf-8?q?lNnNQN/DoDHif/veb+OJ8/VknQaKCluNU/tsp9UoZc2RxTnKID8LAz+Lx0nPpR/5D?= =?utf-8?q?cWqUqD9bQrmvWK6qrer0oCboiqEfxmAkowQK0QZLT/XRzbWUMwOVEp8P6Ns7Njdyp?= =?utf-8?q?ffdy/T5FpEh+REdpsZtZ1/ggZ0S60Q6MGq8HlbMOXIY+mFw7LozMZTnScMlN0SmS2?= =?utf-8?q?4CISS/OVrKos0WRmXHUoflRAa8BPvWdzeJfoIiKtlH/Dn7GO7/GBuNFZnmKpgLvNC?= =?utf-8?q?U0oZLkAQ8hr9g+R+8bYrqmvs76CtPbBsVOkmG5HuL1OBsjDB17JVl34cW+a/F91YA?= =?utf-8?q?vh0g2m/kFgK5+kR5d07gqFKQjdD2Rbnpvlt+fquhMNrwCzL10CpNpTrq6wxJp5lRj?= =?utf-8?q?Uak9MF+jkESDii+K/sTsH+sBDxOFCKGaWBLfcu/9RBqJ8UHm+efgsnojTR5sMkiz4?= =?utf-8?q?ICoAP3rFdLvhbCPOURRZLz6ojKDn0Z1zDzQWVR0+j3HKsp8SSSMThZYMminDXj3cm?= =?utf-8?q?wi3aNQkxAfvlgdsS2?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?q?UqDbYJnR7dhW+K+/ccsEqctc51dd?= =?utf-8?q?CkHt7jn7Wj0Px6sZZ55mXcMJnhAyJmL1SDb9HoSEQdqsMMwzhCZsg1LjVnRziHSNx?= =?utf-8?q?7rYFUV1sReLU0blzqGimmjyz8Rrx7Ow8lGnAEDh2KHIZjdr8PLkaUSSqVmUttPDxA?= =?utf-8?q?E4zOVKqPtLxFRDP2uG4IYbv0ToNF7EVkz+21O1ty3NpgXyoBeyiq7rgpIN5ENApU4?= =?utf-8?q?Dsu07zbxWyDE+JPg70o0b9f1dkWdHsyeikHCuvo6I/XpQGznRBOswNCLY9PVzaEcS?= =?utf-8?q?XC3xLYbZz5GA/sRD2OKXWkU4jQLEj9u9CIobh8ExNAUyECyCG5OMCzfo/zrziGNXK?= =?utf-8?q?3aO9zzLlEr/+lf2waPlUapcI3M6p/aSxdt9fUGDC1vzfzOH9ui5tZZmFc2DYyC28R?= =?utf-8?q?bYoT+4Mk35iASSRWVEXhlWeFMy+KwURhEFgmaly0Q6WdU04VogAcHFjJm/vhz50RB?= =?utf-8?q?Af4tFf1hMY2RsNqiQ6XmHe6j1Lts8X7WMSI1ADuz+zK3xnhyajBwwrBx1jqTh/e+R?= =?utf-8?q?NwoK6T9LTWqPHw9wjtkfe3fYdZoL2kajUbRo9CfzlgIBql+auvIAlw5GPL5LGFWf9?= =?utf-8?q?AGdiaauJu35zJC+HAaF1/yrVhtlAbPzGlUdf8Jf/lh4JpGyrm3OxMP2GqGGOBhjAP?= =?utf-8?q?Ztc16l+s63UtyKPIWociSAcH7ltQgyZXQW/pOjyfUBRQ0rapRJacHf682vwIssgDD?= =?utf-8?q?s3JRMPHfzwopEPfmFB20pmXBlMZzbne6wFqNlkMexLkPu5vLvkNtdZuCdrJ1vrNHx?= =?utf-8?q?IXaMykyo28GOlvPR2XOMo51XB9N1T8hSqMYGNBd6lQVDYr8ectzUAdjmdiFbQE0pk?= =?utf-8?q?OuG2mKwZyko9N4uwNU7dIrieg5YSmZBByk1uO46GzDibJgm8pweQqnXqtt0QfEAwp?= =?utf-8?q?1oUxQdiu9b639k+6tGcUETRoIsmIQKIj2D13/S8CgzUstEWu/7UtKyEUHvLy7dV19?= =?utf-8?q?v8N0twXAcfqwYDpQhUknraWBo/BGU2i0xNBanh2TzTGVUGpOkF7mzgZkrU455Bwys?= =?utf-8?q?4hghJAyel07p0nVWWfGiuKsog6jWI/6pTZ+iPge81+mSIKTf2qVcOFLSvM71WwVdE?= =?utf-8?q?1+ojPnIh9BV/Yg1Csy+q19DQBZijrZ64DLr60xm1ePq5AbSrfSW3tTTF8CZCNE65c?= =?utf-8?q?H438JzBgwbdQG3OOJvgPSWSMSzNxdNnGI5I8aA0Lknwzo+3+WXlesJDRysoRx0gDD?= =?utf-8?q?PLCcIUIilYRXIdV0rhLDcRv5ktvvt1OUqPLxGtqpamR88G7Ue1dCzn6FokoN9U3XH?= =?utf-8?q?Etu7KogQBHlOfsjV?= Content-ID: Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ae5c4.templateTenant X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9608.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 2d6d20e0-06b5-4b38-cbbb-08dd4f0dd886 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2025 04:45:04.1852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB7015 From: Aditya Garg The error message responsible to show failure to set default backlight brightness incorrectly showed the intended brightness as off irrespective of what the user had set it. This patch intends to fix the same. Also, a small typo in MODULE_DESCRIPTION has been fixed. Signed-off-by: Aditya Garg --- drivers/hid/hid-appletb-bl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/hid/hid-appletb-bl.c b/drivers/hid/hid-appletb-bl.c index 1a3dcd44b..bad2aead8 100644 --- a/drivers/hid/hid-appletb-bl.c +++ b/drivers/hid/hid-appletb-bl.c @@ -145,7 +145,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]); if (ret) { - dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n"); + dev_err_probe(dev, ret, "Failed to set default touch bar brightness to %d\n", + appletb_bl_def_brightness); goto close_hw; } @@ -199,5 +200,5 @@ module_hid_driver(appletb_bl_hid_driver); MODULE_AUTHOR("Ronald Tschalär"); MODULE_AUTHOR("Kerem Karabay "); -MODULE_DESCRIPTION("MacBookPro Touch Bar Backlight Driver"); +MODULE_DESCRIPTION("MacBook Pro Touch Bar Backlight driver"); MODULE_LICENSE("GPL");