From patchwork Fri Jun 20 15:09:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Garg X-Patchwork-Id: 899158 Received: from MA0PR01CU012.outbound.protection.outlook.com (mail-southindiaazolkn19011028.outbound.protection.outlook.com [52.103.67.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC7F296169; Fri, 20 Jun 2025 15:10:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.103.67.28 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750432203; cv=fail; b=No/tuiRrv9xxXGH6k/YtUhJ8RaOyWimV7DbhuhHr5VKL746iCCKp+UW2KGmwu+Djv64Cm0h3U30LeJV0aV6FzI49CQpnUynHNhSE0a/C9MVOtr2aYAlErsmAgTzyucR1/fHA1WKHoTtH/fxGOGrCR2t5fPskmgo9E5MssfunmV8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750432203; c=relaxed/simple; bh=fggrRve2ZxKOPCbn8vzQxvCsxSOp9zdGwpW7ra5jnI8=; h=Message-ID:Date:To:Cc:From:Subject:Content-Type:MIME-Version; b=T8vK7wrP7U9WcbCJOsRWj1EFLusw+jsmzObwFQgfh6nAorzrPVkU90PUwxFfCRk/fZV0ILEtWUd9rKFIhaveveYTCaGarRZMmjBP5w0Kj9Aj/bcACLNpM55bVzd6HJ3E8oDxGtKeUz+uWMr39t73PzO1WiGvps/IpVPAM04aQUg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com; spf=pass smtp.mailfrom=live.com; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b=UpfMTHhu; arc=fail smtp.client-ip=52.103.67.28 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=live.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=live.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=live.com header.i=@live.com header.b="UpfMTHhu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=XidqIceopBUlg99RBLZ4JV3iBQXOm8xFYHW9WfJ9J3k806rr3w5HzggWgg1DVUrA2WWO2N0Cc1GsXYJsP2woH3NOVAv0ro9R32L8/7FYa1aB2KsS/eTs8W39ys58XQp8cH0jctbaxzFgwZHSih8cz88xYCl9Yk37hWxI2hGBC9jtjDWmOOfoD4GIa6Txx5q3shkNTdf6YOQmsf+jUWaYRkvcX8lwLuRGgpdMK/yFb5wZIo3F5V8xaNtrUAOiAq0x4ga9P7YMB1h5gQBcMkTf8O5nfRczqyvm6O+yDyXo9NvLr99gZYhnurkvlGEz5ZM9j1CKppHbuIjWkLDQmFXRng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UqKa0wY4bV3NTq0yibhAhBLHkogLpa1XKd1fHX8tdGo=; b=Fwndsi8PyrBOhhexkiGTsurvrNYWsUYXsZMGqZ+d1GetnAkYEQN9yI1Q6Wea1B86d0ARONjVgRnFTRRqwQUwXkt93tU3mtaw2oyRc8Vdgw47RfUxhhV9Dv71jJ0noAD0l8+MNe8n99Hlr3Y4aVnEC+KYfGJzkVi25E8XE1MXmw3CpqB8j28VYLHQ2pbzKbr8PYQWlLUaPo/Zd2VQMIoRHC7Z5ddf+nIhGLimHGguAn8y7uMLhXf34ms5XWJgdG8Wh1st7bs8TVYqOQOJKENyDYqPODPnlNAFy1eBvorXv5q1oajCm6IU5dsNcEgQzixTz0sPPIlXCdvp5X4NDKyxCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=live.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqKa0wY4bV3NTq0yibhAhBLHkogLpa1XKd1fHX8tdGo=; b=UpfMTHhuJKizgaT68UO6kRRInwg+t3Et4N4MOeZrdLpB6Kh4usfXWCasPuZ6bdeLEGSAC7QiQCteNhb16JuEN1vtOOtvQX+aFLiBklVu3Jtgn5upr+lx9GHiPCGfP1ug0dZvEmGOgVmgVcKNTbKGGQoUfbGjJVS/fBKoVfhycgetVN80GsQawoIx/vhFGHtzPDgY+C1SqsVrCSrtEqswp987Gojipxu3Mqj/ZibKL3m8v+vP+7FbMvvACInCVgdZkZvjzfiHLgsap0aiL5vidxmH1blhwmqGLfdlf7BZES6MnvCls3Y2EIkkQzqMGz8FqkaEpnNpFgbcwaS57dBtdg== Received: from PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:10c::9) by PN3PR01MB9872.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:171::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8857.25; Fri, 20 Jun 2025 15:09:58 +0000 Received: from PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM ([fe80::5b05:29d:5646:39aa]) by PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM ([fe80::5b05:29d:5646:39aa%7]) with mapi id 15.20.8857.022; Fri, 20 Jun 2025 15:09:58 +0000 Message-ID: Date: Fri, 20 Jun 2025 20:39:45 +0530 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Jiri Kosina , Benjamin Tissoires Cc: Linux Kernel Mailing List , "linux-input@vger.kernel.org" From: Aditya Garg Subject: [PATCH RESEND] HID: magicmouse: enclose macros with complex values in parentheses X-ClientProxiedBy: PN4P287CA0027.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:26f::16) To PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:10c::9) X-Microsoft-Original-Message-ID: <6058720c-7263-4f6a-8982-1a35529921a8@live.com> Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PN0PR01MB9588:EE_|PN3PR01MB9872:EE_ X-MS-Office365-Filtering-Correlation-Id: fbf67848-8117-413b-e4b0-08ddb00c83e2 X-Microsoft-Antispam: BCL:0; ARA:14566002|15080799009|7092599006|8060799009|19110799006|8022599003|5072599009|6090799003|5062599005|461199028|3412199025|440099028; X-Microsoft-Antispam-Message-Info: =?utf-8?q?vNlljI9/ar9OfUDUNNJq1efErndgcKt?= =?utf-8?q?T2BaaMvv11z6tHkNIiDI6d3fGs3RMphRoFgIOEdpjhI41CnluK8EIBPzXVLy7JNa8?= =?utf-8?q?IWC8MQmwUFdEo3KQpFrAx4yhMW1qArZ3XIRcMh7+EKx70L4Zkfn20uUIfVSdxUt7n?= =?utf-8?q?Cw8DM7H/hUNkJWnI0VDUfN64EZHpN8a2m5P09bCCaaB9WzMsbt7hikcQ7yaookmp8?= =?utf-8?q?CrDAVpnUy700rGyOwbbS0d9egZePyxDEL0VZPNm4qv+qV5U9+6geOwZZ1Vozhwnki?= =?utf-8?q?/CNYu/yUILniwtDhYtX+FtclVTRLmlgZm13ZFOha2NAxQGwQXbZUCQ57W4RgFRohy?= =?utf-8?q?vbw6cT7fn+keqANyuebdSf7TsujKOQQicYwaz7pznRlwVFKLweO3/mBjNnGxnB1Lf?= =?utf-8?q?aRb7D4vHJOyie+0msl5+/66aLLF/cZVZ0xiV0ZPiASC3zPVerMVdLCdnwI0H0RAX4?= =?utf-8?q?WqGPlHutM8T6JfBuzuRcoTx9a1fKCEeJvlA4vF588APB448TulyefjSe+I1UjVsPP?= =?utf-8?q?GQYenfxfnlCTp9U56kXDRjS2aOU5Bxt6rVgs3rZhKwThG8J4WXHtoWcYZ7qYo/SXR?= =?utf-8?q?UR/tk6hI5luVk53lXF766SBrxXk5BublaFy9Zz8wQ5zhdth7k2LHfl7TGP+FPruJD?= =?utf-8?q?6a1yjrHTasYvYFavxsWbCnzGtgGKBoDKuaDZLVbEJKrdP+sO0U2O8+IU01iBJ+oBM?= =?utf-8?q?3LHUry2ADnIB4asCmZKkCYoChShz/YjsGJhkS69VL55XtXruPxjfsGgKivYt5J/pe?= =?utf-8?q?gZTNkOsysusKcindjes8G3JrVgG0/zbdiTWm4xgoJxKRSQ3Y/h/QHZa3paIy35w8A?= =?utf-8?q?WVR+zNCrD33UgQ8HWtDF3W4WY5mHVIAyzj2fw8OaG3JXQ0WNOUTPVDBQ5bo+tAVdg?= =?utf-8?q?d5jE7CFEbB24uO85DViSZXGBxPJhwl7PbYcrGB4Rg1Ffn0RbkvEihosb+bhs2SAZW?= =?utf-8?q?gTMm6BvdsNI8ADoCJhAE9ZgA8+C5GSMn5Cf/EtFAV5kUM/+pMR9v15bhcbMzCCl3W?= =?utf-8?q?Lj2sjGaTwdUJxdK8kZcfKrY1Uw2FXhyyPPFEX1Dj5isy2m8lMf+7y0fBYzzU2zF2j?= =?utf-8?q?l/0+MIKN6qaian0HF1nvNXix6hKLoRCj/Bdth8I6vuai6oglQz9oCPMIxoez11nVG?= =?utf-8?q?APbFwYUAflQNmoZ?= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?XPHj6RgwAIlKUmS7Maw7CDYULtEV?= =?utf-8?q?er0V04e3k+8uaROL6WdPUrET5A5xlQiL0p+1PRybE0vuf7BhJwa39KD8XxGC6FUpw?= =?utf-8?q?AJyvedP1NHpY2sdBVgtvyghP1/FdJsT+8RXFvsmcuSF3xEgp7XZhBO9+I95t9PADZ?= =?utf-8?q?z8d55UuHVhQV3Em+EvSdGfkEoeK/rQD7qqaKoqsxcNvp4bPuGYPW6GECxr8gZeacj?= =?utf-8?q?kRoSqRMUnUEeJ/SYNciVIKxXKfY4xrgyRt5mPTwk/forBReBGpHR7vFRcUG3HMMrA?= =?utf-8?q?FFfKj7f2Of22y8gxPCoybDChXW92fuIoJlkcQohbBsljF2YxKRVFJ9ilWF9SH5htv?= =?utf-8?q?za5ynHXIObFn6TOSYpRhDYXAnGwBE0Sdz14AchTfZn82gy5hiKg6CN/as+dlOsSlV?= =?utf-8?q?c+0fPTAtj/cyDGoE94qm+yOx9dcpeNvGaboIXlbUIRO5ujEGWZKqWt95fhYDO/RqW?= =?utf-8?q?tAsQ3AtpU0maMVCRNUaMaGDNrPRqt6vd9IWBm2uwJDIRxPAFnHHEc71lpJYlltx/G?= =?utf-8?q?2+ksFty3A8OKza6uH7PqCLmZxcRszloxGgzUUbmz+weDnWIudygexDqzKfgYd5MRy?= =?utf-8?q?DlMmmzZia4GpzdUk+LthaDCrEvuMt/QU5SAnCXCTlKHP4z+FOjU2+pfLISt029c5r?= =?utf-8?q?8hGPJ0UvjWtptdwXQP/ZCE4fHxgctzcL99gvvpz4qS0e9xSAZY6chgJnXV9t5B2BA?= =?utf-8?q?DTpFgQct+Ai8X/OqIM1Ju2FXsKlF8UiWTH0Vdl7nlukvbOvxXKeu4ucJg89Wucm/F?= =?utf-8?q?+W0wQJkQfaIwPVFYLbqJaZ6s5POvAyNAVFiyrgqOaC/dwMy8qhrWE0ggkgYvIMxZG?= =?utf-8?q?Tkq5Q0awBHQJwaOecMyW+1j2/GrHRwJCs5LPUI8K/4ZRcemtdPfUGf4+f656Epi1X?= =?utf-8?q?np+mq5INVF0zHHbLa7K7GJ6UeKBiPTpU5mC+/jLniU6ZdklpkoOZczYgsJj/fYc59?= =?utf-8?q?lJX/zLTnmY4aq6m4s41v+MBTeH0i4k64C2+IdQMK8vKBeeoO+85oCowl8OGdy++PA?= =?utf-8?q?1D0/A7k1dsysWsnN3Q1ZntkPUhDpoCjIx81niS/cw8AvDx6CiSVXwy8mx7pHqNtXj?= =?utf-8?q?b5UJJVykPZSI9MO8FAPWBnvXg8c8/qhewfdG+z7lQh6zuHyKzI5/fduoNpZA6tf48?= =?utf-8?q?A9+lIpi436sBMHFEXOtw6wnj1COjyb+opvG8SkWQIlpoLNKQsC7dMoIyNT7pLRsPF?= =?utf-8?q?5CTfecPW4bezW2XqPq4r/uQnMdfdgXb94CxET+MA8gj5WH2pGM/jrcM4deFA=3D?= X-OriginatorOrg: sct-15-20-8813-0-msonline-outlook-f2c18.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: fbf67848-8117-413b-e4b0-08ddb00c83e2 X-MS-Exchange-CrossTenant-AuthSource: PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2025 15:09:58.4132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3PR01MB9872 Checkpatch reported this error: ERROR: Macros with complex values should be enclosed in parentheses This patch is a simple fix for the same. Signed-off-by: Aditya Garg --- drivers/hid/hid-magicmouse.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c index a76f17158..d83909761 100644 --- a/drivers/hid/hid-magicmouse.c +++ b/drivers/hid/hid-magicmouse.c @@ -81,32 +81,32 @@ MODULE_PARM_DESC(report_undeciphered, "Report undeciphered multi-touch state fie /* Touch surface information. Dimension is in hundredths of a mm, min and max * are in units. */ -#define MOUSE_DIMENSION_X (float)9056 +#define MOUSE_DIMENSION_X ((float)9056) #define MOUSE_MIN_X -1100 #define MOUSE_MAX_X 1258 #define MOUSE_RES_X ((MOUSE_MAX_X - MOUSE_MIN_X) / (MOUSE_DIMENSION_X / 100)) -#define MOUSE_DIMENSION_Y (float)5152 +#define MOUSE_DIMENSION_Y ((float)5152) #define MOUSE_MIN_Y -1589 #define MOUSE_MAX_Y 2047 #define MOUSE_RES_Y ((MOUSE_MAX_Y - MOUSE_MIN_Y) / (MOUSE_DIMENSION_Y / 100)) -#define TRACKPAD_DIMENSION_X (float)13000 +#define TRACKPAD_DIMENSION_X ((float)13000) #define TRACKPAD_MIN_X -2909 #define TRACKPAD_MAX_X 3167 #define TRACKPAD_RES_X \ ((TRACKPAD_MAX_X - TRACKPAD_MIN_X) / (TRACKPAD_DIMENSION_X / 100)) -#define TRACKPAD_DIMENSION_Y (float)11000 +#define TRACKPAD_DIMENSION_Y ((float)11000) #define TRACKPAD_MIN_Y -2456 #define TRACKPAD_MAX_Y 2565 #define TRACKPAD_RES_Y \ ((TRACKPAD_MAX_Y - TRACKPAD_MIN_Y) / (TRACKPAD_DIMENSION_Y / 100)) -#define TRACKPAD2_DIMENSION_X (float)16000 +#define TRACKPAD2_DIMENSION_X ((float)16000) #define TRACKPAD2_MIN_X -3678 #define TRACKPAD2_MAX_X 3934 #define TRACKPAD2_RES_X \ ((TRACKPAD2_MAX_X - TRACKPAD2_MIN_X) / (TRACKPAD2_DIMENSION_X / 100)) -#define TRACKPAD2_DIMENSION_Y (float)11490 +#define TRACKPAD2_DIMENSION_Y ((float)11490) #define TRACKPAD2_MIN_Y -2478 #define TRACKPAD2_MAX_Y 2587 #define TRACKPAD2_RES_Y \