| Message ID | 20240223-upstream-net-next-20240223-misc-improvements-v1-0-b6c8a10396bd@kernel.org |
|---|---|
| Headers | show |
| Series | mptcp: various small improvements | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 23 Feb 2024 21:17:52 +0100 you wrote: > This series brings various small improvements to MPTCP and its > selftests: > > Patch 1 prints an error if there are duplicated subtests names. It is > important to have unique (sub)tests names in TAP, because some CI > environments drop (sub)tests with duplicated names. > > [...] Here is the summary with links: - [net-next,1/8] selftests: mptcp: lib: catch duplicated subtest entries https://git.kernel.org/netdev/net-next/c/9da74836740d - [net-next,2/8] mptcp: token kunit: set protocol https://git.kernel.org/netdev/net-next/c/28de50eeb734 - [net-next,3/8] mptcp: check the protocol in tcp_sk() with DEBUG_NET https://git.kernel.org/netdev/net-next/c/dcc03f270d1e - [net-next,4/8] mptcp: check the protocol in mptcp_sk() with DEBUG_NET https://git.kernel.org/netdev/net-next/c/14d29ec5302c - [net-next,5/8] selftests: mptcp: netlink: drop duplicate var ret https://git.kernel.org/netdev/net-next/c/488ccbe76cb4 - [net-next,6/8] selftests: mptcp: simult flows: define missing vars https://git.kernel.org/netdev/net-next/c/fccf7c922459 - [net-next,7/8] selftests: mptcp: join: change capture/checksum as bool https://git.kernel.org/netdev/net-next/c/8c6f6b4bb53a - [net-next,8/8] selftests: mptcp: diag: change timeout_poll to 30 https://git.kernel.org/netdev/net-next/c/e8ddc5f255c3 You are awesome, thank you!
This series brings various small improvements to MPTCP and its selftests: Patch 1 prints an error if there are duplicated subtests names. It is important to have unique (sub)tests names in TAP, because some CI environments drop (sub)tests with duplicated names. Patch 2 is a preparation for patches 3 and 4, which check the protocol in tcp_sk() and mptcp_sk() with DEBUG_NET, only in code from net/mptcp/. We recently had the case where an MPTCP socket was wrongly treated as a TCP one, and fuzzers and static checkers never spot the issue. This would prevent such issues in the future. Patches 5 to 7 are some cleanup for the MPTCP selftests. These patches are not supposed to change the behaviour. Patch 8 sets the poll timeout in diag selftest to the same value as the one used in the other selftests. Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Geliang Tang (4): selftests: mptcp: netlink: drop duplicate var ret selftests: mptcp: simult flows: define missing vars selftests: mptcp: join: change capture/checksum as bool selftests: mptcp: diag: change timeout_poll to 30 Matthieu Baerts (NGI0) (4): selftests: mptcp: lib: catch duplicated subtest entries mptcp: token kunit: set protocol mptcp: check the protocol in tcp_sk() with DEBUG_NET mptcp: check the protocol in mptcp_sk() with DEBUG_NET net/mptcp/protocol.h | 16 ++++++++++++++++ net/mptcp/token_test.c | 7 ++++++- tools/testing/selftests/net/mptcp/diag.sh | 2 +- tools/testing/selftests/net/mptcp/mptcp_join.sh | 22 +++++++++++----------- tools/testing/selftests/net/mptcp/mptcp_lib.sh | 21 +++++++++++++++++++++ tools/testing/selftests/net/mptcp/pm_netlink.sh | 1 - tools/testing/selftests/net/mptcp/simult_flows.sh | 6 ++++++ 7 files changed, 61 insertions(+), 14 deletions(-) --- base-commit: a818bd12538c1408c7480de31573cdb3c3c0926f change-id: 20240223-upstream-net-next-20240223-misc-improvements-7d64a076bca8 Best regards,