| Message ID | 20240325-kselftest-ftrace-ktap-verbose-v1-0-3785199809da@kernel.org |
|---|---|
| Headers | show |
| Series | tracing/selftests: Verbosity improvements to KTAP output | expand |
Shuah, If Masami is OK with this, can you take this through your tree? Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> -- Steve On Mon, 25 Mar 2024 16:15:49 +0000 Mark Brown <broonie@kernel.org> wrote: > This series aims to improve the usability of the ftrace selftests when > running as part of the kselftest runner, mainly for use with automated > systems. It fixes the output of verbose mode when run in KTAP output > mode and then enables verbose mode by default when invoked from the > kselftest runner so that the diagnostic information is there by default > when run in automated systems. > > I've split this into two patches in case there is a concern with one > part but not the other, especially given the verbosity of the verbose > output when it triggers. > > Signed-off-by: Mark Brown <broonie@kernel.org> > --- > Mark Brown (2): > tracing/selftests: Support log output when generating KTAP output > tracing/selftests: Default to verbose mode when running in kselftest > > tools/testing/selftests/ftrace/ftracetest | 8 +++++++- > tools/testing/selftests/ftrace/ftracetest-ktap | 2 +- > 2 files changed, 8 insertions(+), 2 deletions(-) > --- > base-commit: 4cece764965020c22cff7665b18a012006359095 > change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213 > > Best regards,
On 3/26/24 10:08, Steven Rostedt wrote: > > Shuah, > > If Masami is OK with this, can you take this through your tree? > > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> > > -- Steve > > Yes. Will do once Masami gives me the okay. > On Mon, 25 Mar 2024 16:15:49 +0000 > Mark Brown <broonie@kernel.org> wrote: > >> This series aims to improve the usability of the ftrace selftests when >> running as part of the kselftest runner, mainly for use with automated >> systems. It fixes the output of verbose mode when run in KTAP output >> mode and then enables verbose mode by default when invoked from the >> kselftest runner so that the diagnostic information is there by default >> when run in automated systems. >> >> I've split this into two patches in case there is a concern with one >> part but not the other, especially given the verbosity of the verbose >> output when it triggers. >> >> Signed-off-by: Mark Brown <broonie@kernel.org> >> --- >> Mark Brown (2): >> tracing/selftests: Support log output when generating KTAP output >> tracing/selftests: Default to verbose mode when running in kselftest >> >> tools/testing/selftests/ftrace/ftracetest | 8 +++++++- >> tools/testing/selftests/ftrace/ftracetest-ktap | 2 +- >> 2 files changed, 8 insertions(+), 2 deletions(-) >> --- >> base-commit: 4cece764965020c22cff7665b18a012006359095 >> change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213 >> >> Best regards, > thanks, -- Shuah
On Thu, 4 Apr 2024 10:32:33 -0600 Shuah Khan <skhan@linuxfoundation.org> wrote: > On 3/26/24 13:11, Shuah Khan wrote: > > On 3/26/24 10:08, Steven Rostedt wrote: > >> > >> Shuah, > >> > >> If Masami is OK with this, can you take this through your tree? > >> > >> Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org> > >> > >> -- Steve > >> > >> > > > > Yes. Will do once Masami gives me the okay > Hi Masami, > > Are you okay with this patch? Hi Shuah and Mark, Sorry, I missed this series. This looks good to me. Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Thank you! > > thanks, > -- Shuah > >
On 3/25/24 9:15 PM, Mark Brown wrote: > When -v is specified ftracetest will dump logs of test execution to the > console which if -K is also specified for KTAP output will result in > output that is not properly KTAP formatted. All that's required for KTAP > formatting is that anything we log have a '#' at the start of the line so > we can improve things by washing the output through a simple read loop. > This will help automated parsers when verbose mode is enabled. > > Signed-off-by: Mark Brown <broonie@kernel.org> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com> > --- > tools/testing/selftests/ftrace/ftracetest | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest > index 25d4e0fca385..cce72f8b03dc 100755 > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -255,7 +255,13 @@ prlog() { # messages > [ "$LOG_FILE" ] && printf "$*$newline" | strip_esc >> $LOG_FILE > } > catlog() { #file > - cat $1 > + if [ "${KTAP}" = "1" ]; then > + cat $1 | while read line ; do > + echo "# $line" > + done > + else > + cat $1 > + fi > [ "$LOG_FILE" ] && cat $1 | strip_esc >> $LOG_FILE > } > prlog "=== Ftrace unit tests ===" >
This series aims to improve the usability of the ftrace selftests when running as part of the kselftest runner, mainly for use with automated systems. It fixes the output of verbose mode when run in KTAP output mode and then enables verbose mode by default when invoked from the kselftest runner so that the diagnostic information is there by default when run in automated systems. I've split this into two patches in case there is a concern with one part but not the other, especially given the verbosity of the verbose output when it triggers. Signed-off-by: Mark Brown <broonie@kernel.org> --- Mark Brown (2): tracing/selftests: Support log output when generating KTAP output tracing/selftests: Default to verbose mode when running in kselftest tools/testing/selftests/ftrace/ftracetest | 8 +++++++- tools/testing/selftests/ftrace/ftracetest-ktap | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) --- base-commit: 4cece764965020c22cff7665b18a012006359095 change-id: 20240319-kselftest-ftrace-ktap-verbose-72e37957e213 Best regards,