mbox series

[net,0/2] mptcp: fix fallback MIB counter and wrong var in selftests

Message ID 20240329-upstream-net-20240329-fallback-mib-v1-0-324a8981da48@kernel.org
Headers show
Series mptcp: fix fallback MIB counter and wrong var in selftests | expand

Message

Matthieu Baerts (NGI0) March 29, 2024, 12:08 p.m. UTC
Here are two fixes related to MPTCP.

The first patch fixes when the MPTcpExtMPCapableFallbackACK MIB counter
is modified: it should only be incremented when a connection was using
MPTCP options, but then a fallback to TCP has been done. This patch also
checks the counter is not incremented by mistake during the connect
selftests. This counter was wrongly incremented since its introduction
in v5.7.

The second patch fixes a wrong parsing of the 'dev' endpoint options in
the selftests: the wrong variable was used. This option was not used
before, but it is going to be soon. This issue is visible since v5.18.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Davide Caratti (1):
      mptcp: don't account accept() of non-MPC client as fallback to TCP

Geliang Tang (1):
      selftests: mptcp: join: fix dev in check_endpoint

 net/mptcp/protocol.c                               | 2 --
 net/mptcp/subflow.c                                | 2 ++
 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 9 +++++++++
 tools/testing/selftests/net/mptcp/mptcp_join.sh    | 4 +++-
 4 files changed, 14 insertions(+), 3 deletions(-)
---
base-commit: 0ba80d96585662299d4ea4624043759ce9015421
change-id: 20240329-upstream-net-20240329-fallback-mib-b0fec9c6189b

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org April 2, 2024, 4:50 a.m. UTC | #1
Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 29 Mar 2024 13:08:51 +0100 you wrote:
> Here are two fixes related to MPTCP.
> 
> The first patch fixes when the MPTcpExtMPCapableFallbackACK MIB counter
> is modified: it should only be incremented when a connection was using
> MPTCP options, but then a fallback to TCP has been done. This patch also
> checks the counter is not incremented by mistake during the connect
> selftests. This counter was wrongly incremented since its introduction
> in v5.7.
> 
> [...]

Here is the summary with links:
  - [net,1/2] mptcp: don't account accept() of non-MPC client as fallback to TCP
    https://git.kernel.org/netdev/net/c/7a1b3490f47e
  - [net,2/2] selftests: mptcp: join: fix dev in check_endpoint
    https://git.kernel.org/netdev/net/c/40061817d95b

You are awesome, thank you!