| Message ID | 20250213-quiet_tools-v3-0-07de4482a581@rivosinc.com |
|---|---|
| Headers | show |
| Series | tools: Unify top-level quiet infrastructure | expand |
On Thu, Feb 13, 2025 at 01:06:20PM -0800, Charlie Jenkins wrote: > The quiet infrastructure was moved out of Makefile.build to accomidate > the new syscall table generation scripts in perf. Syscall table > generation wanted to also be able to be quiet, so instead of again > copying the code to set the quiet variables, the code was moved into > Makefile.perf to be used globally. This was not the right solution. It > should have been moved even further upwards in the call chain. > Makefile.include is imported in many files so this seems like a proper > place to put it. > > To: > > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com> > --- > Changes in v3: > - Add back erroneously removed "silent=1" (Jiri) > - Link to v2: https://lore.kernel.org/r/20250210-quiet_tools-v2-0-b2f18cbf72af@rivosinc.com Reviewed-by: Jiri Olsa <jolsa@kernel.org> thanks, jirka > > Changes in v2: > - Fix spacing around Q= (Andrii) > - Link to v1: https://lore.kernel.org/r/20250203-quiet_tools-v1-0-d25c8956e59a@rivosinc.com > > --- > Charlie Jenkins (2): > tools: Unify top-level quiet infrastructure > tools: Remove redundant quiet setup > > tools/arch/arm64/tools/Makefile | 6 ----- > tools/bpf/Makefile | 6 ----- > tools/bpf/bpftool/Documentation/Makefile | 6 ----- > tools/bpf/bpftool/Makefile | 6 ----- > tools/bpf/resolve_btfids/Makefile | 2 -- > tools/bpf/runqslower/Makefile | 5 +--- > tools/build/Makefile | 8 +----- > tools/lib/bpf/Makefile | 13 ---------- > tools/lib/perf/Makefile | 13 ---------- > tools/lib/thermal/Makefile | 13 ---------- > tools/objtool/Makefile | 6 ----- > tools/perf/Makefile.perf | 41 ------------------------------- > tools/scripts/Makefile.include | 30 ++++++++++++++++++++++ > tools/testing/selftests/bpf/Makefile.docs | 6 ----- > tools/testing/selftests/hid/Makefile | 2 -- > tools/thermal/lib/Makefile | 13 ---------- > tools/tracing/latency/Makefile | 6 ----- > tools/tracing/rtla/Makefile | 6 ----- > tools/verification/rv/Makefile | 6 ----- > 19 files changed, 32 insertions(+), 162 deletions(-) > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250203-quiet_tools-9a6ea9d65a19 > -- > - Charlie >
The quiet infrastructure was moved out of Makefile.build to accomidate the new syscall table generation scripts in perf. Syscall table generation wanted to also be able to be quiet, so instead of again copying the code to set the quiet variables, the code was moved into Makefile.perf to be used globally. This was not the right solution. It should have been moved even further upwards in the call chain. Makefile.include is imported in many files so this seems like a proper place to put it. To: Signed-off-by: Charlie Jenkins <charlie@rivosinc.com> --- Changes in v3: - Add back erroneously removed "silent=1" (Jiri) - Link to v2: https://lore.kernel.org/r/20250210-quiet_tools-v2-0-b2f18cbf72af@rivosinc.com Changes in v2: - Fix spacing around Q= (Andrii) - Link to v1: https://lore.kernel.org/r/20250203-quiet_tools-v1-0-d25c8956e59a@rivosinc.com --- Charlie Jenkins (2): tools: Unify top-level quiet infrastructure tools: Remove redundant quiet setup tools/arch/arm64/tools/Makefile | 6 ----- tools/bpf/Makefile | 6 ----- tools/bpf/bpftool/Documentation/Makefile | 6 ----- tools/bpf/bpftool/Makefile | 6 ----- tools/bpf/resolve_btfids/Makefile | 2 -- tools/bpf/runqslower/Makefile | 5 +--- tools/build/Makefile | 8 +----- tools/lib/bpf/Makefile | 13 ---------- tools/lib/perf/Makefile | 13 ---------- tools/lib/thermal/Makefile | 13 ---------- tools/objtool/Makefile | 6 ----- tools/perf/Makefile.perf | 41 ------------------------------- tools/scripts/Makefile.include | 30 ++++++++++++++++++++++ tools/testing/selftests/bpf/Makefile.docs | 6 ----- tools/testing/selftests/hid/Makefile | 2 -- tools/thermal/lib/Makefile | 13 ---------- tools/tracing/latency/Makefile | 6 ----- tools/tracing/rtla/Makefile | 6 ----- tools/verification/rv/Makefile | 6 ----- 19 files changed, 32 insertions(+), 162 deletions(-) --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250203-quiet_tools-9a6ea9d65a19