| Message ID | 20250217-tc_links-v1-0-27f7965e3dcd@bootlin.com |
|---|---|
| Headers | show |
| Series | selftests/bpf: tc_links/tc_opts: Unserialize tests | expand |
On 02/17, Bastien Curutchet (eBPF Foundation) wrote: > Hi all, > > Both tc_links.c and tc_opts.c do their tests on the loopback interface. > It prevents from parallelizing their executions. > > Use namespaces and the new append_tid() helper to allow this > parallelization. > > Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com> Acked-by: Stanislav Fomichev <sdf@fomichev.me> LGTM, thank you! Optionally, if there is more to convert, we can think about moving create_and_open_tid_ns to the test_progs itself. For example, if the test name starts with ns_, test_progs can probably do the create_and_open_tid_ns/netns_free part?
On Tue, Feb 18, 2025 at 1:22 PM Stanislav Fomichev <stfomichev@gmail.com> wrote: > > On 02/17, Bastien Curutchet (eBPF Foundation) wrote: > > Hi all, > > > > Both tc_links.c and tc_opts.c do their tests on the loopback interface. > > It prevents from parallelizing their executions. > > > > Use namespaces and the new append_tid() helper to allow this > > parallelization. > > > > Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com> > > Acked-by: Stanislav Fomichev <sdf@fomichev.me> > > LGTM, thank you! Optionally, if there is more to convert, we can think > about moving create_and_open_tid_ns to the test_progs itself. For example, > if the test name starts with ns_, test_progs can probably do the > create_and_open_tid_ns/netns_free part? That's a good idea. Let's do it now. Otherwise most of the patch 2 will be reverted when it's introduced. pw-bot: cr
Hi all, Both tc_links.c and tc_opts.c do their tests on the loopback interface. It prevents from parallelizing their executions. Use namespaces and the new append_tid() helper to allow this parallelization. Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@bootlin.com> --- Bastien Curutchet (eBPF Foundation) (3): selftests/bpf: tc_helpers: Add create_and_open_tid_ns() selftests/bpf: tc_link/tc_opts: Use unique namespace selftests/bpf: tc_links/tc_opts: Serialize tests .../testing/selftests/bpf/prog_tests/tc_helpers.h | 12 ++ tools/testing/selftests/bpf/prog_tests/tc_links.c | 164 +++++++++++++-- tools/testing/selftests/bpf/prog_tests/tc_opts.c | 230 ++++++++++++++++++--- 3 files changed, 361 insertions(+), 45 deletions(-) --- base-commit: cfed0f474a4bb2f12b54de5d6a7301cfb7dc0dbd change-id: 20250128-tc_links-d894a23b7063 Best regards,