mbox series

[bpf-next,v5,0/6] use network helpers, part 1

Message ID cover.1713427236.git.tanggeliang@kylinos.cn
Headers show
Series use network helpers, part 1 | expand

Message

Geliang Tang April 18, 2024, 8:09 a.m. UTC
From: Geliang Tang <tanggeliang@kylinos.cn>

v5:
 - address Martin's comments for v4. (thanks)
 - drop start_server_addr_opts, add opts as a argument of
   start_server_addr.
 - add opts argument for connect_to_addr too.
 - move some patches out of this set, stay with start_server_addr()
   and connect_to_addr() only in it.

v4:
 - add more patches using make_sockaddr and get_socket_local_port
   helpers.

v3:
 - address comments of Martin and Eduard in v2. (thanks)
 - move "int type" to the first argument of start_server_addr and
   connect_to_addr.
 - add start_server_addr_opts.
 - using "sockaddr_storage" instead of "sockaddr".
 - move start_server_setsockopt patches out of this series.

v2:
 - update patch 6 only, fix errors reported by CI.

This patchset uses public helpers start_server_* and connect_to_* defined
in network_helpers.c to drop duplicate code.

Geliang Tang (6):
  selftests/bpf: Add start_server_addr helper
  selftests/bpf: Use start_server_addr in cls_redirect
  selftests/bpf: Use start_server_addr in sk_assign
  selftests/bpf: Update arguments of connect_to_addr
  selftests/bpf: Use connect_to_addr in cls_redirect
  selftests/bpf: Use connect_to_addr in sk_assign

 tools/testing/selftests/bpf/network_helpers.c | 27 +++++++--
 tools/testing/selftests/bpf/network_helpers.h |  5 +-
 .../selftests/bpf/prog_tests/cls_redirect.c   | 38 +------------
 .../selftests/bpf/prog_tests/sk_assign.c      | 55 ++-----------------
 .../selftests/bpf/prog_tests/sock_addr.c      |  6 +-
 5 files changed, 37 insertions(+), 94 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org April 20, 2024, 1:10 a.m. UTC | #1
Hello:

This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Thu, 18 Apr 2024 16:09:06 +0800 you wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v5:
>  - address Martin's comments for v4. (thanks)
>  - drop start_server_addr_opts, add opts as a argument of
>    start_server_addr.
>  - add opts argument for connect_to_addr too.
>  - move some patches out of this set, stay with start_server_addr()
>    and connect_to_addr() only in it.
> 
> [...]

Here is the summary with links:
  - [bpf-next,v5,1/6] selftests/bpf: Add start_server_addr helper
    https://git.kernel.org/bpf/bpf-next/c/9c598a83b7ea
  - [bpf-next,v5,2/6] selftests/bpf: Use start_server_addr in cls_redirect
    https://git.kernel.org/bpf/bpf-next/c/9851382fb369
  - [bpf-next,v5,3/6] selftests/bpf: Use start_server_addr in sk_assign
    https://git.kernel.org/bpf/bpf-next/c/a2e4979536c4
  - [bpf-next,v5,4/6] selftests/bpf: Update arguments of connect_to_addr
    https://git.kernel.org/bpf/bpf-next/c/db9994d022ec
  - [bpf-next,v5,5/6] selftests/bpf: Use connect_to_addr in cls_redirect
    https://git.kernel.org/bpf/bpf-next/c/805b4d90c0df
  - [bpf-next,v5,6/6] selftests/bpf: Use connect_to_addr in sk_assign
    https://git.kernel.org/bpf/bpf-next/c/63a51820d29b

You are awesome, thank you!