From patchwork Fri Jan 17 13:36:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 208925 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C4DC33CBA for ; Fri, 17 Jan 2020 13:37:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B506020728 for ; Fri, 17 Jan 2020 13:37:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YMfpadaZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbgAQNhm (ORCPT ); Fri, 17 Jan 2020 08:37:42 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:50879 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727126AbgAQNgo (ORCPT ); Fri, 17 Jan 2020 08:36:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579268203; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=YMfpadaZgMdxUZqJQ2qP5X2mbfOfxXrEdMtLIhuSny7Blnuzxdj3zeakBnQd/Z5fmBcx++ tJt+mf8B2L65iBT09ubkyqwk2yI+TYV9LOx0Z5A6rxM+AS4HdOyCq6uGhLJGvZ+OIlXLEx XtyhCMosgSVBIgQD0RQEk1rHfeF2zlU= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-_N2igFNjM9a1rqgdOYIReA-1; Fri, 17 Jan 2020 08:36:41 -0500 X-MC-Unique: _N2igFNjM9a1rqgdOYIReA-1 Received: by mail-lf1-f69.google.com with SMTP id t8so4356923lfc.21 for ; Fri, 17 Jan 2020 05:36:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=oVICxkwYE819T09jumS9b6kqZZVW9alGabNhw2Byv4c=; b=gBKrQjWJtd+f/ls8T3n/CjwsHs8+HeQGPMkCsJsXDJwdu4GPxEKlMok571jjPrT2ux 39bqLOMjZZFBj9eMuxqFjMGMvrcPT+tERQu7UW7+Gn4OfU7bvsyyMh4zk1LXHsNn6zRt 71HKiUqqm1QSljXbvOGEHoA95A/MsrJAFPg4vm4twMa+Ry+3oTaHqvWB+syyIerAeYVI 7laW2DJkVsbmHljfbwGLcS2sFC5rgeR2jLe6IxIS4J2mF7peQdArhxgEkdhkwqHYsmQU UP8bVW0t1p2jT5u+plP84giwoSQoz4YTZhIBUWxQ9bOd+UVtK5w1ahkFTDDTkEg2fPQa LwEg== X-Gm-Message-State: APjAAAW68QYknq7uMFU7fmR+vsS6LCtPrzIhr08Mh9Zz5sdJSvuDg6Ei A5TkYxrt4eUQumajTFwWg8sIHqrtQyqVmw4G7C2Q/0aKgCsBEYnw9q2/KRfTJXJFKQ0fqdClecA WqmKHcqLiehW0/E7NfsNJ1+w/atY+ X-Received: by 2002:a2e:3504:: with SMTP id z4mr5730211ljz.273.1579268199913; Fri, 17 Jan 2020 05:36:39 -0800 (PST) X-Google-Smtp-Source: APXvYqylN+0GVMNBaohq3jT5bbBFBEpPomA9QCEg65LVnS53cMW7Nhrc9Od5tPVFSrsyp0I8uvYr0A== X-Received: by 2002:a2e:3504:: with SMTP id z4mr5730180ljz.273.1579268199696; Fri, 17 Jan 2020 05:36:39 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id w1sm11999480lfe.96.2020.01.17.05.36.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 05:36:39 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 317BF1804D7; Fri, 17 Jan 2020 14:36:38 +0100 (CET) Subject: [PATCH bpf-next v4 01/10] samples/bpf: Don't try to remove user's homedir on clean From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Alexei Starovoitov Cc: Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , Doug Ledford , Jason Gunthorpe , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Shuah Khan , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kselftest@vger.kernel.org, clang-built-linux@googlegroups.com Date: Fri, 17 Jan 2020 14:36:38 +0100 Message-ID: <157926819814.1555735.13181807141455624178.stgit@toke.dk> In-Reply-To: <157926819690.1555735.10756593211671752826.stgit@toke.dk> References: <157926819690.1555735.10756593211671752826.stgit@toke.dk> User-Agent: StGit/0.21 MIME-Version: 1.0 Sender: linux-kselftest-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org From: Toke Høiland-Jørgensen The 'clean' rule in the samples/bpf Makefile tries to remove backup files (ending in ~). However, if no such files exist, it will instead try to remove the user's home directory. While the attempt is mostly harmless, it does lead to a somewhat scary warning like this: rm: cannot remove '~': Is a directory Fix this by using find instead of shell expansion to locate any actual backup files that need to be removed. Fixes: b62a796c109c ("samples/bpf: allow make to be run from samples/bpf/ directory") Acked-by: Jesper Dangaard Brouer Signed-off-by: Toke Høiland-Jørgensen --- samples/bpf/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Makefile index 5b89c0370f33..f86d713a17a5 100644 --- a/samples/bpf/Makefile +++ b/samples/bpf/Makefile @@ -254,7 +254,7 @@ all: clean: $(MAKE) -C ../../ M=$(CURDIR) clean - @rm -f *~ + @find $(CURDIR) -type f -name '*~' -delete $(LIBBPF): FORCE # Fix up variables inherited from Kbuild that tools/ build system won't like