[v4,09/12] selftests/mm: Drop unnecessary sudo usage

Message ID	20250311-mm-selftests-v4-9-dec210a658f5@google.com
State	New
Headers	show Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906E4255E37 for <linux-kselftest@vger.kernel.org>; Tue, 11 Mar 2025 13:18:37 +0000 (UTC) Date: Tue, 11 Mar 2025 13:18:20 +0000 In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Precedence: bulk Mime-Version: 1.0 References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com> Message-ID: <20250311-mm-selftests-v4-9-dec210a658f5@google.com> Subject: [PATCH v4 09/12] selftests/mm: Drop unnecessary sudo usage From: Brendan Jackman <jackmanb@google.com> To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>, Andrew Morton <akpm@linux-foundation.org>, Shuah Khan <shuah@kernel.org> Cc: Dev Jain <dev.jain@arm.com>, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Brendan Jackman <jackmanb@google.com> Content-Type: text/plain; charset="utf-8"
Series	[v4,01/12] selftests/mm: Report errno when things fail in gup_longterm \| expand [v4,01/12] selftests/mm: Report errno when things fail in gup_longterm [v4,03/12] selftests/mm: Skip uffd-wp-mremap if userfaultfd not available [v4,05/12] selftests/mm: Print some details when uffd-stress gets bad params [v4,07/12] selftests/mm: Skip map_populate on weird filesystems [v4,09/12] selftests/mm: Drop unnecessary sudo usage [v4,11/12] selftests/mm: Skip mlock tests if nobody user can't read it

Message ID

20250311-mm-selftests-v4-9-dec210a658f5@google.com

State

New

Headers

Date: Tue, 11 Mar 2025 13:18:20 +0000
In-Reply-To: <20250311-mm-selftests-v4-0-dec210a658f5@google.com>
Precedence: bulk
Mime-Version: 1.0
References: <20250311-mm-selftests-v4-0-dec210a658f5@google.com>
Message-ID: <20250311-mm-selftests-v4-9-dec210a658f5@google.com>
Subject: [PATCH v4 09/12] selftests/mm: Drop unnecessary sudo usage
From: Brendan Jackman <jackmanb@google.com>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
 Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <shuah@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>, linux-mm@kvack.org,
 linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Brendan Jackman <jackmanb@google.com>
Content-Type: text/plain; charset="utf-8"

Series

[v4,01/12] selftests/mm: Report errno when things fail in gup_longterm | expand

Commit Message

Brendan Jackman March 11, 2025, 1:18 p.m. UTC

This script must be run as root anyway (see all the writing to
privileged files in /proc etc).

Remove the unnecessary use of sudo to avoid breaking on single-user
systems that don't have sudo. This also avoids confusing readers.

Reviewed-by: Dev Jain <dev.jain@arm.com>
Signed-off-by: Brendan Jackman <jackmanb@google.com>
---
 tools/testing/selftests/mm/run_vmtests.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index da7e266681031d2772fb0c4139648904a18e0bf9..0f9fe757c3320a6551e39b6d4552fd4874b0bf43 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -386,7 +386,7 @@  CATEGORY="madv_populate" run_test ./madv_populate
 
 if [ -x ./memfd_secret ]
 then
-(echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix
+(echo 0 > /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix
 CATEGORY="memfd_secret" run_test ./memfd_secret
 fi

[v4,09/12] selftests/mm: Drop unnecessary sudo usage

Commit Message

Patch